diff mbox series

[U-Boot,v4,1/3] dm: led: Support "default-state" property

Message ID 20180411091629.3113-2-linux-kernel-dev@beckhoff.com
State Accepted
Delegated to: Tom Rini
Headers show
Series This series adds support for gpio-leds "default-state" property. The | expand

Commit Message

linux-kernel-dev April 11, 2018, 9:16 a.m. UTC 
From: Patrick Bruenn <p.bruenn@beckhoff.com>

Add support for the device tree property "default-state". This feature
might be useful for LEDs indicating "power on" or similar states.

Note: Even with this commit gpio-leds remain in reset state. That's
because the led_gpio is not probed until DM_FLAG_ACTIVATED is set.

Signed-off-by: Patrick Bruenn <p.bruenn@beckhoff.com>

---

Changes in v4:
- don't break 'make tests'
- rebased on 2600df4f8ef12ece9cec13030005919e0ba2b0d5 (master
  2018-04-09)

Changes in v3:
- use ofnode_read_bool() instead of ofnode_read_string() to determine if
  LED node has the default-state property

Changes in v2:
- rebase to v2018.05-rc1
- add dm_test_led_default_state() to tests/dm/led.c

 drivers/led/led_gpio.c | 16 +++++++++++++++-
 1 file changed, 15 insertions(+), 1 deletion(-)

Comments

Tom Rini May 8, 2018, 5:15 p.m. UTC | #1 
On Wed, Apr 11, 2018 at 11:16:27AM +0200, linux-kernel-dev@beckhoff.com wrote:

> From: Patrick Bruenn <p.bruenn@beckhoff.com>
> 
> Add support for the device tree property "default-state". This feature
> might be useful for LEDs indicating "power on" or similar states.
> 
> Note: Even with this commit gpio-leds remain in reset state. That's
> because the led_gpio is not probed until DM_FLAG_ACTIVATED is set.
> 
> Signed-off-by: Patrick Bruenn <p.bruenn@beckhoff.com>

Applied to u-boot/master, thanks!
diff mbox series

Patch

diff --git a/drivers/led/led_gpio.c b/drivers/led/led_gpio.c
index 9976635887..e68d8d3864 100644
--- a/drivers/led/led_gpio.c
+++ b/drivers/led/led_gpio.c
@@ -60,11 +60,25 @@  static int led_gpio_probe(struct udevice *dev)
 {
 	struct led_uc_plat *uc_plat = dev_get_uclass_platdata(dev);
 	struct led_gpio_priv *priv = dev_get_priv(dev);
+	const char *default_state;
+	int ret;
 
 	/* Ignore the top-level LED node */
 	if (!uc_plat->label)
 		return 0;
-	return gpio_request_by_name(dev, "gpios", 0, &priv->gpio, GPIOD_IS_OUT);
+
+	ret = gpio_request_by_name(dev, "gpios", 0, &priv->gpio, GPIOD_IS_OUT);
+	if (ret)
+		return ret;
+
+	default_state = dev_read_string(dev, "default-state");
+	if (default_state) {
+		if (!strncmp(default_state, "on", 2))
+			gpio_led_set_state(dev, LEDST_ON);
+		else if (!strncmp(default_state, "off", 3))
+			gpio_led_set_state(dev, LEDST_OFF);
+	}
+	return 0;
 }
 
 static int led_gpio_remove(struct udevice *dev)