Message ID | cover.1525253481.git.rahul.lakkireddy@chelsio.com |
---|---|
Headers | show |
Series | kernel: add support to collect hardware logs in crash recovery kernel | expand |
From: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com> Date: Wed, 2 May 2018 15:17:16 +0530 > This series of patches add new generic framework that enable device > drivers to collect device specific snapshot of the hardware/firmware > state of the underlying device in the crash recovery kernel. In crash > recovery kernel, the collected logs are added as elf notes to > /proc/vmcore, which is copied by user space scripts for post-analysis. Eric B., since you've been giving very useful and active feedback on this series could you please give it a review? Thank you.
I'm deferring this patch series. If we can't get a reasonable review from an interested party in 10+ days, that is not reasonable. Resubmit this once someone reviews it properly. Thank you.
David Miller <davem@davemloft.net> writes: > I'm deferring this patch series. > > If we can't get a reasonable review from an interested party in 10+ > days, that is not reasonable. > > Resubmit this once someone reviews it properly. David I am out on vacation this week and last (the reason for the delay). The last version of this that I looked at I gave my ack. All of my ABI concerns had been addressed. The only outstanding change I believe was the Eric Dumazet's asking about something being reviewed. I just glanced over it again and I don't see any new issues introduced by the last round of changes. From 10,000 feet flyover design perspectie and from an ABI perspective this patchset seems fine. Acked-by: "Eric W. Biederman" <ebiederm@xmission.com> Eric
From: ebiederm@xmission.com (Eric W. Biederman) Date: Mon, 14 May 2018 08:11:24 -0500 > David Miller <davem@davemloft.net> writes: > >> I'm deferring this patch series. >> >> If we can't get a reasonable review from an interested party in 10+ >> days, that is not reasonable. >> >> Resubmit this once someone reviews it properly. > > David I am out on vacation this week and last (the reason for the delay). > > The last version of this that I looked at I gave my ack. All of my ABI > concerns had been addressed. The only outstanding change I believe was > the Eric Dumazet's asking about something being reviewed. > > I just glanced over it again and I don't see any new issues introduced > by the last round of changes. > > From 10,000 feet flyover design perspectie and from an ABI perspective > this patchset seems fine. > > Acked-by: "Eric W. Biederman" <ebiederm@xmission.com> Ok, thanks for reviewing Eric. Series applied.