diff mbox series

8139too: Use disable_irq_nosync() in rtl8139_poll_controller()

Message ID 20180502113057.18209-1-bigeasy@linutronix.de
State Accepted, archived
Delegated to: David Miller
Headers show
Series 8139too: Use disable_irq_nosync() in rtl8139_poll_controller() | expand

Commit Message

Sebastian Andrzej Siewior May 2, 2018, 11:30 a.m. UTC 
From: Ingo Molnar <mingo@elte.hu>

Use disable_irq_nosync() instead of disable_irq() as this might be
called in atomic context with netpoll.

Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
---
 drivers/net/ethernet/realtek/8139too.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

David Miller May 2, 2018, 5:22 p.m. UTC | #1 
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Date: Wed,  2 May 2018 13:30:57 +0200

> From: Ingo Molnar <mingo@elte.hu>
> 
> Use disable_irq_nosync() instead of disable_irq() as this might be
> called in atomic context with netpoll.
> 
> Signed-off-by: Ingo Molnar <mingo@elte.hu>
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>

Applied and queued up for -stable, thanks.
diff mbox series

Patch

diff --git a/drivers/net/ethernet/realtek/8139too.c b/drivers/net/ethernet/realtek/8139too.c
index d24b47b8e0b2..d118da5a10a2 100644
--- a/drivers/net/ethernet/realtek/8139too.c
+++ b/drivers/net/ethernet/realtek/8139too.c
@@ -2224,7 +2224,7 @@  static void rtl8139_poll_controller(struct net_device *dev)
 	struct rtl8139_private *tp = netdev_priv(dev);
 	const int irq = tp->pci_dev->irq;
 
-	disable_irq(irq);
+	disable_irq_nosync(irq);
 	rtl8139_interrupt(irq, dev);
 	enable_irq(irq);
 }