| Message ID | 1525256676-24335-1-git-send-email-vbhadram@nvidia.com |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
| Series | [net-next] net: phy: broadcom: add support for BCM89610 PHY | expand |
On Wed, May 02, 2018 at 03:54:36PM +0530, Bhadram Varka wrote: > It adds support for BCM89610 (Single-Port 10/100/1000BASE-T) > transceiver which is used in P3310 Tegra186 platform. > > Signed-off-by: Bhadram Varka <vbhadram@nvidia.com> > --- > drivers/net/phy/broadcom.c | 11 +++++++++++ > include/linux/brcmphy.h | 1 + > 2 files changed, 12 insertions(+) > > diff --git a/drivers/net/phy/broadcom.c b/drivers/net/phy/broadcom.c > index 3bb6b66..1e4b6c2 100644 > --- a/drivers/net/phy/broadcom.c > +++ b/drivers/net/phy/broadcom.c > @@ -720,6 +720,16 @@ static struct phy_driver broadcom_drivers[] = { > .get_strings = bcm_phy_get_strings, > .get_stats = bcm53xx_phy_get_stats, > .probe = bcm53xx_phy_probe, > +}, { > + .phy_id = PHY_ID_BCM89610, > + .phy_id_mask = 0xfffffff0, > + .name = "Broadcom BCM89610", > + .features = PHY_GBIT_FEATURES | > + SUPPORTED_Pause | SUPPORTED_Asym_Pause, Hi Bhadram Why do you have SUPPORTED_Pause | SUPPORTED_Asym_Pause. No other PHY does. Take a look at Documentation/networking/phy.txt Andrew
On 5/2/2018 6:59 PM, Andrew Lunn wrote: > On Wed, May 02, 2018 at 03:54:36PM +0530, Bhadram Varka wrote: >> It adds support for BCM89610 (Single-Port 10/100/1000BASE-T) >> transceiver which is used in P3310 Tegra186 platform. >> >> Signed-off-by: Bhadram Varka <vbhadram@nvidia.com> >> --- >> drivers/net/phy/broadcom.c | 11 +++++++++++ >> include/linux/brcmphy.h | 1 + >> 2 files changed, 12 insertions(+) >> >> diff --git a/drivers/net/phy/broadcom.c b/drivers/net/phy/broadcom.c >> index 3bb6b66..1e4b6c2 100644 >> --- a/drivers/net/phy/broadcom.c >> +++ b/drivers/net/phy/broadcom.c >> @@ -720,6 +720,16 @@ static struct phy_driver broadcom_drivers[] = { >> .get_strings = bcm_phy_get_strings, >> .get_stats = bcm53xx_phy_get_stats, >> .probe = bcm53xx_phy_probe, >> +}, { >> + .phy_id = PHY_ID_BCM89610, >> + .phy_id_mask = 0xfffffff0, >> + .name = "Broadcom BCM89610", >> + .features = PHY_GBIT_FEATURES | >> + SUPPORTED_Pause | SUPPORTED_Asym_Pause, > Hi Bhadram > > Why do you have SUPPORTED_Pause | SUPPORTED_Asym_Pause. No other PHY > does. Hi Andrew, Thanks for the review. Yes - got it. I will push updated patch. Thanks, Bhadram. ----------------------------------------------------------------------------------- This email message is for the sole use of the intended recipient(s) and may contain confidential information. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please contact the sender by reply email and destroy all copies of the original message. -----------------------------------------------------------------------------------
Please remove the email footer from your postings here that talks about confidential information and whatnot. That is expressly inappropriate for this mailing list, and any such postings shall be ignored in their entirety. Thank you.
HI David, On 5/2/2018 10:51 PM, David Miller wrote: > > Please remove the email footer from your postings here that talks about > confidential information and whatnot. > > That is expressly inappropriate for this mailing list, and any such > postings shall be ignored in their entirety. > I Understand this. Fixed my e-mail client to address this. Sorry for the noise. Thanks, Bhadram.
diff --git a/drivers/net/phy/broadcom.c b/drivers/net/phy/broadcom.c index 3bb6b66..1e4b6c2 100644 --- a/drivers/net/phy/broadcom.c +++ b/drivers/net/phy/broadcom.c @@ -720,6 +720,16 @@ static struct phy_driver broadcom_drivers[] = { .get_strings = bcm_phy_get_strings, .get_stats = bcm53xx_phy_get_stats, .probe = bcm53xx_phy_probe, +}, { + .phy_id = PHY_ID_BCM89610, + .phy_id_mask = 0xfffffff0, + .name = "Broadcom BCM89610", + .features = PHY_GBIT_FEATURES | + SUPPORTED_Pause | SUPPORTED_Asym_Pause, + .flags = PHY_HAS_INTERRUPT, + .config_init = bcm54xx_config_init, + .ack_interrupt = bcm_phy_ack_intr, + .config_intr = bcm_phy_config_intr, } }; module_phy_driver(broadcom_drivers); @@ -741,6 +751,7 @@ static struct mdio_device_id __maybe_unused broadcom_tbl[] = { { PHY_ID_BCMAC131, 0xfffffff0 }, { PHY_ID_BCM5241, 0xfffffff0 }, { PHY_ID_BCM5395, 0xfffffff0 }, + { PHY_ID_BCM89610, 0xfffffff0 }, { } }; diff --git a/include/linux/brcmphy.h b/include/linux/brcmphy.h index d3339dd..b324e01 100644 --- a/include/linux/brcmphy.h +++ b/include/linux/brcmphy.h @@ -25,6 +25,7 @@ #define PHY_ID_BCM54612E 0x03625e60 #define PHY_ID_BCM54616S 0x03625d10 #define PHY_ID_BCM57780 0x03625d90 +#define PHY_ID_BCM89610 0x03625cd0 #define PHY_ID_BCM7250 0xae025280 #define PHY_ID_BCM7260 0xae025190
It adds support for BCM89610 (Single-Port 10/100/1000BASE-T) transceiver which is used in P3310 Tegra186 platform. Signed-off-by: Bhadram Varka <vbhadram@nvidia.com> --- drivers/net/phy/broadcom.c | 11 +++++++++++ include/linux/brcmphy.h | 1 + 2 files changed, 12 insertions(+)