Message ID | 20180427184744.28798-4-raghuramchary.jallipalli@microchip.com |
---|---|
State | Superseded, archived |
Delegated to: | David Miller |
Headers | show |
Series | lan78xx updates along with Fixed phy Support | expand |
Hello! On 04/27/2018 09:47 PM, Raghuram Chary J wrote: > Modify the error messages when phy registration fails. > > Signed-off-by: Raghuram Chary J <raghuramchary.jallipalli@microchip.com> > --- > drivers/net/usb/lan78xx.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/usb/lan78xx.c b/drivers/net/usb/lan78xx.c > index 54f8db887e3d..4b930c9faa16 100644 > --- a/drivers/net/usb/lan78xx.c > +++ b/drivers/net/usb/lan78xx.c > @@ -2100,14 +2100,14 @@ static struct phy_device *lan7801_phy_init(struct lan78xx_net *dev) > ret = phy_register_fixup_for_uid(PHY_KSZ9031RNX, 0xfffffff0, > ksz9031rnx_fixup); > if (ret < 0) { > - netdev_err(dev->net, "fail to register fixup\n"); > + netdev_err(dev->net, "fail to register fixup for PHY_KSZ9031RNX\n"); Could correct "fail" to "failed", while at it. > return NULL; > } > /* external PHY fixup for LAN8835 */ > ret = phy_register_fixup_for_uid(PHY_LAN8835, 0xfffffff0, > lan8835_fixup); > if (ret < 0) { > - netdev_err(dev->net, "fail to register fixup\n"); > + netdev_err(dev->net, "fail to register fixup for PHY_LAN8835\n"); Likewise. [...] MBR, Sergei
diff --git a/drivers/net/usb/lan78xx.c b/drivers/net/usb/lan78xx.c index 54f8db887e3d..4b930c9faa16 100644 --- a/drivers/net/usb/lan78xx.c +++ b/drivers/net/usb/lan78xx.c @@ -2100,14 +2100,14 @@ static struct phy_device *lan7801_phy_init(struct lan78xx_net *dev) ret = phy_register_fixup_for_uid(PHY_KSZ9031RNX, 0xfffffff0, ksz9031rnx_fixup); if (ret < 0) { - netdev_err(dev->net, "fail to register fixup\n"); + netdev_err(dev->net, "fail to register fixup for PHY_KSZ9031RNX\n"); return NULL; } /* external PHY fixup for LAN8835 */ ret = phy_register_fixup_for_uid(PHY_LAN8835, 0xfffffff0, lan8835_fixup); if (ret < 0) { - netdev_err(dev->net, "fail to register fixup\n"); + netdev_err(dev->net, "fail to register fixup for PHY_LAN8835\n"); return NULL; } /* add more external PHY fixup here if needed */
Modify the error messages when phy registration fails. Signed-off-by: Raghuram Chary J <raghuramchary.jallipalli@microchip.com> --- drivers/net/usb/lan78xx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)