| Message ID | 1524412319-6836-1-git-send-email-guillaume.bressaix@gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [v3,1/1] reaver: fix build errors with static lib | expand |
Hello, On Sun, 22 Apr 2018 17:51:59 +0200, Guillaume W. Bres wrote: > Signed-off-by: Guillaume W. Bres <guillaume.bressaix@gmail.com> This commit log was way too short, and lacked a reference to the autobuilder failure being fixed. I've fixed that when applying. > +ifeq ($(BR2_STATIC_LIBS),y) > +REAVER_CONF_OPTS += LIBS="`$(STAGING_DIR)/usr/bin/pcap-config --static --additional-libs`" > +REAVER_CONF_OPTS += LDFLAGS="`$(STAGING_DIR)/usr/bin/pcap-config --static --additional-libs`" Other issues/improvements here: - We generally pass such variables in <pkg>_CONF_ENV - A single <pkg>_CONF_ENV assignment is enough - LDFLAGS shouldn't be overridden entirely: $(TARGET_LDFLAGS) still needs to be passed. I've fixed those different problems, and applied. See the final commit at: https://git.buildroot.org/buildroot/commit/?id=559416ffe2039d1cac94e348bd28e963adf008a4 Thanks! Thomas
2018-04-25 22:32 GMT+02:00 Thomas Petazzoni <thomas.petazzoni@bootlin.com>: > Hello, > > On Sun, 22 Apr 2018 17:51:59 +0200, Guillaume W. Bres wrote: > > Signed-off-by: Guillaume W. Bres <guillaume.bressaix@gmail.com> > > This commit log was way too short, and lacked a reference to the > autobuilder failure being fixed. I've fixed that when applying. > > > +ifeq ($(BR2_STATIC_LIBS),y) > > +REAVER_CONF_OPTS += LIBS="`$(STAGING_DIR)/usr/bin/pcap-config --static > --additional-libs`" > > +REAVER_CONF_OPTS += LDFLAGS="`$(STAGING_DIR)/usr/bin/pcap-config > --static --additional-libs`" > > Other issues/improvements here: > > - We generally pass such variables in <pkg>_CONF_ENV > > - A single <pkg>_CONF_ENV assignment is enough > > - LDFLAGS shouldn't be overridden entirely: $(TARGET_LDFLAGS) still > needs to be passed. > > I've fixed those different problems, and applied. See the final commit > at: > > https://git.buildroot.org/buildroot/commit/?id= > 559416ffe2039d1cac94e348bd28e963adf008a4 > > Thanks! > > Thomas > -- > Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons) > Embedded Linux and Kernel engineering > https://bootlin.com > Hello, - LDFLAGS shouldn't be overridden entirely: $(TARGET_LDFLAGS) still needs > to be passed. yes you're right, I should have done it - We generally pass such variables in <pkg>_CONF_ENV I did not know what would work, in the sense the configure command is $CONF_ENV ./configure $CONF_OPTS I thought these flags had to be passed after "./configure" This commit log was way too short, I agree & my first commits were confusing and lacked a reference to the autobuilder failure being fixed. I've fixed > that when applying. honestly my first 2 versions included it, I "forgot" to add it to my last submission Guillaume W. Bres Software engineer - Noise XT 10a Rue Blaise Pascal, 78990 Elancourt <guillaume.bressaix@gmail.com> <div dir="ltr"><div class="gmail_extra"><br><div class="gmail_quote">2018-04-25 22:32 GMT+02:00 Thomas Petazzoni <span dir="ltr"><<a href="mailto:thomas.petazzoni@bootlin.com" target="_blank">thomas.petazzoni@bootlin.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hello,<br> <span class=""><br> On Sun, 22 Apr 2018 17:51:59 +0200, Guillaume W. Bres wrote:<br> > Signed-off-by: Guillaume W. Bres <<a href="mailto:guillaume.bressaix@gmail.com">guillaume.bressaix@gmail.com</a>><br> <br> </span>This commit log was way too short, and lacked a reference to the<br> autobuilder failure being fixed. I've fixed that when applying.<br> <span class=""><br> > +ifeq ($(BR2_STATIC_LIBS),y)<br> > +REAVER_CONF_OPTS += LIBS="`$(STAGING_DIR)/usr/bin/<wbr>pcap-config --static --additional-libs`"<br> > +REAVER_CONF_OPTS += LDFLAGS="`$(STAGING_DIR)/usr/<wbr>bin/pcap-config --static --additional-libs`"<br> <br> </span>Other issues/improvements here:<br> <br> - We generally pass such variables in <pkg>_CONF_ENV<br> <br> - A single <pkg>_CONF_ENV assignment is enough<br> <br> - LDFLAGS shouldn't be overridden entirely: $(TARGET_LDFLAGS) still<br> needs to be passed.<br> <br> I've fixed those different problems, and applied. See the final commit<br> at:<br> <br> <a href="https://git.buildroot.org/buildroot/commit/?id=559416ffe2039d1cac94e348bd28e963adf008a4" rel="noreferrer" target="_blank">https://git.buildroot.org/<wbr>buildroot/commit/?id=<wbr>559416ffe2039d1cac94e348bd28e9<wbr>63adf008a4</a><br> <br> Thanks!<br> <span class="HOEnZb"><font color="#888888"><br> Thomas<br> -- <br> Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)<br> Embedded Linux and Kernel engineering<br> <a href="https://bootlin.com" rel="noreferrer" target="_blank">https://bootlin.com</a><br> </font></span></blockquote></div><br></div><div class="gmail_extra"><br></div><div class="gmail_extra"><span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">Hello,</span><div style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration-style:initial;text-decoration-color:initial"><br></div><blockquote class="gmail_quote" style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration-style:initial;text-decoration-color:initial;margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">- LDFLAGS shouldn't be overridden entirely: $(TARGET_LDFLAGS) still needs to be passed.</blockquote><div style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration-style:initial;text-decoration-color:initial"><br></div><div style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration-style:initial;text-decoration-color:initial">yes you're right, I should have done it</div><div style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration-style:initial;text-decoration-color:initial"><br></div><blockquote class="gmail_quote" style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration-style:initial;text-decoration-color:initial;margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> - We generally pass such variables in <pkg>_CONF_ENV</blockquote><div style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration-style:initial;text-decoration-color:initial"><br></div><div style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration-style:initial;text-decoration-color:initial">I did not know what would work, in the sense the configure command is</div><div style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration-style:initial;text-decoration-color:initial"><br></div></div><blockquote style="margin:0 0 0 40px;border:none;padding:0px"><div class="gmail_extra"><div style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration-style:initial;text-decoration-color:initial">$CONF_ENV ./configure $CONF_OPTS</div><div style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration-style:initial;text-decoration-color:initial"><br></div></div></blockquote><div class="gmail_extra"><div style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration-style:initial;text-decoration-color:initial">I thought these flags had to be passed after "./configure"</div><div style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration-style:initial;text-decoration-color:initial"><br></div><div style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration-style:initial;text-decoration-color:initial"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">This commit log was way too short, </blockquote><div><br></div><div>I agree & my first commits were confusing</div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">and lacked a reference to the autobuilder failure being fixed. I've fixed that when applying.</blockquote></div><div style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration-style:initial;text-decoration-color:initial"><br></div><div style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration-style:initial;text-decoration-color:initial">honestly my first 2 versions included it, I "forgot" to add it to my last submission</div><div style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration-style:initial;text-decoration-color:initial"><br></div><div style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration-style:initial;text-decoration-color:initial"><br></div><div class="gmail_extra" style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration-style:initial;text-decoration-color:initial"><div><div class="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div><div><font face="arial,helvetica,sans-serif">Guillaume W. Bres<br></font></div><font face="arial,helvetica,sans-serif">Software engineer</font><span> </span>- Noise XT<br>10a Rue Blaise Pascal,</div><div>78990 Elancourt</div><font face="arial,helvetica,sans-serif"></font></div><font face="arial,helvetica,sans-serif"><<a href="mailto:guillaume.bressaix@gmail.com" target="_blank" style="color:rgb(17,85,204)">guillaume.bressaix@gmail.com</a>><br></font></div></div></div></div></div></div></div></div></div></div><br class="gmail-Apple-interchange-newline"><br></div><div class="gmail_extra"><br></div></div>
diff --git a/package/reaver/reaver.mk b/package/reaver/reaver.mk index 90d1727..8dfec32 100644 --- a/package/reaver/reaver.mk +++ b/package/reaver/reaver.mk @@ -14,4 +14,9 @@ REAVER_LICENSE_FILES = docs/LICENSE REAVER_SUBDIR = src REAVER_DEPENDENCIES = libpcap +ifeq ($(BR2_STATIC_LIBS),y) +REAVER_CONF_OPTS += LIBS="`$(STAGING_DIR)/usr/bin/pcap-config --static --additional-libs`" +REAVER_CONF_OPTS += LDFLAGS="`$(STAGING_DIR)/usr/bin/pcap-config --static --additional-libs`" +endif + $(eval $(autotools-package))
Signed-off-by: Guillaume W. Bres <guillaume.bressaix@gmail.com> --- v2: build now passes even when BR2_STATIC_LIB=y, LIBS+=pcap-config caused "./configure" tu pass, LDFLAGS+=pcap-config fixed problems with "make", they're both needed. v3: edited commit to something more releavant package/reaver/reaver.mk | 5 +++++ 1 file changed, 5 insertions(+)