| Message ID | 1524248835-4552-1-git-send-email-guillaume.bressaix@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v2,1/1] reaver: add missing dependency on non static lib. | expand |
Hello, On Fri, 20 Apr 2018 20:27:15 +0200, Guillaume W. Bres wrote: > +ifeq ($(BR2_STATIC_LIBS),y) > +REAVER_CONF_OPTS += LIBS="`$(STAGING_DIR)/usr/bin/pcap-config --static --additional-libs`" > +REAVER_CONF_OPTS += LDFLAGS="`$(STAGING_DIR)/usr/bin/pcap-config --static --additional-libs`" > +endif Are you sure you need both LIBS and LDFLAGS ? Best regards, Thomas
2018-04-20 20:56 GMT+02:00 Thomas Petazzoni <thomas.petazzoni@bootlin.com>: > Hello, > > On Fri, 20 Apr 2018 20:27:15 +0200, Guillaume W. Bres wrote: > > > +ifeq ($(BR2_STATIC_LIBS),y) > > +REAVER_CONF_OPTS += LIBS="`$(STAGING_DIR)/usr/bin/pcap-config --static > --additional-libs`" > > +REAVER_CONF_OPTS += LDFLAGS="`$(STAGING_DIR)/usr/bin/pcap-config > --static --additional-libs`" > > +endif > > Are you sure you need both LIBS and LDFLAGS ? > > yes I confirm this configuration does not build without these two lines. "LIBS+=" caused "./configure" to pass, but then "make" failed with missing reference to -ldbus-1. "LDFLAGS+=" caused "make" to pass. LDFLAGS on its own does not solve the "./configure" issue <div dir="ltr"><div class="gmail_extra"><div><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div><div>2018-04-20 20:56 GMT+02:00 Thomas Petazzoni <span dir="ltr"><<a href="mailto:thomas.petazzoni@bootlin.com" target="_blank">thomas.petazzoni@bootlin.com</a>></span>:<br></div></div></div></div></div></div></div></div></div></div></div></div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hello,<br> <span class=""><br> On Fri, 20 Apr 2018 20:27:15 +0200, Guillaume W. Bres wrote:<br> <br> > +ifeq ($(BR2_STATIC_LIBS),y)<br> > +REAVER_CONF_OPTS += LIBS="`$(STAGING_DIR)/usr/bin/<wbr>pcap-config --static --additional-libs`"<br> > +REAVER_CONF_OPTS += LDFLAGS="`$(STAGING_DIR)/usr/<wbr>bin/pcap-config --static --additional-libs`"<br> > +endif<br> <br> </span>Are you sure you need both LIBS and LDFLAGS ?<br><span class="HOEnZb"><font color="#888888"><br></font></span></blockquote><div><br></div><div>yes I confirm this configuration does not build without these two lines. <br>"LIBS+=" caused "./configure" to pass, but then "make" failed with missing reference to -ldbus-1.<br>"LDFLAGS+=" caused "make" to pass. LDFLAGS on its own does not solve the "./configure" issue</div></div></div></div>
Hi Guillaume, On Fri, Apr 20, 2018 at 08:27:15PM +0200, Guillaume W. Bres wrote: > Fixes > > http://autobuild.buildroot.net/results/0fb387f0544e962e5080ea966864f325fbaf4117 > > Signed-off-by: Guillaume W. Bres <guillaume.bressaix@gmail.com> > --- > > v2: static libs are now allowed. I used Arnout's suggestion > which caused ./configure to pass. Then there was a linker problem > that was solved by using the trick on LDFLAGS this time. Build now passes. The patch title is wrong now. Should be something like "fix static build". baruch
diff --git a/package/reaver/reaver.mk b/package/reaver/reaver.mk index 90d1727..8dfec32 100644 --- a/package/reaver/reaver.mk +++ b/package/reaver/reaver.mk @@ -14,4 +14,9 @@ REAVER_LICENSE_FILES = docs/LICENSE REAVER_SUBDIR = src REAVER_DEPENDENCIES = libpcap +ifeq ($(BR2_STATIC_LIBS),y) +REAVER_CONF_OPTS += LIBS="`$(STAGING_DIR)/usr/bin/pcap-config --static --additional-libs`" +REAVER_CONF_OPTS += LDFLAGS="`$(STAGING_DIR)/usr/bin/pcap-config --static --additional-libs`" +endif + $(eval $(autotools-package))
Fixes http://autobuild.buildroot.net/results/0fb387f0544e962e5080ea966864f325fbaf4117 Signed-off-by: Guillaume W. Bres <guillaume.bressaix@gmail.com> --- v2: static libs are now allowed. I used Arnout's suggestion which caused ./configure to pass. Then there was a linker problem that was solved by using the trick on LDFLAGS this time. Build now passes. package/reaver/reaver.mk | 5 +++++ 1 file changed, 5 insertions(+)