Message ID | 828d8a53d85be073672fec67ee6980818dc459ab.1524038460.git.gustavo.pimentel@synopsys.com |
---|---|
State | Not Applicable |
Delegated to: | Lorenzo Pieralisi |
Headers | show |
Series | PCI: dwc: artpec6: Use devm_ioremap_resource instead of devm_ioremap_resource | expand |
On Wed, Apr 18, 2018 at 09:06:33AM +0100, Gustavo Pimentel wrote: > This fix aims to replace the use of devm_ioremap() by > devm_ioremap_resource() already discussed on [1]. > > [1] -> https://patchwork.kernel.org/patch/10173831/ > > Signed-off-by: Gustavo Pimentel <gustavo.pimentel@synopsys.com> Looks good: Acked-by: Jesper Nilsson <jesper.nilsson@axis.com> > --- > drivers/pci/dwc/pcie-artpec6.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/pci/dwc/pcie-artpec6.c b/drivers/pci/dwc/pcie-artpec6.c > index e66cede..321b56c 100644 > --- a/drivers/pci/dwc/pcie-artpec6.c > +++ b/drivers/pci/dwc/pcie-artpec6.c > @@ -463,9 +463,9 @@ static int artpec6_add_pcie_ep(struct artpec6_pcie *artpec6_pcie, > ep->ops = &pcie_ep_ops; > > res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "dbi2"); > - pci->dbi_base2 = devm_ioremap(dev, res->start, resource_size(res)); > - if (!pci->dbi_base2) > - return -ENOMEM; > + pci->dbi_base2 = devm_ioremap_resource(dev, res); > + if (IS_ERR(pci->dbi_base2)) > + return PTR_ERR(pci->dbi_base2); > > res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "addr_space"); > if (!res) > -- > 2.7.4 > /^JN - Jesper Nilsson
diff --git a/drivers/pci/dwc/pcie-artpec6.c b/drivers/pci/dwc/pcie-artpec6.c index e66cede..321b56c 100644 --- a/drivers/pci/dwc/pcie-artpec6.c +++ b/drivers/pci/dwc/pcie-artpec6.c @@ -463,9 +463,9 @@ static int artpec6_add_pcie_ep(struct artpec6_pcie *artpec6_pcie, ep->ops = &pcie_ep_ops; res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "dbi2"); - pci->dbi_base2 = devm_ioremap(dev, res->start, resource_size(res)); - if (!pci->dbi_base2) - return -ENOMEM; + pci->dbi_base2 = devm_ioremap_resource(dev, res); + if (IS_ERR(pci->dbi_base2)) + return PTR_ERR(pci->dbi_base2); res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "addr_space"); if (!res)
This fix aims to replace the use of devm_ioremap() by devm_ioremap_resource() already discussed on [1]. [1] -> https://patchwork.kernel.org/patch/10173831/ Signed-off-by: Gustavo Pimentel <gustavo.pimentel@synopsys.com> --- drivers/pci/dwc/pcie-artpec6.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)