| Message ID | 20180406145536.19637-1-thomas.petazzoni@bootlin.com |
|---|---|
| Headers | show |
| Series | PCI: aardvark: misc fixes and improvements | expand |
On Fri, Apr 06, 2018 at 04:55:30PM +0200, Thomas Petazzoni wrote: > Bjorn, Lorenzo, > > This patch series brings a number of improvements to the aardvark > PCIe. Hi Thomas, it is not just improvements, these look like significant bug fixes too. Let me know which patches we should prioritize since hopefully they can be sent during v4.17-rc* releases, I will queue the rest for the next merge window. Thanks, Lorenzo > > Changes since v3: > > - Introduced advk_pcie_valid_device() late in the series, so that the > patch fixing the logic in the PCIe configuration space read/write > function does not depend on it. This is needed as we don't want the > advk_pcie_valid_device() addition to go to stable. > > Changes since v2: > > - Rebased on v4.16-rc7 > > - Dropped the patches disabling L0S and aligning the MPS between RC > and EP, since we are working on a different solution, implementing > a proper root port. Therefore, this patch series only has the > (hopefully) non-controversial changes. > > - Add a patch (PATCH 1) that factorizes the logic to decide if the > target of a configuration space access is a valid device or not > into a advk_pcie_valid_device() helper, and adjust PATCH 2 > accordingly. > > - Drop unused PCIE_BDF macro in PATCH 3. > > Best regards, > > Thomas Petazzoni > > > > Evan Wang (2): > PCI: aardvark: Fix PCIe Max Read Request Size setting > PCI: aardvark: Remove PCIe outbound window configuration > > Thomas Petazzoni (1): > PCI: aardvark: Introduce an advk_pcie_valid_device() helper > > Victor Gu (3): > PCI: aardvark: Fix logic in advk_pcie_{rd,wr}_conf() > PCI: aardvark: Set PIO_ADDR_LS correctly in advk_pcie_rd_conf() > PCI: aardvark: Use ISR1 instead of ISR0 interrupt in legacy irq mode > > drivers/pci/host/pci-aardvark.c | 117 ++++++++++++++-------------------------- > 1 file changed, 39 insertions(+), 78 deletions(-) > > -- > 2.14.3 >
Hello Lorenzo, Thanks for your feedback! On Mon, 9 Apr 2018 17:23:56 +0100, Lorenzo Pieralisi wrote: > it is not just improvements, these look like significant bug fixes too. > > Let me know which patches we should prioritize since hopefully they can > be sent during v4.17-rc* releases, I will queue the rest for the next > merge window. The patches that are bug fixes are marked with a "Fixes:" tag and are Cc'ed to stable. So, the following patches are fixes: [PATCH v4 1/6] PCI: aardvark: Fix logic in advk_pcie_{rd,wr}_conf() [PATCH v4 2/6] PCI: aardvark: Set PIO_ADDR_LS correctly in advk_pcie_rd_conf() [PATCH v4 3/6] PCI: aardvark: Use ISR1 instead of ISR0 interrupt in legacy irq mode [PATCH v4 4/6] PCI: aardvark: Fix PCIe Max Read Request Size setting The following patches are improvements: [PATCH v4 5/6] PCI: aardvark: Introduce an advk_pcie_valid_device() helper [PATCH v4 6/6] PCI: aardvark: Remove PCIe outbound window configuration Thanks! Thomas
On Mon, Apr 09, 2018 at 08:54:33PM +0200, Thomas Petazzoni wrote: > Hello Lorenzo, > > Thanks for your feedback! > > On Mon, 9 Apr 2018 17:23:56 +0100, Lorenzo Pieralisi wrote: > > > it is not just improvements, these look like significant bug fixes too. > > > > Let me know which patches we should prioritize since hopefully they can > > be sent during v4.17-rc* releases, I will queue the rest for the next > > merge window. > > The patches that are bug fixes are marked with a "Fixes:" tag and are > Cc'ed to stable. > > So, the following patches are fixes: > > [PATCH v4 1/6] PCI: aardvark: Fix logic in advk_pcie_{rd,wr}_conf() > [PATCH v4 2/6] PCI: aardvark: Set PIO_ADDR_LS correctly in advk_pcie_rd_conf() > [PATCH v4 3/6] PCI: aardvark: Use ISR1 instead of ISR0 interrupt in legacy irq mode > [PATCH v4 4/6] PCI: aardvark: Fix PCIe Max Read Request Size setting > > The following patches are improvements: > > [PATCH v4 5/6] PCI: aardvark: Introduce an advk_pcie_valid_device() helper > [PATCH v4 6/6] PCI: aardvark: Remove PCIe outbound window configuration I added those four patches to my pci/host/fixes branch, please have a look if they meet your expectations and if so I will ask Bjorn to send them if he thinks they are fit for -rc*. Thanks, Lorenzo
Hello, On Wed, 18 Apr 2018 14:02:30 +0100, Lorenzo Pieralisi wrote: > > So, the following patches are fixes: > > > > [PATCH v4 1/6] PCI: aardvark: Fix logic in advk_pcie_{rd,wr}_conf() > > [PATCH v4 2/6] PCI: aardvark: Set PIO_ADDR_LS correctly in advk_pcie_rd_conf() > > [PATCH v4 3/6] PCI: aardvark: Use ISR1 instead of ISR0 interrupt in legacy irq mode > > [PATCH v4 4/6] PCI: aardvark: Fix PCIe Max Read Request Size setting > > > > The following patches are improvements: > > > > [PATCH v4 5/6] PCI: aardvark: Introduce an advk_pcie_valid_device() helper > > [PATCH v4 6/6] PCI: aardvark: Remove PCIe outbound window configuration > > I added those four patches to my pci/host/fixes branch, please have a > look if they meet your expectations and if so I will ask Bjorn to send > them if he thinks they are fit for -rc*. Looks good to me. Those four patches are indeed the ones that would ideally be sent during the -rc cycle. Thanks a lot! Thomas
Bjorn, Lorenzo, This patch series brings a number of improvements to the aardvark PCIe. Changes since v3: - Introduced advk_pcie_valid_device() late in the series, so that the patch fixing the logic in the PCIe configuration space read/write function does not depend on it. This is needed as we don't want the advk_pcie_valid_device() addition to go to stable. Changes since v2: - Rebased on v4.16-rc7 - Dropped the patches disabling L0S and aligning the MPS between RC and EP, since we are working on a different solution, implementing a proper root port. Therefore, this patch series only has the (hopefully) non-controversial changes. - Add a patch (PATCH 1) that factorizes the logic to decide if the target of a configuration space access is a valid device or not into a advk_pcie_valid_device() helper, and adjust PATCH 2 accordingly. - Drop unused PCIE_BDF macro in PATCH 3. Best regards, Thomas Petazzoni Evan Wang (2): PCI: aardvark: Fix PCIe Max Read Request Size setting PCI: aardvark: Remove PCIe outbound window configuration Thomas Petazzoni (1): PCI: aardvark: Introduce an advk_pcie_valid_device() helper Victor Gu (3): PCI: aardvark: Fix logic in advk_pcie_{rd,wr}_conf() PCI: aardvark: Set PIO_ADDR_LS correctly in advk_pcie_rd_conf() PCI: aardvark: Use ISR1 instead of ISR0 interrupt in legacy irq mode drivers/pci/host/pci-aardvark.c | 117 ++++++++++++++-------------------------- 1 file changed, 39 insertions(+), 78 deletions(-)