Message ID | 20180417192849.5661-1-cascardo@canonical.com |
---|---|
State | New |
Headers | show |
Series | [Bionic] UBUNTU: d-i: move ipr to storage-core-modules on ppc64el | expand |
On Tue, Apr 17, 2018 at 04:28:49PM -0300, Thadeu Lima de Souza Cascardo wrote: > BugLink: https://bugs.launchpad.net/bugs/1751813 > > Drivers from scsi-modules are not included in the netinst initrd, while the > ones in storage-core-modules are. > > As the installer does not wait or enable synchronous scan on the scsi devices, > if the driver is loaded late, the installer might not show all disks. > > Though loading the driver earlier does not guarantee that all disks will be > shown, it is more likely, which makes ppc64el users happier, as this is the > most used controller on IBM Power Systems. > > Moving the driver to storage-core-modules makes it included in the netinst > initrd, which makes it load earlier, and users have reported that makes disks > appear when the partitioning interface comes up. > > Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@canonical.com> Acked-by: Seth Forshee <seth.forshee@canonical.com>
On 04/17/18 21:28, Thadeu Lima de Souza Cascardo wrote: > BugLink: https://bugs.launchpad.net/bugs/1751813 > > Drivers from scsi-modules are not included in the netinst initrd, while the > ones in storage-core-modules are. > > As the installer does not wait or enable synchronous scan on the scsi devices, > if the driver is loaded late, the installer might not show all disks. > > Though loading the driver earlier does not guarantee that all disks will be > shown, it is more likely, which makes ppc64el users happier, as this is the > most used controller on IBM Power Systems. > > Moving the driver to storage-core-modules makes it included in the netinst > initrd, which makes it load earlier, and users have reported that makes disks > appear when the partitioning interface comes up. > > Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@canonical.com> Acked-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com> > --- > debian.master/d-i/modules/amd64-virtual/scsi-modules | 1 + > debian.master/d-i/modules/amd64/scsi-modules | 1 + > debian.master/d-i/modules/arm64/scsi-modules | 1 + > debian.master/d-i/modules/armhf/scsi-modules | 1 + > debian.master/d-i/modules/i386-virtual/scsi-modules | 1 + > debian.master/d-i/modules/i386/scsi-modules | 1 + > debian.master/d-i/modules/ppc64el/storage-core-modules | 1 + > debian.master/d-i/modules/s390x/scsi-modules | 1 + > debian.master/d-i/modules/scsi-modules | 1 - > 9 files changed, 8 insertions(+), 1 deletion(-) > > diff --git a/debian.master/d-i/modules/amd64-virtual/scsi-modules b/debian.master/d-i/modules/amd64-virtual/scsi-modules > index 8909dfb79487..c5e6593a7bb4 100644 > --- a/debian.master/d-i/modules/amd64-virtual/scsi-modules > +++ b/debian.master/d-i/modules/amd64-virtual/scsi-modules > @@ -1 +1,2 @@ > #include <scsi-modules> > +ipr ? > diff --git a/debian.master/d-i/modules/amd64/scsi-modules b/debian.master/d-i/modules/amd64/scsi-modules > index 8909dfb79487..c5e6593a7bb4 100644 > --- a/debian.master/d-i/modules/amd64/scsi-modules > +++ b/debian.master/d-i/modules/amd64/scsi-modules > @@ -1 +1,2 @@ > #include <scsi-modules> > +ipr ? > diff --git a/debian.master/d-i/modules/arm64/scsi-modules b/debian.master/d-i/modules/arm64/scsi-modules > index 8909dfb79487..c5e6593a7bb4 100644 > --- a/debian.master/d-i/modules/arm64/scsi-modules > +++ b/debian.master/d-i/modules/arm64/scsi-modules > @@ -1 +1,2 @@ > #include <scsi-modules> > +ipr ? > diff --git a/debian.master/d-i/modules/armhf/scsi-modules b/debian.master/d-i/modules/armhf/scsi-modules > index 8909dfb79487..c5e6593a7bb4 100644 > --- a/debian.master/d-i/modules/armhf/scsi-modules > +++ b/debian.master/d-i/modules/armhf/scsi-modules > @@ -1 +1,2 @@ > #include <scsi-modules> > +ipr ? > diff --git a/debian.master/d-i/modules/i386-virtual/scsi-modules b/debian.master/d-i/modules/i386-virtual/scsi-modules > index 8909dfb79487..c5e6593a7bb4 100644 > --- a/debian.master/d-i/modules/i386-virtual/scsi-modules > +++ b/debian.master/d-i/modules/i386-virtual/scsi-modules > @@ -1 +1,2 @@ > #include <scsi-modules> > +ipr ? > diff --git a/debian.master/d-i/modules/i386/scsi-modules b/debian.master/d-i/modules/i386/scsi-modules > index 8909dfb79487..c5e6593a7bb4 100644 > --- a/debian.master/d-i/modules/i386/scsi-modules > +++ b/debian.master/d-i/modules/i386/scsi-modules > @@ -1 +1,2 @@ > #include <scsi-modules> > +ipr ? > diff --git a/debian.master/d-i/modules/ppc64el/storage-core-modules b/debian.master/d-i/modules/ppc64el/storage-core-modules > index cb5278ea7aac..ebffb3730203 100644 > --- a/debian.master/d-i/modules/ppc64el/storage-core-modules > +++ b/debian.master/d-i/modules/ppc64el/storage-core-modules > @@ -1 +1,2 @@ > #include <storage-core-modules> > +ipr ? > diff --git a/debian.master/d-i/modules/s390x/scsi-modules b/debian.master/d-i/modules/s390x/scsi-modules > index 8909dfb79487..c5e6593a7bb4 100644 > --- a/debian.master/d-i/modules/s390x/scsi-modules > +++ b/debian.master/d-i/modules/s390x/scsi-modules > @@ -1 +1,2 @@ > #include <scsi-modules> > +ipr ? > diff --git a/debian.master/d-i/modules/scsi-modules b/debian.master/d-i/modules/scsi-modules > index 6458149cf570..002e18b5b115 100644 > --- a/debian.master/d-i/modules/scsi-modules > +++ b/debian.master/d-i/modules/scsi-modules > @@ -85,7 +85,6 @@ sun3x_esp ? > fcal ? > lasi700 ? > nsp32 ? > -ipr ? > hptiop ? > stex ? > osst ? >
On Tue, Apr 17, 2018 at 04:28:49PM -0300, Thadeu Lima de Souza Cascardo wrote: > BugLink: https://bugs.launchpad.net/bugs/1751813 > > Drivers from scsi-modules are not included in the netinst initrd, while the > ones in storage-core-modules are. > > As the installer does not wait or enable synchronous scan on the scsi devices, > if the driver is loaded late, the installer might not show all disks. > > Though loading the driver earlier does not guarantee that all disks will be > shown, it is more likely, which makes ppc64el users happier, as this is the > most used controller on IBM Power Systems. > > Moving the driver to storage-core-modules makes it included in the netinst > initrd, which makes it load earlier, and users have reported that makes disks > appear when the partitioning interface comes up. > > Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@canonical.com> Applied to bionic/master-next and unstable/master, thanks!
diff --git a/debian.master/d-i/modules/amd64-virtual/scsi-modules b/debian.master/d-i/modules/amd64-virtual/scsi-modules index 8909dfb79487..c5e6593a7bb4 100644 --- a/debian.master/d-i/modules/amd64-virtual/scsi-modules +++ b/debian.master/d-i/modules/amd64-virtual/scsi-modules @@ -1 +1,2 @@ #include <scsi-modules> +ipr ? diff --git a/debian.master/d-i/modules/amd64/scsi-modules b/debian.master/d-i/modules/amd64/scsi-modules index 8909dfb79487..c5e6593a7bb4 100644 --- a/debian.master/d-i/modules/amd64/scsi-modules +++ b/debian.master/d-i/modules/amd64/scsi-modules @@ -1 +1,2 @@ #include <scsi-modules> +ipr ? diff --git a/debian.master/d-i/modules/arm64/scsi-modules b/debian.master/d-i/modules/arm64/scsi-modules index 8909dfb79487..c5e6593a7bb4 100644 --- a/debian.master/d-i/modules/arm64/scsi-modules +++ b/debian.master/d-i/modules/arm64/scsi-modules @@ -1 +1,2 @@ #include <scsi-modules> +ipr ? diff --git a/debian.master/d-i/modules/armhf/scsi-modules b/debian.master/d-i/modules/armhf/scsi-modules index 8909dfb79487..c5e6593a7bb4 100644 --- a/debian.master/d-i/modules/armhf/scsi-modules +++ b/debian.master/d-i/modules/armhf/scsi-modules @@ -1 +1,2 @@ #include <scsi-modules> +ipr ? diff --git a/debian.master/d-i/modules/i386-virtual/scsi-modules b/debian.master/d-i/modules/i386-virtual/scsi-modules index 8909dfb79487..c5e6593a7bb4 100644 --- a/debian.master/d-i/modules/i386-virtual/scsi-modules +++ b/debian.master/d-i/modules/i386-virtual/scsi-modules @@ -1 +1,2 @@ #include <scsi-modules> +ipr ? diff --git a/debian.master/d-i/modules/i386/scsi-modules b/debian.master/d-i/modules/i386/scsi-modules index 8909dfb79487..c5e6593a7bb4 100644 --- a/debian.master/d-i/modules/i386/scsi-modules +++ b/debian.master/d-i/modules/i386/scsi-modules @@ -1 +1,2 @@ #include <scsi-modules> +ipr ? diff --git a/debian.master/d-i/modules/ppc64el/storage-core-modules b/debian.master/d-i/modules/ppc64el/storage-core-modules index cb5278ea7aac..ebffb3730203 100644 --- a/debian.master/d-i/modules/ppc64el/storage-core-modules +++ b/debian.master/d-i/modules/ppc64el/storage-core-modules @@ -1 +1,2 @@ #include <storage-core-modules> +ipr ? diff --git a/debian.master/d-i/modules/s390x/scsi-modules b/debian.master/d-i/modules/s390x/scsi-modules index 8909dfb79487..c5e6593a7bb4 100644 --- a/debian.master/d-i/modules/s390x/scsi-modules +++ b/debian.master/d-i/modules/s390x/scsi-modules @@ -1 +1,2 @@ #include <scsi-modules> +ipr ? diff --git a/debian.master/d-i/modules/scsi-modules b/debian.master/d-i/modules/scsi-modules index 6458149cf570..002e18b5b115 100644 --- a/debian.master/d-i/modules/scsi-modules +++ b/debian.master/d-i/modules/scsi-modules @@ -85,7 +85,6 @@ sun3x_esp ? fcal ? lasi700 ? nsp32 ? -ipr ? hptiop ? stex ? osst ?
BugLink: https://bugs.launchpad.net/bugs/1751813 Drivers from scsi-modules are not included in the netinst initrd, while the ones in storage-core-modules are. As the installer does not wait or enable synchronous scan on the scsi devices, if the driver is loaded late, the installer might not show all disks. Though loading the driver earlier does not guarantee that all disks will be shown, it is more likely, which makes ppc64el users happier, as this is the most used controller on IBM Power Systems. Moving the driver to storage-core-modules makes it included in the netinst initrd, which makes it load earlier, and users have reported that makes disks appear when the partitioning interface comes up. Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@canonical.com> --- debian.master/d-i/modules/amd64-virtual/scsi-modules | 1 + debian.master/d-i/modules/amd64/scsi-modules | 1 + debian.master/d-i/modules/arm64/scsi-modules | 1 + debian.master/d-i/modules/armhf/scsi-modules | 1 + debian.master/d-i/modules/i386-virtual/scsi-modules | 1 + debian.master/d-i/modules/i386/scsi-modules | 1 + debian.master/d-i/modules/ppc64el/storage-core-modules | 1 + debian.master/d-i/modules/s390x/scsi-modules | 1 + debian.master/d-i/modules/scsi-modules | 1 - 9 files changed, 8 insertions(+), 1 deletion(-)