| Message ID | 20180417152932.15121-2-sebastien.szymanski@armadeus.com |
|---|---|
| State | Accepted |
| Delegated to: | Stefano Babic |
| Headers | show |
| Series | [U-Boot,v2,1/2] imx6ul: opos6ul: add SPL_DM support | expand |
Hi Sébastien, On Tue, Apr 17, 2018 at 12:29 PM, Sébastien Szymanski <sebastien.szymanski@armadeus.com> wrote: > When booting in Serial Downloader mode load the U-Boot image using > ymodem. Not sure if you are aware, but it is possible to use imx_usb_loader to also load SPL + u-boot.img as described at: doc/README.sdp Your patch looks good, but just wanted to point out this alternative in case it fits your needs.
Hi Fabio, On 04/17/2018 11:52 PM, Fabio Estevam wrote: > Hi Sébastien, > > On Tue, Apr 17, 2018 at 12:29 PM, Sébastien Szymanski > <sebastien.szymanski@armadeus.com> wrote: >> When booting in Serial Downloader mode load the U-Boot image using >> ymodem. > > Not sure if you are aware, but it is possible to use imx_usb_loader to > also load SPL + u-boot.img as described at: > doc/README.sdp > > Your patch looks good, but just wanted to point out this alternative > in case it fits your needs. I am aware about the SDP support in U-Boot but I prefer to keep using ymodem at the moment. Thanks! Regards, >
On 17/04/2018 17:29, Sébastien Szymanski wrote: > When booting in Serial Downloader mode load the U-Boot image using > ymodem. > > Signed-off-by: Sébastien Szymanski <sebastien.szymanski@armadeus.com> > --- > > Changes for v2: > - Add commit log. > > arch/arm/mach-imx/mx6/opos6ul.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/arch/arm/mach-imx/mx6/opos6ul.c b/arch/arm/mach-imx/mx6/opos6ul.c > index ef70a7d323..5d39c0bc1b 100644 > --- a/arch/arm/mach-imx/mx6/opos6ul.c > +++ b/arch/arm/mach-imx/mx6/opos6ul.c > @@ -208,6 +208,16 @@ static struct mx6_ddr3_cfg mem_ddr = { > .trasmin = 3750, > }; > > +void board_boot_order(u32 *spl_boot_list) > +{ > + unsigned int bmode = readl(&src_base->sbmr2); > + > + if (((bmode >> 24) & 0x03) == 0x01) /* Serial Downloader */ > + spl_boot_list[0] = BOOT_DEVICE_UART; > + else > + spl_boot_list[0] = spl_boot_device(); > +} > + > static void ccgr_init(void) > { > struct mxc_ccm_reg *ccm = (struct mxc_ccm_reg *)CCM_BASE_ADDR; > Applied to u-boot-imx, thanks ! Best regards, Stefano Babic
diff --git a/arch/arm/mach-imx/mx6/opos6ul.c b/arch/arm/mach-imx/mx6/opos6ul.c index ef70a7d323..5d39c0bc1b 100644 --- a/arch/arm/mach-imx/mx6/opos6ul.c +++ b/arch/arm/mach-imx/mx6/opos6ul.c @@ -208,6 +208,16 @@ static struct mx6_ddr3_cfg mem_ddr = { .trasmin = 3750, }; +void board_boot_order(u32 *spl_boot_list) +{ + unsigned int bmode = readl(&src_base->sbmr2); + + if (((bmode >> 24) & 0x03) == 0x01) /* Serial Downloader */ + spl_boot_list[0] = BOOT_DEVICE_UART; + else + spl_boot_list[0] = spl_boot_device(); +} + static void ccgr_init(void) { struct mxc_ccm_reg *ccm = (struct mxc_ccm_reg *)CCM_BASE_ADDR;
When booting in Serial Downloader mode load the U-Boot image using ymodem. Signed-off-by: Sébastien Szymanski <sebastien.szymanski@armadeus.com> --- Changes for v2: - Add commit log. arch/arm/mach-imx/mx6/opos6ul.c | 10 ++++++++++ 1 file changed, 10 insertions(+)