| Message ID | 20180411072450.9809-3-raghuramchary.jallipalli@microchip.com |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
| Series | lan78xx: Fixes and enhancements | expand |
Hi Raghuram,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on net-next/master]
[also build test WARNING on v4.16 next-20180411]
[cannot apply to net/master]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Raghuram-Chary-J/lan78xx-Fixes-and-enhancements/20180411-231134
reproduce:
# apt-get install sparse
make ARCH=x86_64 allmodconfig
make C=1 CF=-D__CHECK_ENDIAN__
sparse warnings: (new ones prefixed by >>)
>> drivers/net/usb/lan78xx.c:281:5: sparse: symbol 'lan78xx_regs' was not declared. Should it be static?
drivers/net/usb/lan78xx.c:2992:29: sparse: cast to restricted __be16
drivers/net/usb/lan78xx.c:2992:29: sparse: cast to restricted __be16
drivers/net/usb/lan78xx.c:2992:29: sparse: cast to restricted __be16
drivers/net/usb/lan78xx.c:2992:29: sparse: cast to restricted __be16
drivers/net/usb/lan78xx.c:2992:27: sparse: incorrect type in assignment (different base types) @@ expected restricted __wsum [usertype] csum @@ got e] csum @@
drivers/net/usb/lan78xx.c:2992:27: expected restricted __wsum [usertype] csum
drivers/net/usb/lan78xx.c:2992:27: got int
Please review and possibly fold the followup patch.
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
diff --git a/drivers/net/usb/lan78xx.c b/drivers/net/usb/lan78xx.c index 55a78eb96961..cbeec784f8b8 100644 --- a/drivers/net/usb/lan78xx.c +++ b/drivers/net/usb/lan78xx.c @@ -278,6 +278,30 @@ struct lan78xx_statstage64 { u64 eee_tx_lpi_time; }; +u32 lan78xx_regs[] = { + ID_REV, + INT_STS, + HW_CFG, + PMT_CTL, + E2P_CMD, + E2P_DATA, + USB_STATUS, + VLAN_TYPE, + MAC_CR, + MAC_RX, + MAC_TX, + FLOW, + ERR_STS, + MII_ACC, + MII_DATA, + EEE_TX_LPI_REQ_DLY, + EEE_TW_TX_SYS, + EEE_TX_LPI_REM_DLY, + WUCSR +}; + +#define PHY_REG_SIZE (32 * sizeof(u32)) + struct lan78xx_net; struct lan78xx_priv { @@ -1604,6 +1628,34 @@ static int lan78xx_set_pause(struct net_device *net, return ret; } +static int lan78xx_get_regs_len(struct net_device *netdev) +{ + if (!netdev->phydev) + return (sizeof(lan78xx_regs)); + else + return (sizeof(lan78xx_regs) + PHY_REG_SIZE); +} + +static void +lan78xx_get_regs(struct net_device *netdev, struct ethtool_regs *regs, + void *buf) +{ + u32 *data = buf; + int i, j; + struct lan78xx_net *dev = netdev_priv(netdev); + + /* Read Device/MAC registers */ + for (i = 0, j = 0; i < (sizeof(lan78xx_regs) / sizeof(u32)); i++, j++) + lan78xx_read_reg(dev, lan78xx_regs[i], &data[j]); + + if (!netdev->phydev) + return; + + /* Read PHY registers */ + for (i = 0; i < 32; i++, j++) + data[j] = phy_read(netdev->phydev, i); +} + static const struct ethtool_ops lan78xx_ethtool_ops = { .get_link = lan78xx_get_link, .nway_reset = phy_ethtool_nway_reset, @@ -1624,6 +1676,8 @@ static const struct ethtool_ops lan78xx_ethtool_ops = { .set_pauseparam = lan78xx_set_pause, .get_link_ksettings = lan78xx_get_link_ksettings, .set_link_ksettings = lan78xx_set_link_ksettings, + .get_regs_len = lan78xx_get_regs_len, + .get_regs = lan78xx_get_regs, }; static int lan78xx_ioctl(struct net_device *netdev, struct ifreq *rq, int cmd)
In order to dump lan78xx family registers using ethtool, add support at lan78xx driver level. Fixes: 55d7de9de6c3 ("Microchip's LAN7800 family USB 2/3 to 10/100/1000 Ethernet device driver") Signed-off-by: Raghuram Chary J <raghuramchary.jallipalli@microchip.com> --- v0->v1: * Return device regs len if phydev is null. --- drivers/net/usb/lan78xx.c | 54 +++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 54 insertions(+)