mbox series

[v1,net,0/3] lan78xx: Fixes and enhancements

Message ID 20180411072450.9809-1-raghuramchary.jallipalli@microchip.com
Headers show
Series lan78xx: Fixes and enhancements | expand

Message

Raghuram Chary J April 11, 2018, 7:24 a.m. UTC
These series of patches have fix and enhancements for
lan78xx driver.

Raghuram Chary J (3):
  lan78xx: PHY DSP registers initialization to address EEE link drop
    issues with long cables
  lan78xx: Add support to dump lan78xx registers
  lan78xx: Lan7801 Support for Fixed PHY

 drivers/net/phy/microchip.c  | 178 ++++++++++++++++++++++++++++++++++++++++++-
 drivers/net/usb/Kconfig      |   1 +
 drivers/net/usb/lan78xx.c    |  96 ++++++++++++++++++++++-
 include/linux/microchipphy.h |   8 ++
 4 files changed, 278 insertions(+), 5 deletions(-)

Comments

Andrew Lunn April 11, 2018, 12:55 p.m. UTC | #1
On Wed, Apr 11, 2018 at 12:54:47PM +0530, Raghuram Chary J wrote:
> These series of patches have fix and enhancements for
> lan78xx driver.

Hi Raghuram

Please separate the fixes from the enhancements. The enhancements need
to wait until net-next re-opens in a weeks time. The first patch,
which is a real fix, can probably be accepted now.

      Andrew

> 
> Raghuram Chary J (3):
>   lan78xx: PHY DSP registers initialization to address EEE link drop
>     issues with long cables
>   lan78xx: Add support to dump lan78xx registers
>   lan78xx: Lan7801 Support for Fixed PHY
> 
>  drivers/net/phy/microchip.c  | 178 ++++++++++++++++++++++++++++++++++++++++++-
>  drivers/net/usb/Kconfig      |   1 +
>  drivers/net/usb/lan78xx.c    |  96 ++++++++++++++++++++++-
>  include/linux/microchipphy.h |   8 ++
>  4 files changed, 278 insertions(+), 5 deletions(-)
> 
> -- 
> 2.16.2
>
David Miller April 11, 2018, 2:20 p.m. UTC | #2
From: Raghuram Chary J <raghuramchary.jallipalli@microchip.com>
Date: Wed, 11 Apr 2018 12:54:47 +0530

> These series of patches have fix and enhancements for
> lan78xx driver.

Two problems with this series:

1) Only bug fixes are appropriate at this time.  Features and "enhancements"
   belong in net-next which is not open right now.

2) Patch #3 doesn't even apply cleanly.  Always base your patches on the
   current tree.

Thank you.
Raghuram Chary J April 11, 2018, 2:54 p.m. UTC | #3
> 
> > These series of patches have fix and enhancements for lan78xx driver.
> 
> Two problems with this series:
> 
> 1) Only bug fixes are appropriate at this time.  Features and "enhancements"
>    belong in net-next which is not open right now.
> 
> 2) Patch #3 doesn't even apply cleanly.  Always base your patches on the
>    current tree.
> 
Sure, will send  #2,#3 patches in net-next when it opens.
Also will make sure they will be based on current tree.

Thanks,
Raghu