| Message ID | 20180406061204.18257-4-raghuramchary.jallipalli@microchip.com |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
| Series | lan78xx: Fixes and enhancements | expand |
On Fri, Apr 06, 2018 at 11:42:04AM +0530, Raghuram Chary J wrote:
> Adding Fixed PHY support to the lan78xx driver.
Hi Raghuram
What do you expect is connected to the MAC if there is no PHY?
Andrew
> > What do you expect is connected to the MAC if there is no PHY? > Hi Andrew, We connect the Ethernet switch to this MAC. The Ethernet switch port connected to MAC do not have the phy. In this case, need to load the MAC driver and link speed/duplex set. Thanks, Raghu
On Tue, Apr 10, 2018 at 02:23:23AM +0000, RaghuramChary.Jallipalli@microchip.com wrote: > > > > What do you expect is connected to the MAC if there is no PHY? > > > Hi Andrew, > We connect the Ethernet switch to this MAC. Ah, cool. I was thinking you were going to say an SFP cage. What switch is it? Does it have a DSA driver? Andrew
> Ah, cool. I was thinking you were going to say an SFP cage. > > What switch is it? Does it have a DSA driver? > We have 3 port switch KSZ9893 yet to release which is similar to the one KSZ9477/KSZ9897 which has DSA driver. Most of the time 3 port switch being used with LAN7801 to extend the ports. Thanks, -Raghu
Hi,
[This is an automated email]
This commit has been processed because it contains a "Fixes:" tag,
fixing commit: 55d7de9de6c3 Microchip's LAN7800 family USB 2/3 to 10/100/1000 Ethernet device driver.
The bot has tested the following trees: v4.16.1, v4.15.16, v4.14.33, v4.9.93, v4.4.127.
v4.16.1: Build OK!
v4.15.16: Failed to apply! Possible dependencies:
3b51cc75eba2 ("lan78xx: remove redundant initialization of pointer 'phydev'")
v4.14.33: Failed to apply! Possible dependencies:
3b51cc75eba2 ("lan78xx: remove redundant initialization of pointer 'phydev'")
v4.9.93: Failed to apply! Possible dependencies:
02dc1f3d613d ("lan78xx: add LAN7801 MAC only support")
3b51cc75eba2 ("lan78xx: remove redundant initialization of pointer 'phydev'")
8c56ea410efb ("net: lan78xx: fix build errors when linux/phy*.h is removed from net/dsa.h")
cc89c323a30e ("lan78xx: Use irq_domain for phy interrupt from USB Int. EP")
v4.4.127: Failed to apply! Possible dependencies:
02dc1f3d613d ("lan78xx: add LAN7801 MAC only support")
3b51cc75eba2 ("lan78xx: remove redundant initialization of pointer 'phydev'")
8c56ea410efb ("net: lan78xx: fix build errors when linux/phy*.h is removed from net/dsa.h")
cc89c323a30e ("lan78xx: Use irq_domain for phy interrupt from USB Int. EP")
--
Thanks,
Sasha
diff --git a/drivers/net/usb/Kconfig b/drivers/net/usb/Kconfig index f28bd74ac275..418b0904cecb 100644 --- a/drivers/net/usb/Kconfig +++ b/drivers/net/usb/Kconfig @@ -111,6 +111,7 @@ config USB_LAN78XX select MII select PHYLIB select MICROCHIP_PHY + select FIXED_PHY help This option adds support for Microchip LAN78XX based USB 2 & USB 3 10/100/1000 Ethernet adapters. diff --git a/drivers/net/usb/lan78xx.c b/drivers/net/usb/lan78xx.c index e3cc3b504c87..e67b2dabde66 100644 --- a/drivers/net/usb/lan78xx.c +++ b/drivers/net/usb/lan78xx.c @@ -36,7 +36,7 @@ #include <linux/irq.h> #include <linux/irqchip/chained_irq.h> #include <linux/microchipphy.h> -#include <linux/phy.h> +#include <linux/phy_fixed.h> #include "lan78xx.h" #define DRIVER_AUTHOR "WOOJUNG HUH <woojung.huh@microchip.com>" @@ -426,6 +426,7 @@ struct lan78xx_net { struct statstage stats; struct irq_domain_data domain_data; + struct phy_device *fixedphy; }; /* define external phy id */ @@ -2058,11 +2059,39 @@ static int lan78xx_phy_init(struct lan78xx_net *dev) int ret; u32 mii_adv; struct phy_device *phydev; + struct fixed_phy_status fphy_status = { + .link = 1, + .speed = SPEED_1000, + .duplex = DUPLEX_FULL, + }; phydev = phy_find_first(dev->mdiobus); if (!phydev) { - netdev_err(dev->net, "no PHY found\n"); - return -EIO; + if (dev->chipid == ID_REV_CHIP_ID_7801_) { + u32 buf; + + netdev_info(dev->net, "PHY Not Found!! Registering Fixed PHY\n"); + phydev = fixed_phy_register(PHY_POLL, &fphy_status, -1, + NULL); + if (IS_ERR(phydev)) { + netdev_err(dev->net, "No PHY/fixed_PHY found\n"); + return -ENODEV; + } + netdev_info(dev->net, "Registered FIXED PHY\n"); + dev->interface = PHY_INTERFACE_MODE_RGMII; + dev->fixedphy = phydev; + ret = lan78xx_write_reg(dev, MAC_RGMII_ID, + MAC_RGMII_ID_TXC_DELAY_EN_); + ret = lan78xx_write_reg(dev, RGMII_TX_BYP_DLL, 0x3D00); + ret = lan78xx_read_reg(dev, HW_CFG, &buf); + buf |= HW_CFG_CLK125_EN_; + buf |= HW_CFG_REFCLK25_EN_; + ret = lan78xx_write_reg(dev, HW_CFG, buf); + goto phyinit; + } else { + netdev_err(dev->net, "no PHY found\n"); + return -EIO; + } } if ((dev->chipid == ID_REV_CHIP_ID_7800_) || @@ -2100,7 +2129,7 @@ static int lan78xx_phy_init(struct lan78xx_net *dev) ret = -EIO; goto error; } - +phyinit: /* if phyirq is not set, use polling mode in phylib */ if (dev->domain_data.phyirq > 0) phydev->irq = dev->domain_data.phyirq; @@ -3559,6 +3588,11 @@ static void lan78xx_disconnect(struct usb_interface *intf) udev = interface_to_usbdev(intf); net = dev->net; + + if (dev->fixedphy) { + fixed_phy_unregister(dev->fixedphy); + dev->fixedphy = NULL; + } unregister_netdev(net); cancel_delayed_work_sync(&dev->wq);
Adding Fixed PHY support to the lan78xx driver. Fixes: 55d7de9de6c3 ("Microchip's LAN7800 family USB 2/3 to 10/100/1000 Ethernet device driver") Signed-off-by: Raghuram Chary J <raghuramchary.jallipalli@microchip.com> --- drivers/net/usb/Kconfig | 1 + drivers/net/usb/lan78xx.c | 42 ++++++++++++++++++++++++++++++++++++++---- 2 files changed, 39 insertions(+), 4 deletions(-)