| Message ID | 20180404080103.28033-4-linux-kernel-dev@beckhoff.com |
|---|---|
| State | Accepted |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | This series adds support for gpio-leds "default-state" property. The | expand |
On 4 April 2018 at 04:01, <linux-kernel-dev@beckhoff.com> wrote: > From: Patrick Bruenn <p.bruenn@beckhoff.com> > > Add two more gpio-leds to sandbox test device tree with default-state > property set to "on"/"off". > Add dm_test_led_default_state() to check that these new LED's are set to > LEDST_ON and LEDST_OFF. > > Signed-off-by: Patrick Bruenn <p.bruenn@beckhoff.com> > --- > patman complains about: test/dm/led.c:45: check: Please use a blank line > after function/struct/union/enum declarations. > I compared with other DM_TEST() usage and decided to ignore this check. > Should we fix the macro, patman or keep ignoring this? Yes you can ignore it. The warning is coming from checkpatch.pl. I suppose we could update that. I think the macro should be next to the function it references, otherwise it gets a bit confusing. > > Changes in v3: None > Changes in v2: None > > arch/sandbox/dts/test.dts | 12 ++++++++++++ > test/dm/led.c | 16 ++++++++++++++++ > 2 files changed, 28 insertions(+) Reviewed-by: Simon Glass <sjg@chromium.org>
On Wed, Apr 04, 2018 at 10:01:03AM +0200, linux-kernel-dev@beckhoff.com wrote: > From: Patrick Bruenn <p.bruenn@beckhoff.com> > > Add two more gpio-leds to sandbox test device tree with default-state > property set to "on"/"off". > Add dm_test_led_default_state() to check that these new LED's are set to > LEDST_ON and LEDST_OFF. > > Signed-off-by: Patrick Bruenn <p.bruenn@beckhoff.com> > Reviewed-by: Simon Glass <sjg@chromium.org> > --- > patman complains about: test/dm/led.c:45: check: Please use a blank line > after function/struct/union/enum declarations. > I compared with other DM_TEST() usage and decided to ignore this check. > Should we fix the macro, patman or keep ignoring this? This breaks tests actually, please try running 'make tests' after this (and the rest of your series) is applied, thanks!
diff --git a/arch/sandbox/dts/test.dts b/arch/sandbox/dts/test.dts index 06d0e8ce85..07f9bad258 100644 --- a/arch/sandbox/dts/test.dts +++ b/arch/sandbox/dts/test.dts @@ -254,6 +254,18 @@ gpios = <&gpio_a 2 0>; label = "sandbox:green"; }; + + default_on { + gpios = <&gpio_a 3 0>; + label = "sandbox:default_on"; + default-state = "on"; + }; + + default_off { + gpios = <&gpio_a 4 0>; + label = "sandbox:default_off"; + default-state = "off"; + }; }; mbox: mbox { diff --git a/test/dm/led.c b/test/dm/led.c index fde700be38..c560abc4fb 100644 --- a/test/dm/led.c +++ b/test/dm/led.c @@ -28,6 +28,22 @@ static int dm_test_led_base(struct unit_test_state *uts) } DM_TEST(dm_test_led_base, DM_TESTF_SCAN_PDATA | DM_TESTF_SCAN_FDT); +/* Test of the LED 'default-state' device tree property */ +static int dm_test_led_default_state(struct unit_test_state *uts) +{ + struct udevice *dev; + + /* Check that we handle the default-state property correctly. */ + ut_assertok(led_get_by_label("sandbox:default_on", &dev)); + ut_asserteq(LEDST_ON, led_get_state(dev)); + + ut_assertok(led_get_by_label("sandbox:default_off", &dev)); + ut_asserteq(LEDST_OFF, led_get_state(dev)); + + return 0; +} +DM_TEST(dm_test_led_default_state, DM_TESTF_SCAN_PDATA | DM_TESTF_SCAN_FDT); + /* Test of the led uclass using the led_gpio driver */ static int dm_test_led_gpio(struct unit_test_state *uts) {