mbox series

[net-next,V2,0/4] Introduce adaptive TX interrupt moderation to net DIM

Message ID 1522677574-7506-1-git-send-email-talgi@mellanox.com
Headers show
Series Introduce adaptive TX interrupt moderation to net DIM | expand

Message

Tal Gilboa April 2, 2018, 1:59 p.m. UTC 
Net DIM is a library designed for dynamic interrupt moderation. It was
implemented and optimized with receive side interrupts in mind, since these
are usually the CPU expensive ones. This patch-set introduces adaptive transmit
interrupt moderation to net DIM, complete with a usage in the mlx5e driver.
Using adaptive TX behavior would reduce interrupt rate for multiple scenarios.
Furthermore, it is essential for increasing bandwidth on cases where payload
aggregation is required.

v2: Rebased over proper tree.

v1: Fix compilation issues due to missed function renaming.

Tal Gilboa (4):
  net/dim: Rename *_get_profile() functions to *_get_rx_moderation()
  net/dim: Add "enabled" field to net_dim struct
  net/dim: Support adaptive TX moderation
  net/mlx5e: Enable adaptive-TX moderation

 drivers/net/ethernet/broadcom/bcmsysport.c         |  6 +-
 drivers/net/ethernet/broadcom/bnxt/bnxt_dim.c      |  8 +--
 drivers/net/ethernet/broadcom/genet/bcmgenet.c     |  6 +-
 drivers/net/ethernet/mellanox/mlx5/core/en.h       |  5 +-
 drivers/net/ethernet/mellanox/mlx5/core/en_dim.c   | 28 ++++++---
 .../net/ethernet/mellanox/mlx5/core/en_ethtool.c   | 35 +++++++----
 drivers/net/ethernet/mellanox/mlx5/core/en_main.c  | 34 ++++++++--
 drivers/net/ethernet/mellanox/mlx5/core/en_rep.c   |  2 +-
 drivers/net/ethernet/mellanox/mlx5/core/en_txrx.c  | 37 ++++++++---
 include/linux/net_dim.h                            | 72 +++++++++++++++++-----
 10 files changed, 173 insertions(+), 60 deletions(-)

Comments

David Miller April 2, 2018, 2:27 p.m. UTC | #1 
From: Tal Gilboa <talgi@mellanox.com>
Date: Mon,  2 Apr 2018 16:59:30 +0300

> Net DIM is a library designed for dynamic interrupt moderation. It was
> implemented and optimized with receive side interrupts in mind, since these
> are usually the CPU expensive ones. This patch-set introduces adaptive transmit
> interrupt moderation to net DIM, complete with a usage in the mlx5e driver.
> Using adaptive TX behavior would reduce interrupt rate for multiple scenarios.
> Furthermore, it is essential for increasing bandwidth on cases where payload
> aggregation is required.
> 
> v2: Rebased over proper tree.
> 
> v1: Fix compilation issues due to missed function renaming.

This series still needs fixes, and the net-next tree has closed meanwhile.

And to be honest, handling this series has been very painful for me so far.
The patches either didn't apply or didn't even compile.

Please do not resubmit this until the merge window is over and the net-next
tree opens up again.

Thank you.
Tal Gilboa April 2, 2018, 2:42 p.m. UTC | #2 
On 4/2/2018 5:27 PM, David Miller wrote:
> From: Tal Gilboa <talgi@mellanox.com>
> Date: Mon,  2 Apr 2018 16:59:30 +0300
> 
>> Net DIM is a library designed for dynamic interrupt moderation. It was
>> implemented and optimized with receive side interrupts in mind, since these
>> are usually the CPU expensive ones. This patch-set introduces adaptive transmit
>> interrupt moderation to net DIM, complete with a usage in the mlx5e driver.
>> Using adaptive TX behavior would reduce interrupt rate for multiple scenarios.
>> Furthermore, it is essential for increasing bandwidth on cases where payload
>> aggregation is required.
>>
>> v2: Rebased over proper tree.
>>
>> v1: Fix compilation issues due to missed function renaming.
> 
> This series still needs fixes, and the net-next tree has closed meanwhile.
> 
> And to be honest, handling this series has been very painful for me so far.
> The patches either didn't apply or didn't even compile.
> 
> Please do not resubmit this until the merge window is over and the net-next
> tree opens up again.
> 
> Thank you.
> 
Ack.