| Message ID | 1bc09dfd205d0721366267e023550c4a5a4a84db.1522235224.git.gustavo.pimentel@synopsys.com |
|---|---|
| State | Superseded |
| Delegated to: | Lorenzo Pieralisi |
| Headers | show |
| Series | Designware EP support and code clenan up | expand |
Hi, On Wednesday 28 March 2018 05:08 PM, Gustavo Pimentel wrote: > Adds the designware EP device ID entry to pci_endpoint_test driver table > to allow this device to be recognize and handle by the pci_endpoint_test > driver. > > Signed-off-by: Gustavo Pimentel <gustavo.pimentel@synopsys.com> > --- > drivers/misc/pci_endpoint_test.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/misc/pci_endpoint_test.c b/drivers/misc/pci_endpoint_test.c > index 320276f..e80c533 100644 > --- a/drivers/misc/pci_endpoint_test.c > +++ b/drivers/misc/pci_endpoint_test.c > @@ -632,6 +632,7 @@ static void pci_endpoint_test_remove(struct pci_dev *pdev) > static const struct pci_device_id pci_endpoint_test_tbl[] = { > { PCI_DEVICE(PCI_VENDOR_ID_TI, PCI_DEVICE_ID_TI_DRA74x) }, > { PCI_DEVICE(PCI_VENDOR_ID_TI, PCI_DEVICE_ID_TI_DRA72x) }, > + { PCI_DEVICE(PCI_VENDOR_ID_SYNOPSYS, 0xedda) }, Add device ids to include/linux/pci_ids.h and use the macro here. Thanks Kishon
Hi Kishon, On 02/04/2018 06:36, Kishon Vijay Abraham I wrote: > Hi, > > On Wednesday 28 March 2018 05:08 PM, Gustavo Pimentel wrote: >> Adds the designware EP device ID entry to pci_endpoint_test driver table >> to allow this device to be recognize and handle by the pci_endpoint_test >> driver. >> >> Signed-off-by: Gustavo Pimentel <gustavo.pimentel@synopsys.com> >> --- >> drivers/misc/pci_endpoint_test.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/misc/pci_endpoint_test.c b/drivers/misc/pci_endpoint_test.c >> index 320276f..e80c533 100644 >> --- a/drivers/misc/pci_endpoint_test.c >> +++ b/drivers/misc/pci_endpoint_test.c >> @@ -632,6 +632,7 @@ static void pci_endpoint_test_remove(struct pci_dev *pdev) >> static const struct pci_device_id pci_endpoint_test_tbl[] = { >> { PCI_DEVICE(PCI_VENDOR_ID_TI, PCI_DEVICE_ID_TI_DRA74x) }, >> { PCI_DEVICE(PCI_VENDOR_ID_TI, PCI_DEVICE_ID_TI_DRA72x) }, >> + { PCI_DEVICE(PCI_VENDOR_ID_SYNOPSYS, 0xedda) }, > > Add device ids to include/linux/pci_ids.h and use the macro here. Add device id request sent, as soon as I get a positive confirmation from them I'll change for the macro. It works for you? > > Thanks > Kishon > Regards, Gustavo
Hi, On Tuesday 03 April 2018 03:41 PM, Gustavo Pimentel wrote: > Hi Kishon, > > On 02/04/2018 06:36, Kishon Vijay Abraham I wrote: >> Hi, >> >> On Wednesday 28 March 2018 05:08 PM, Gustavo Pimentel wrote: >>> Adds the designware EP device ID entry to pci_endpoint_test driver table >>> to allow this device to be recognize and handle by the pci_endpoint_test >>> driver. >>> >>> Signed-off-by: Gustavo Pimentel <gustavo.pimentel@synopsys.com> >>> --- >>> drivers/misc/pci_endpoint_test.c | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/drivers/misc/pci_endpoint_test.c b/drivers/misc/pci_endpoint_test.c >>> index 320276f..e80c533 100644 >>> --- a/drivers/misc/pci_endpoint_test.c >>> +++ b/drivers/misc/pci_endpoint_test.c >>> @@ -632,6 +632,7 @@ static void pci_endpoint_test_remove(struct pci_dev *pdev) >>> static const struct pci_device_id pci_endpoint_test_tbl[] = { >>> { PCI_DEVICE(PCI_VENDOR_ID_TI, PCI_DEVICE_ID_TI_DRA74x) }, >>> { PCI_DEVICE(PCI_VENDOR_ID_TI, PCI_DEVICE_ID_TI_DRA72x) }, >>> + { PCI_DEVICE(PCI_VENDOR_ID_SYNOPSYS, 0xedda) }, >> >> Add device ids to include/linux/pci_ids.h and use the macro here. > > Add device id request sent, as soon as I get a positive confirmation from them > I'll change for the macro. It works for you? IMO only confirmed device ID's should be used. Thanks Kishon
diff --git a/drivers/misc/pci_endpoint_test.c b/drivers/misc/pci_endpoint_test.c index 320276f..e80c533 100644 --- a/drivers/misc/pci_endpoint_test.c +++ b/drivers/misc/pci_endpoint_test.c @@ -632,6 +632,7 @@ static void pci_endpoint_test_remove(struct pci_dev *pdev) static const struct pci_device_id pci_endpoint_test_tbl[] = { { PCI_DEVICE(PCI_VENDOR_ID_TI, PCI_DEVICE_ID_TI_DRA74x) }, { PCI_DEVICE(PCI_VENDOR_ID_TI, PCI_DEVICE_ID_TI_DRA72x) }, + { PCI_DEVICE(PCI_VENDOR_ID_SYNOPSYS, 0xedda) }, { } }; MODULE_DEVICE_TABLE(pci, pci_endpoint_test_tbl);
Adds the designware EP device ID entry to pci_endpoint_test driver table to allow this device to be recognize and handle by the pci_endpoint_test driver. Signed-off-by: Gustavo Pimentel <gustavo.pimentel@synopsys.com> --- drivers/misc/pci_endpoint_test.c | 1 + 1 file changed, 1 insertion(+)