| Message ID | 20180315125602.26186-1-casantos@datacom.ind.br |
|---|---|
| State | Accepted |
| Commit | 03a82765b1238bc57ce39f164c2de8c471b91f33 |
| Headers | show |
| Series | [1/5] tmp2-tss: remove architecture restriction | expand |
>>>>> "Carlos" == Carlos Santos <casantos@datacom.ind.br> writes: > Followingig a suggestion from Peter Korsgaard, remove the restriction to > x86 and x86_64. It is preferable to expose the package unless there is a > build time dependency on an architecture or the package is specific to a > certain SoC or board. > Signed-off-by: Carlos Santos <casantos@datacom.ind.br> Committed, thanks.
>>>>> "Carlos" == Carlos Santos <casantos@datacom.ind.br> writes: > Improved compliance to the last public review spec and some bug fixes. > Signed-off-by: Carlos Santos <casantos@datacom.ind.br> Committed, thanks.
>>>>> "Carlos" == Carlos Santos <casantos@datacom.ind.br> writes: > This is a system daemon implementing the TPM2 access broker (TAB) & > Resource Manager (RM) spec from the TCG. The daemon (tpm2-abrmd) is > implemented using Glib and the GObject system. > Communication between the daemon and clients using the TPM is done with > a combination of DBus and Unix pipes. DBus is used for discovery, > session management and the 'cancel', 'setLocality', and 'getPollHandles' > API calls (mostly these aren't yet implemented). Pipes are used to send > and receive TPM commands and responses (respectively) between client and > server. > The daemon owns the com.intel.tss2.Tabrmd name on dbus. It can be > configured to connect to either the system or the session bus. > The package also provides a client library for interacting with the > daemon via TPM Command Transmission Interface (TCTI). It is intended for > use with the SAPI library (libsapi) like any other TCTI. > Signed-off-by: Carlos Santos <casantos@datacom.ind.br> > --- > package/Config.in | 1 + > package/tpm2-abrmd/Config.in | 25 +++++++++++ > package/tpm2-abrmd/S30devtpmperms | 37 ++++++++++++++++ > package/tpm2-abrmd/S80tpm2-abrmd | 74 +++++++++++++++++++++++++++++++ > package/tpm2-abrmd/etc.default.tpm2-abrmd | 1 + I think this is a bit too complicated / wordy. When there are sensible defaults we add those to the init script and just allow an /etc/default/<pkg> to override it for special setups, so I've dropped the etc.default.tpm2-abrmd. The same for S30devtpmperms - I have simply added: chown tss:tss /dev/tpm[0-9]* && chmod 600 /dev/tpm* To check_device() in S80tpm2-abrmd and dropped S30devtpmperms. Committed with these changes, thanks.
>>>>> "Carlos" == Carlos Santos <casantos@datacom.ind.br> writes: > Signed-off-by: Carlos Santos <casantos@datacom.ind.br> Committed, thanks.
>>>>> "Peter" == Peter Korsgaard <peter@korsgaard.com> writes: >>>>> "Carlos" == Carlos Santos <casantos@datacom.ind.br> writes: >> Improved compliance to the last public review spec and some bug fixes. >> Signed-off-by: Carlos Santos <casantos@datacom.ind.br> > Committed, thanks. It looks like this now contains some C++ code. Care to send a patch fixing the dependencies? http://autobuild.buildroot.net/results/799/79963f81da0a250b04b105c2a73c0221e89c4c17/build-end.log
> From: "Peter Korsgaard" <peter@korsgaard.com> > To: "Carlos Santos" <casantos@datacom.ind.br> > Cc: "buildroot" <buildroot@buildroot.org> > Sent: Tuesday, March 20, 2018 3:23:27 AM > Subject: Re: [PATCH 2/5] tmp2-tss: bump to version 1.4.0 >>>>>> "Peter" == Peter Korsgaard <peter@korsgaard.com> writes: > >>>>>> "Carlos" == Carlos Santos <casantos@datacom.ind.br> writes: > >> Improved compliance to the last public review spec and some bug fixes. > >> Signed-off-by: Carlos Santos <casantos@datacom.ind.br> > > > Committed, thanks. > > It looks like this now contains some C++ code. Care to send a patch > fixing the dependencies? > > http://autobuild.buildroot.net/results/799/79963f81da0a250b04b105c2a73c0221e89c4c17/build-end.log Working on this now that I'm back from vacations an traveling.
>>>>> "Carlos" == Carlos Santos <casantos@datacom.ind.br> writes: Hi, >> > Committed, thanks. >> >> It looks like this now contains some C++ code. Care to send a patch >> fixing the dependencies? >> >> http://autobuild.buildroot.net/results/799/79963f81da0a250b04b105c2a73c0221e89c4c17/build-end.log > Working on this now that I'm back from vacations an traveling. Thanks!
diff --git a/package/tpm2-tss/Config.in b/package/tpm2-tss/Config.in index 1eb69d3e93..ebf0fd262d 100644 --- a/package/tpm2-tss/Config.in +++ b/package/tpm2-tss/Config.in @@ -1,6 +1,5 @@ config BR2_PACKAGE_TPM2_TSS bool "tpm2-tss" - depends on BR2_i386 || BR2_x86_64 select BR2_PACKAGE_LIBURIPARSER help OSS implementation of the Trusted Computing Group's (TCG) TPM2
Followingig a suggestion from Peter Korsgaard, remove the restriction to x86 and x86_64. It is preferable to expose the package unless there is a build time dependency on an architecture or the package is specific to a certain SoC or board. Signed-off-by: Carlos Santos <casantos@datacom.ind.br> --- package/tpm2-tss/Config.in | 1 - 1 file changed, 1 deletion(-)