Message ID | 20180312171001.129209-3-brad.mouring@ni.com |
---|---|
State | Changes Requested, archived |
Delegated to: | David Miller |
Headers | show |
Series | macb: Introduce phy-handle DT functionality | expand |
On 03/12/2018 10:09 AM, Brad Mouring wrote: > In phy_device's general probe, this device will already be set for > phy register polling, rendering this code redundant. > > Signed-off-by: Brad Mouring <brad.mouring@ni.com> > Suggested-by: Andrew Lunn <andrew@lunn.ch> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c index 9b6195fbbf8e..db1dc301bed3 100644 --- a/drivers/net/ethernet/cadence/macb_main.c +++ b/drivers/net/ethernet/cadence/macb_main.c @@ -593,9 +593,6 @@ static int macb_mii_init(struct macb *bp) if (np) { err = of_mdiobus_register(bp->mii_bus, np); } else { - for (i = 0; i < PHY_MAX_ADDR; i++) - bp->mii_bus->irq[i] = PHY_POLL; - if (pdata) bp->mii_bus->phy_mask = pdata->phy_mask;
In phy_device's general probe, this device will already be set for phy register polling, rendering this code redundant. Signed-off-by: Brad Mouring <brad.mouring@ni.com> Suggested-by: Andrew Lunn <andrew@lunn.ch> --- drivers/net/ethernet/cadence/macb_main.c | 3 --- 1 file changed, 3 deletions(-)