diff mbox series

net: dsa: mv88e6xxx: fix boolreturn.cocci warnings

Message ID 20180306155407.GA67333@lkp-g5
State Accepted, archived
Delegated to: David Miller
Headers show
Series net: dsa: mv88e6xxx: fix boolreturn.cocci warnings | expand

Commit Message

kbuild test robot March 6, 2018, 3:54 p.m. UTC 
From: Fengguang Wu <fengguang.wu@intel.com>

drivers/net/dsa/mv88e6xxx/serdes.c:66:9-10: WARNING: return of 0/1 in function 'mv88e6352_port_has_serdes' with return type bool

 Return statements in functions returning bool should use
 true/false instead of 1/0.
Generated by: scripts/coccinelle/misc/boolreturn.cocci

Fixes: eb755c3f6b7d ("net: dsa: mv88e6xxx: Add helper to determining if port has SERDES")
CC: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---

 serdes.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Andrew Lunn March 6, 2018, 4:02 p.m. UTC | #1 
On Tue, Mar 06, 2018 at 11:54:07PM +0800, kbuild test robot wrote:
> From: Fengguang Wu <fengguang.wu@intel.com>
> 
> drivers/net/dsa/mv88e6xxx/serdes.c:66:9-10: WARNING: return of 0/1 in function 'mv88e6352_port_has_serdes' with return type bool
> 
>  Return statements in functions returning bool should use
>  true/false instead of 1/0.
> Generated by: scripts/coccinelle/misc/boolreturn.cocci
> 
> Fixes: eb755c3f6b7d ("net: dsa: mv88e6xxx: Add helper to determining if port has SERDES")
> CC: Andrew Lunn <andrew@lunn.ch>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew
David Miller March 7, 2018, 6:37 p.m. UTC | #2 
From: kbuild test robot <fengguang.wu@intel.com>
Date: Tue, 6 Mar 2018 23:54:07 +0800

> From: Fengguang Wu <fengguang.wu@intel.com>
> 
> drivers/net/dsa/mv88e6xxx/serdes.c:66:9-10: WARNING: return of 0/1 in function 'mv88e6352_port_has_serdes' with return type bool
> 
>  Return statements in functions returning bool should use
>  true/false instead of 1/0.
> Generated by: scripts/coccinelle/misc/boolreturn.cocci
> 
> Fixes: eb755c3f6b7d ("net: dsa: mv88e6xxx: Add helper to determining if port has SERDES")
> CC: Andrew Lunn <andrew@lunn.ch>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>

Applied to net-next.
diff mbox series

Patch

--- a/drivers/net/dsa/mv88e6xxx/serdes.c
+++ b/drivers/net/dsa/mv88e6xxx/serdes.c
@@ -63,15 +63,15 @@  static bool mv88e6352_port_has_serdes(st
 	err = mv88e6xxx_port_get_cmode(chip, port, &cmode);
 	if (err) {
 		dev_err(chip->dev, "failed to read cmode\n");
-		return 0;
+		return false;
 	}
 
 	if ((cmode == MV88E6XXX_PORT_STS_CMODE_100BASE_X) ||
 	    (cmode == MV88E6XXX_PORT_STS_CMODE_1000BASE_X) ||
 	    (cmode == MV88E6XXX_PORT_STS_CMODE_SGMII))
-		return 1;
+		return true;
 
-	return 0;
+	return false;
 }
 
 int mv88e6352_serdes_power(struct mv88e6xxx_chip *chip, int port, bool on)