| Message ID | 1519903917-11575-1-git-send-email-arvind.yadav.cs@gmail.com |
|---|---|
| State | Awaiting Upstream, archived |
| Delegated to: | David Miller |
| Headers | show |
| Series | [v3] net: iucv: Free memory obtained by kzalloc | expand |
On Thu, 1 Mar 2018 17:01:57 +0530 Arvind Yadav <arvind.yadav.cs@gmail.com> wrote: > Free memory by calling put_device(), if afiucv_iucv_init is not > successful. > > Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> > --- > changes in v2: > Calling put_device() before kfree(). > changes in v3: > No need to call kfree(). So removed kfree(). > > net/iucv/af_iucv.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/net/iucv/af_iucv.c b/net/iucv/af_iucv.c > index 1e8cc7b..9e2643a 100644 > --- a/net/iucv/af_iucv.c > +++ b/net/iucv/af_iucv.c > @@ -2433,9 +2433,11 @@ static int afiucv_iucv_init(void) > af_iucv_dev->driver = &af_iucv_driver; > err = device_register(af_iucv_dev); > if (err) > - goto out_driver; > + goto out_iucv_dev; > return 0; > > +out_iucv_dev: > + put_device(af_iucv_dev); > out_driver: > driver_unregister(&af_iucv_driver); > out_iucv: Reviewed-by: Cornelia Huck <cohuck@redhat.com>
On 03/01/2018 12:31 PM, Arvind Yadav wrote: > Free memory by calling put_device(), if afiucv_iucv_init is not > successful. > > Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> > --- > changes in v2: > Calling put_device() before kfree(). > changes in v3: > No need to call kfree(). So removed kfree(). > > net/iucv/af_iucv.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/net/iucv/af_iucv.c b/net/iucv/af_iucv.c > index 1e8cc7b..9e2643a 100644 > --- a/net/iucv/af_iucv.c > +++ b/net/iucv/af_iucv.c > @@ -2433,9 +2433,11 @@ static int afiucv_iucv_init(void) > af_iucv_dev->driver = &af_iucv_driver; > err = device_register(af_iucv_dev); > if (err) > - goto out_driver; > + goto out_iucv_dev; > return 0; > > +out_iucv_dev: > + put_device(af_iucv_dev); > out_driver: > driver_unregister(&af_iucv_driver); > out_iucv: > Thanks Arvind, I have added this patch version to our local repository; it will be part of a coming patch submission to Dave Miller. Regards, Ursula
diff --git a/net/iucv/af_iucv.c b/net/iucv/af_iucv.c index 1e8cc7b..9e2643a 100644 --- a/net/iucv/af_iucv.c +++ b/net/iucv/af_iucv.c @@ -2433,9 +2433,11 @@ static int afiucv_iucv_init(void) af_iucv_dev->driver = &af_iucv_driver; err = device_register(af_iucv_dev); if (err) - goto out_driver; + goto out_iucv_dev; return 0; +out_iucv_dev: + put_device(af_iucv_dev); out_driver: driver_unregister(&af_iucv_driver); out_iucv:
Free memory by calling put_device(), if afiucv_iucv_init is not successful. Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> --- changes in v2: Calling put_device() before kfree(). changes in v3: No need to call kfree(). So removed kfree(). net/iucv/af_iucv.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)