| Message ID | 1519198784-3975-1-git-send-email-chin.liang.see@intel.com |
|---|---|
| State | Deferred |
| Delegated to: | Marek Vasut |
| Headers | show |
| Series | [U-Boot,1/2] arm: socfpga: cyclone5: Enable Macronix flash support | expand |
On 02/21/2018 08:39 AM, chin.liang.see@intel.com wrote: > From: Chin Liang See <chin.liang.see@intel.com> > > Enable Macronix flash support for Cyclone5 SoC Do these boards actually have a macronix flash ? Most of the ones I know of do not. > Signed-off-by: Chin Liang See <chin.liang.see@intel.com> > --- > configs/socfpga_cyclone5_defconfig | 1 + > configs/socfpga_is1_defconfig | 1 + > configs/socfpga_sockit_defconfig | 1 + > configs/socfpga_socrates_defconfig | 1 + > configs/socfpga_sr1500_defconfig | 1 + > configs/socfpga_vining_fpga_defconfig | 1 + > 6 files changed, 6 insertions(+) > > diff --git a/configs/socfpga_cyclone5_defconfig b/configs/socfpga_cyclone5_defconfig > index 6ebd8a9..aa535c6 100644 > --- a/configs/socfpga_cyclone5_defconfig > +++ b/configs/socfpga_cyclone5_defconfig > @@ -53,6 +53,7 @@ CONFIG_DM_MMC=y > CONFIG_MMC_DW=y > CONFIG_SPI_FLASH=y > CONFIG_SPI_FLASH_BAR=y > +CONFIG_SPI_FLASH_MACRONIX=y > CONFIG_SPI_FLASH_SPANSION=y > CONFIG_SPI_FLASH_STMICRO=y > # CONFIG_SPI_FLASH_USE_4K_SECTORS is not set > diff --git a/configs/socfpga_is1_defconfig b/configs/socfpga_is1_defconfig > index 08628ab..7be720a 100644 > --- a/configs/socfpga_is1_defconfig > +++ b/configs/socfpga_is1_defconfig > @@ -48,6 +48,7 @@ CONFIG_SYS_I2C_DW=y > # CONFIG_MMC is not set > CONFIG_SPI_FLASH=y > CONFIG_SPI_FLASH_BAR=y > +CONFIG_SPI_FLASH_MACRONIX=y > CONFIG_SPI_FLASH_STMICRO=y > CONFIG_PHY_MICREL=y > CONFIG_PHY_MICREL_KSZ90X1=y > diff --git a/configs/socfpga_sockit_defconfig b/configs/socfpga_sockit_defconfig > index 8ebe394..6edb47f 100644 > --- a/configs/socfpga_sockit_defconfig > +++ b/configs/socfpga_sockit_defconfig > @@ -53,6 +53,7 @@ CONFIG_DM_MMC=y > CONFIG_MMC_DW=y > CONFIG_SPI_FLASH=y > CONFIG_SPI_FLASH_BAR=y > +CONFIG_SPI_FLASH_MACRONIX=y > CONFIG_SPI_FLASH_SPANSION=y > CONFIG_SPI_FLASH_STMICRO=y > # CONFIG_SPI_FLASH_USE_4K_SECTORS is not set > diff --git a/configs/socfpga_socrates_defconfig b/configs/socfpga_socrates_defconfig > index 9f42481..7c2428a 100644 > --- a/configs/socfpga_socrates_defconfig > +++ b/configs/socfpga_socrates_defconfig > @@ -54,6 +54,7 @@ CONFIG_DM_MMC=y > CONFIG_MMC_DW=y > CONFIG_SPI_FLASH=y > CONFIG_SPI_FLASH_BAR=y > +CONFIG_SPI_FLASH_MACRONIX=y > CONFIG_SPI_FLASH_SPANSION=y > CONFIG_SPI_FLASH_STMICRO=y > CONFIG_PHY_MICREL=y > diff --git a/configs/socfpga_sr1500_defconfig b/configs/socfpga_sr1500_defconfig > index f9ed1a3..df1ee31 100644 > --- a/configs/socfpga_sr1500_defconfig > +++ b/configs/socfpga_sr1500_defconfig > @@ -53,6 +53,7 @@ CONFIG_DM_MMC=y > CONFIG_MMC_DW=y > CONFIG_SPI_FLASH=y > CONFIG_SPI_FLASH_BAR=y > +CONFIG_SPI_FLASH_MACRONIX=y > CONFIG_SPI_FLASH_STMICRO=y > # CONFIG_SPI_FLASH_USE_4K_SECTORS is not set > CONFIG_DM_ETH=y > diff --git a/configs/socfpga_vining_fpga_defconfig b/configs/socfpga_vining_fpga_defconfig > index 6670b9f..512d701 100644 > --- a/configs/socfpga_vining_fpga_defconfig > +++ b/configs/socfpga_vining_fpga_defconfig > @@ -69,6 +69,7 @@ CONFIG_LED_STATUS_CMD=y > CONFIG_DM_MMC=y > CONFIG_MMC_DW=y > CONFIG_SPI_FLASH=y > +CONFIG_SPI_FLASH_MACRONIX=y > CONFIG_SPI_FLASH_SPANSION=y > CONFIG_SPI_FLASH_STMICRO=y > # CONFIG_SPI_FLASH_USE_4K_SECTORS is not set >
On Wed, 2018-02-21 at 20:23 +0100, Marek Vasut wrote: > On 02/21/2018 08:39 AM, chin.liang.see@intel.com wrote: > > > > From: Chin Liang See <chin.liang.see@intel.com> > > > > Enable Macronix flash support for Cyclone5 SoC > Do these boards actually have a macronix flash ? Most of the ones I > know > of do not. Good question. Actually they are pin compatible and customer can replace the existing one. FYI, there seems a NOR flash shortage worldwide which lead to requests by customer to change the BOM list. Thanks Chin Liang > > > > > Signed-off-by: Chin Liang See <chin.liang.see@intel.com> > > --- > > configs/socfpga_cyclone5_defconfig | 1 + > > configs/socfpga_is1_defconfig | 1 + > > configs/socfpga_sockit_defconfig | 1 + > > configs/socfpga_socrates_defconfig | 1 + > > configs/socfpga_sr1500_defconfig | 1 + > > configs/socfpga_vining_fpga_defconfig | 1 + > > 6 files changed, 6 insertions(+) > > > > diff --git a/configs/socfpga_cyclone5_defconfig > > b/configs/socfpga_cyclone5_defconfig > > index 6ebd8a9..aa535c6 100644 > > --- a/configs/socfpga_cyclone5_defconfig > > +++ b/configs/socfpga_cyclone5_defconfig > > @@ -53,6 +53,7 @@ CONFIG_DM_MMC=y > > CONFIG_MMC_DW=y > > CONFIG_SPI_FLASH=y > > CONFIG_SPI_FLASH_BAR=y > > +CONFIG_SPI_FLASH_MACRONIX=y > > CONFIG_SPI_FLASH_SPANSION=y > > CONFIG_SPI_FLASH_STMICRO=y > > # CONFIG_SPI_FLASH_USE_4K_SECTORS is not set > > diff --git a/configs/socfpga_is1_defconfig > > b/configs/socfpga_is1_defconfig > > index 08628ab..7be720a 100644 > > --- a/configs/socfpga_is1_defconfig > > +++ b/configs/socfpga_is1_defconfig > > @@ -48,6 +48,7 @@ CONFIG_SYS_I2C_DW=y > > # CONFIG_MMC is not set > > CONFIG_SPI_FLASH=y > > CONFIG_SPI_FLASH_BAR=y > > +CONFIG_SPI_FLASH_MACRONIX=y > > CONFIG_SPI_FLASH_STMICRO=y > > CONFIG_PHY_MICREL=y > > CONFIG_PHY_MICREL_KSZ90X1=y > > diff --git a/configs/socfpga_sockit_defconfig > > b/configs/socfpga_sockit_defconfig > > index 8ebe394..6edb47f 100644 > > --- a/configs/socfpga_sockit_defconfig > > +++ b/configs/socfpga_sockit_defconfig > > @@ -53,6 +53,7 @@ CONFIG_DM_MMC=y > > CONFIG_MMC_DW=y > > CONFIG_SPI_FLASH=y > > CONFIG_SPI_FLASH_BAR=y > > +CONFIG_SPI_FLASH_MACRONIX=y > > CONFIG_SPI_FLASH_SPANSION=y > > CONFIG_SPI_FLASH_STMICRO=y > > # CONFIG_SPI_FLASH_USE_4K_SECTORS is not set > > diff --git a/configs/socfpga_socrates_defconfig > > b/configs/socfpga_socrates_defconfig > > index 9f42481..7c2428a 100644 > > --- a/configs/socfpga_socrates_defconfig > > +++ b/configs/socfpga_socrates_defconfig > > @@ -54,6 +54,7 @@ CONFIG_DM_MMC=y > > CONFIG_MMC_DW=y > > CONFIG_SPI_FLASH=y > > CONFIG_SPI_FLASH_BAR=y > > +CONFIG_SPI_FLASH_MACRONIX=y > > CONFIG_SPI_FLASH_SPANSION=y > > CONFIG_SPI_FLASH_STMICRO=y > > CONFIG_PHY_MICREL=y > > diff --git a/configs/socfpga_sr1500_defconfig > > b/configs/socfpga_sr1500_defconfig > > index f9ed1a3..df1ee31 100644 > > --- a/configs/socfpga_sr1500_defconfig > > +++ b/configs/socfpga_sr1500_defconfig > > @@ -53,6 +53,7 @@ CONFIG_DM_MMC=y > > CONFIG_MMC_DW=y > > CONFIG_SPI_FLASH=y > > CONFIG_SPI_FLASH_BAR=y > > +CONFIG_SPI_FLASH_MACRONIX=y > > CONFIG_SPI_FLASH_STMICRO=y > > # CONFIG_SPI_FLASH_USE_4K_SECTORS is not set > > CONFIG_DM_ETH=y > > diff --git a/configs/socfpga_vining_fpga_defconfig > > b/configs/socfpga_vining_fpga_defconfig > > index 6670b9f..512d701 100644 > > --- a/configs/socfpga_vining_fpga_defconfig > > +++ b/configs/socfpga_vining_fpga_defconfig > > @@ -69,6 +69,7 @@ CONFIG_LED_STATUS_CMD=y > > CONFIG_DM_MMC=y > > CONFIG_MMC_DW=y > > CONFIG_SPI_FLASH=y > > +CONFIG_SPI_FLASH_MACRONIX=y > > CONFIG_SPI_FLASH_SPANSION=y > > CONFIG_SPI_FLASH_STMICRO=y > > # CONFIG_SPI_FLASH_USE_4K_SECTORS is not set > > >
On 22.02.2018 07:29, See, Chin Liang wrote: > On Wed, 2018-02-21 at 20:23 +0100, Marek Vasut wrote: >> On 02/21/2018 08:39 AM, chin.liang.see@intel.com wrote: >>> From: Chin Liang See <chin.liang.see@intel.com> >>> >>> Enable Macronix flash support for Cyclone5 SoC >> Do these boards actually have a macronix flash ? Most of the ones I >> know >> of do not. > Good question. > > Actually they are pin compatible and customer can replace the existing > one. FYI, there seems a NOR flash shortage worldwide which lead to > requests by customer to change the BOM list. But at least the Socrates seems to be out of production. I don't see why we would have to change the defconfig here. Simon > > Thanks > Chin Liang > >>> Signed-off-by: Chin Liang See <chin.liang.see@intel.com> >>> --- >>> configs/socfpga_cyclone5_defconfig | 1 + >>> configs/socfpga_is1_defconfig | 1 + >>> configs/socfpga_sockit_defconfig | 1 + >>> configs/socfpga_socrates_defconfig | 1 + >>> configs/socfpga_sr1500_defconfig | 1 + >>> configs/socfpga_vining_fpga_defconfig | 1 + >>> 6 files changed, 6 insertions(+) >>> >>> diff --git a/configs/socfpga_cyclone5_defconfig >>> b/configs/socfpga_cyclone5_defconfig >>> index 6ebd8a9..aa535c6 100644 >>> --- a/configs/socfpga_cyclone5_defconfig >>> +++ b/configs/socfpga_cyclone5_defconfig >>> @@ -53,6 +53,7 @@ CONFIG_DM_MMC=y >>> CONFIG_MMC_DW=y >>> CONFIG_SPI_FLASH=y >>> CONFIG_SPI_FLASH_BAR=y >>> +CONFIG_SPI_FLASH_MACRONIX=y >>> CONFIG_SPI_FLASH_SPANSION=y >>> CONFIG_SPI_FLASH_STMICRO=y >>> # CONFIG_SPI_FLASH_USE_4K_SECTORS is not set >>> diff --git a/configs/socfpga_is1_defconfig >>> b/configs/socfpga_is1_defconfig >>> index 08628ab..7be720a 100644 >>> --- a/configs/socfpga_is1_defconfig >>> +++ b/configs/socfpga_is1_defconfig >>> @@ -48,6 +48,7 @@ CONFIG_SYS_I2C_DW=y >>> # CONFIG_MMC is not set >>> CONFIG_SPI_FLASH=y >>> CONFIG_SPI_FLASH_BAR=y >>> +CONFIG_SPI_FLASH_MACRONIX=y >>> CONFIG_SPI_FLASH_STMICRO=y >>> CONFIG_PHY_MICREL=y >>> CONFIG_PHY_MICREL_KSZ90X1=y >>> diff --git a/configs/socfpga_sockit_defconfig >>> b/configs/socfpga_sockit_defconfig >>> index 8ebe394..6edb47f 100644 >>> --- a/configs/socfpga_sockit_defconfig >>> +++ b/configs/socfpga_sockit_defconfig >>> @@ -53,6 +53,7 @@ CONFIG_DM_MMC=y >>> CONFIG_MMC_DW=y >>> CONFIG_SPI_FLASH=y >>> CONFIG_SPI_FLASH_BAR=y >>> +CONFIG_SPI_FLASH_MACRONIX=y >>> CONFIG_SPI_FLASH_SPANSION=y >>> CONFIG_SPI_FLASH_STMICRO=y >>> # CONFIG_SPI_FLASH_USE_4K_SECTORS is not set >>> diff --git a/configs/socfpga_socrates_defconfig >>> b/configs/socfpga_socrates_defconfig >>> index 9f42481..7c2428a 100644 >>> --- a/configs/socfpga_socrates_defconfig >>> +++ b/configs/socfpga_socrates_defconfig >>> @@ -54,6 +54,7 @@ CONFIG_DM_MMC=y >>> CONFIG_MMC_DW=y >>> CONFIG_SPI_FLASH=y >>> CONFIG_SPI_FLASH_BAR=y >>> +CONFIG_SPI_FLASH_MACRONIX=y >>> CONFIG_SPI_FLASH_SPANSION=y >>> CONFIG_SPI_FLASH_STMICRO=y >>> CONFIG_PHY_MICREL=y >>> diff --git a/configs/socfpga_sr1500_defconfig >>> b/configs/socfpga_sr1500_defconfig >>> index f9ed1a3..df1ee31 100644 >>> --- a/configs/socfpga_sr1500_defconfig >>> +++ b/configs/socfpga_sr1500_defconfig >>> @@ -53,6 +53,7 @@ CONFIG_DM_MMC=y >>> CONFIG_MMC_DW=y >>> CONFIG_SPI_FLASH=y >>> CONFIG_SPI_FLASH_BAR=y >>> +CONFIG_SPI_FLASH_MACRONIX=y >>> CONFIG_SPI_FLASH_STMICRO=y >>> # CONFIG_SPI_FLASH_USE_4K_SECTORS is not set >>> CONFIG_DM_ETH=y >>> diff --git a/configs/socfpga_vining_fpga_defconfig >>> b/configs/socfpga_vining_fpga_defconfig >>> index 6670b9f..512d701 100644 >>> --- a/configs/socfpga_vining_fpga_defconfig >>> +++ b/configs/socfpga_vining_fpga_defconfig >>> @@ -69,6 +69,7 @@ CONFIG_LED_STATUS_CMD=y >>> CONFIG_DM_MMC=y >>> CONFIG_MMC_DW=y >>> CONFIG_SPI_FLASH=y >>> +CONFIG_SPI_FLASH_MACRONIX=y >>> CONFIG_SPI_FLASH_SPANSION=y >>> CONFIG_SPI_FLASH_STMICRO=y >>> # CONFIG_SPI_FLASH_USE_4K_SECTORS is not set >>> > _______________________________________________ > U-Boot mailing list > U-Boot@lists.denx.de > https://lists.denx.de/listinfo/u-boot
On 02/22/2018 07:29 AM, See, Chin Liang wrote: > On Wed, 2018-02-21 at 20:23 +0100, Marek Vasut wrote: >> On 02/21/2018 08:39 AM, chin.liang.see@intel.com wrote: >>> >>> From: Chin Liang See <chin.liang.see@intel.com> >>> >>> Enable Macronix flash support for Cyclone5 SoC >> Do these boards actually have a macronix flash ? Most of the ones I >> know >> of do not. > > Good question. > > Actually they are pin compatible and customer can replace the existing > one. FYI, there seems a NOR flash shortage worldwide which lead to > requests by customer to change the BOM list. I'm quite sure better half of those boards won't . If you want to enable the SPI NORs on the devkits, fine, but the is1, sr1500 and vining are unlikely to get a replacement memory type. [...]
On Thu, 2018-02-22 at 11:45 +0100, Marek Vasut wrote: > On 02/22/2018 07:29 AM, See, Chin Liang wrote: > > > > On Wed, 2018-02-21 at 20:23 +0100, Marek Vasut wrote: > > > > > > On 02/21/2018 08:39 AM, chin.liang.see@intel.com wrote: > > > > > > > > > > > > From: Chin Liang See <chin.liang.see@intel.com> > > > > > > > > Enable Macronix flash support for Cyclone5 SoC > > > Do these boards actually have a macronix flash ? Most of the ones > > > I > > > know > > > of do not. > > Good question. > > > > Actually they are pin compatible and customer can replace the > > existing > > one. FYI, there seems a NOR flash shortage worldwide which lead to > > requests by customer to change the BOM list. > I'm quite sure better half of those boards won't . If you want to > enable > the SPI NORs on the devkits, fine, but the is1, sr1500 and vining are > unlikely to get a replacement memory type. Actually the way the code works is detecting JEDEC ID and associate it with correct flash drivers like Micron, Spansion or Macronix. Hence it would not yield any issue except slightly larger code. But I can take out sr1500 and vining if it yield a concern. Thanks Chin Liang > > [...] >
On 02/22/2018 02:39 PM, See, Chin Liang wrote: > On Thu, 2018-02-22 at 11:45 +0100, Marek Vasut wrote: >> On 02/22/2018 07:29 AM, See, Chin Liang wrote: >>> >>> On Wed, 2018-02-21 at 20:23 +0100, Marek Vasut wrote: >>>> >>>> On 02/21/2018 08:39 AM, chin.liang.see@intel.com wrote: >>>>> >>>>> >>>>> From: Chin Liang See <chin.liang.see@intel.com> >>>>> >>>>> Enable Macronix flash support for Cyclone5 SoC >>>> Do these boards actually have a macronix flash ? Most of the ones >>>> I >>>> know >>>> of do not. >>> Good question. >>> >>> Actually they are pin compatible and customer can replace the >>> existing >>> one. FYI, there seems a NOR flash shortage worldwide which lead to >>> requests by customer to change the BOM list. >> I'm quite sure better half of those boards won't . If you want to >> enable >> the SPI NORs on the devkits, fine, but the is1, sr1500 and vining are >> unlikely to get a replacement memory type. > > Actually the way the code works is detecting JEDEC ID and associate it > with correct flash drivers like Micron, Spansion or Macronix. Hence it > would not yield any issue except slightly larger code. Which on those boards I listed is useless dead code. > But I can take > out sr1500 and vining if it yield a concern. IS1 too.
diff --git a/configs/socfpga_cyclone5_defconfig b/configs/socfpga_cyclone5_defconfig index 6ebd8a9..aa535c6 100644 --- a/configs/socfpga_cyclone5_defconfig +++ b/configs/socfpga_cyclone5_defconfig @@ -53,6 +53,7 @@ CONFIG_DM_MMC=y CONFIG_MMC_DW=y CONFIG_SPI_FLASH=y CONFIG_SPI_FLASH_BAR=y +CONFIG_SPI_FLASH_MACRONIX=y CONFIG_SPI_FLASH_SPANSION=y CONFIG_SPI_FLASH_STMICRO=y # CONFIG_SPI_FLASH_USE_4K_SECTORS is not set diff --git a/configs/socfpga_is1_defconfig b/configs/socfpga_is1_defconfig index 08628ab..7be720a 100644 --- a/configs/socfpga_is1_defconfig +++ b/configs/socfpga_is1_defconfig @@ -48,6 +48,7 @@ CONFIG_SYS_I2C_DW=y # CONFIG_MMC is not set CONFIG_SPI_FLASH=y CONFIG_SPI_FLASH_BAR=y +CONFIG_SPI_FLASH_MACRONIX=y CONFIG_SPI_FLASH_STMICRO=y CONFIG_PHY_MICREL=y CONFIG_PHY_MICREL_KSZ90X1=y diff --git a/configs/socfpga_sockit_defconfig b/configs/socfpga_sockit_defconfig index 8ebe394..6edb47f 100644 --- a/configs/socfpga_sockit_defconfig +++ b/configs/socfpga_sockit_defconfig @@ -53,6 +53,7 @@ CONFIG_DM_MMC=y CONFIG_MMC_DW=y CONFIG_SPI_FLASH=y CONFIG_SPI_FLASH_BAR=y +CONFIG_SPI_FLASH_MACRONIX=y CONFIG_SPI_FLASH_SPANSION=y CONFIG_SPI_FLASH_STMICRO=y # CONFIG_SPI_FLASH_USE_4K_SECTORS is not set diff --git a/configs/socfpga_socrates_defconfig b/configs/socfpga_socrates_defconfig index 9f42481..7c2428a 100644 --- a/configs/socfpga_socrates_defconfig +++ b/configs/socfpga_socrates_defconfig @@ -54,6 +54,7 @@ CONFIG_DM_MMC=y CONFIG_MMC_DW=y CONFIG_SPI_FLASH=y CONFIG_SPI_FLASH_BAR=y +CONFIG_SPI_FLASH_MACRONIX=y CONFIG_SPI_FLASH_SPANSION=y CONFIG_SPI_FLASH_STMICRO=y CONFIG_PHY_MICREL=y diff --git a/configs/socfpga_sr1500_defconfig b/configs/socfpga_sr1500_defconfig index f9ed1a3..df1ee31 100644 --- a/configs/socfpga_sr1500_defconfig +++ b/configs/socfpga_sr1500_defconfig @@ -53,6 +53,7 @@ CONFIG_DM_MMC=y CONFIG_MMC_DW=y CONFIG_SPI_FLASH=y CONFIG_SPI_FLASH_BAR=y +CONFIG_SPI_FLASH_MACRONIX=y CONFIG_SPI_FLASH_STMICRO=y # CONFIG_SPI_FLASH_USE_4K_SECTORS is not set CONFIG_DM_ETH=y diff --git a/configs/socfpga_vining_fpga_defconfig b/configs/socfpga_vining_fpga_defconfig index 6670b9f..512d701 100644 --- a/configs/socfpga_vining_fpga_defconfig +++ b/configs/socfpga_vining_fpga_defconfig @@ -69,6 +69,7 @@ CONFIG_LED_STATUS_CMD=y CONFIG_DM_MMC=y CONFIG_MMC_DW=y CONFIG_SPI_FLASH=y +CONFIG_SPI_FLASH_MACRONIX=y CONFIG_SPI_FLASH_SPANSION=y CONFIG_SPI_FLASH_STMICRO=y # CONFIG_SPI_FLASH_USE_4K_SECTORS is not set