Message ID | 1498293410-16222-1-git-send-email-harald@ccbib.org |
---|---|
State | Not Applicable, archived |
Headers | show |
Hi, what happened to the patch below? It was written to your specification, got an ACK from devicetree and has no unaddressed review comments, so I can't see what might be holding it back. It has been more then 6 month since the last resend, but I still can't find it in any tree... HTH, Harald Harald Geyer wrote on Sat, 24 Jun 2017 08:36:50 -0000: > These two drivers fail to probe if no name is provided. For details see: > https://www.spinics.net/lists/kernel/msg2457515.html > > Signed-off-by: Harald Geyer <harald@ccbib.org> > Acked-by: Rob Herring <robh@kernel.org> > --- > Added the ACK in the resend. > > Documentation/devicetree/bindings/regulator/fixed-regulator.txt | 1 + > Documentation/devicetree/bindings/regulator/gpio-regulator.txt | 2 ++ > 2 files changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/regulator/fixed-regulator.txt b/Documentation/devicetree/bindings/regulator/fixed-regulator.txt > index 4fae41d..0c2a6c8 100644 > --- a/Documentation/devicetree/bindings/regulator/fixed-regulator.txt > +++ b/Documentation/devicetree/bindings/regulator/fixed-regulator.txt > @@ -2,6 +2,7 @@ Fixed Voltage regulators > > Required properties: > - compatible: Must be "regulator-fixed"; > +- regulator-name: Defined in regulator.txt as optional, but required here. > > Optional properties: > - gpio: gpio to use for enable control > diff --git a/Documentation/devicetree/bindings/regulator/gpio-regulator.txt b/Documentation/devicetree/bindings/regulator/gpio-regulator.txt > index dd1ed78..1f49615 100644 > --- a/Documentation/devicetree/bindings/regulator/gpio-regulator.txt > +++ b/Documentation/devicetree/bindings/regulator/gpio-regulator.txt > @@ -2,6 +2,8 @@ GPIO controlled regulators > > Required properties: > - compatible : Must be "regulator-gpio". > +- regulator-name : Defined in regulator.txt as optional, but required > + here. > - states : Selection of available voltages and GPIO configs. > if there are no states, then use a fixed regulator > > -- > 2.1.4 >
On Tue, Feb 13, 2018 at 12:50:09PM +0100, Harald Geyer wrote: > what happened to the patch below? It was written to your specification, > got an ACK from devicetree and has no unaddressed review comments, so I > can't see what might be holding it back. > > It has been more then 6 month since the last resend, but I still can't > find it in any tree... Please don't send content free pings. Sending content free pings adds to the mail volume (if they are seen at all) which is often the problem and since they can't be reviewed directly if something has gone wrong you'll have to resend the patches anyway, though there are some other maintainers who like them - if in doubt look at how patches for the subsystem are normally handled. Please don't top post, reply in line with needed context. This allows readers to readily follow the flow of conversation and understand what you are talking about and also helps ensure that everything in the discussion is being addressed.
diff --git a/Documentation/devicetree/bindings/regulator/fixed-regulator.txt b/Documentation/devicetree/bindings/regulator/fixed-regulator.txt index 4fae41d..0c2a6c8 100644 --- a/Documentation/devicetree/bindings/regulator/fixed-regulator.txt +++ b/Documentation/devicetree/bindings/regulator/fixed-regulator.txt @@ -2,6 +2,7 @@ Fixed Voltage regulators Required properties: - compatible: Must be "regulator-fixed"; +- regulator-name: Defined in regulator.txt as optional, but required here. Optional properties: - gpio: gpio to use for enable control diff --git a/Documentation/devicetree/bindings/regulator/gpio-regulator.txt b/Documentation/devicetree/bindings/regulator/gpio-regulator.txt index dd1ed78..1f49615 100644 --- a/Documentation/devicetree/bindings/regulator/gpio-regulator.txt +++ b/Documentation/devicetree/bindings/regulator/gpio-regulator.txt @@ -2,6 +2,8 @@ GPIO controlled regulators Required properties: - compatible : Must be "regulator-gpio". +- regulator-name : Defined in regulator.txt as optional, but required + here. - states : Selection of available voltages and GPIO configs. if there are no states, then use a fixed regulator