Message ID | 1517156391-11353-9-git-send-email-jagan@amarulasolutions.com |
---|---|
State | Changes Requested |
Delegated to: | Marek Vasut |
Headers | show |
Series | musb: sunxi: Add OTG-Peripheral support for Allwineer H3/H5/A64 | expand |
Hi, On Sun, Jan 28, 2018 at 09:49:29PM +0530, Jagan Teki wrote: > PHYCTL register offset at 0x10 need to be cleared before it's > written. Ported from below Linux patch. > d699c1d phy: sun4i-usb: change PHYCTL register clearing code > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> > Signed-off-by: Jun Nie <jun.nie@linaro.org> Those signed-off-by don't make much sense. Either Jun made that patch and should be the author, or you made that patch, and Jun Signed-off shouldn't be there. Maxime
On Mon, Jan 29, 2018 at 1:29 PM, Maxime Ripard <maxime.ripard@free-electrons.com> wrote: > Hi, > > On Sun, Jan 28, 2018 at 09:49:29PM +0530, Jagan Teki wrote: >> PHYCTL register offset at 0x10 need to be cleared before it's >> written. Ported from below Linux patch. >> d699c1d phy: sun4i-usb: change PHYCTL register clearing code >> >> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> >> Signed-off-by: Jun Nie <jun.nie@linaro.org> > > Those signed-off-by don't make much sense. Either Jun made that patch > and should be the author, or you made that patch, and Jun Signed-off > shouldn't be there. Don't understand what doesn't make sense, more Signed-off-by implies group of people worked on the particular change and author who usually made this. This is what I usually follow all my patches if the change/patch work together.
On Mon, Jan 29, 2018 at 01:44:53PM +0530, Jagan Teki wrote: > On Mon, Jan 29, 2018 at 1:29 PM, Maxime Ripard > <maxime.ripard@free-electrons.com> wrote: > > Hi, > > > > On Sun, Jan 28, 2018 at 09:49:29PM +0530, Jagan Teki wrote: > >> PHYCTL register offset at 0x10 need to be cleared before it's > >> written. Ported from below Linux patch. > >> d699c1d phy: sun4i-usb: change PHYCTL register clearing code > >> > >> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> > >> Signed-off-by: Jun Nie <jun.nie@linaro.org> > > > > Those signed-off-by don't make much sense. Either Jun made that patch > > and should be the author, or you made that patch, and Jun Signed-off > > shouldn't be there. > > Don't understand what doesn't make sense, more Signed-off-by implies > group of people worked on the particular change and author who usually > made this. This is what I usually follow all my patches if the > change/patch work together. Jun's Signed-off implies that he merged and carried this patch, ie Jun was acting as a maintainer, or was sending a patch on behalf of you. This isn't the case. Maxime
diff --git a/arch/arm/mach-sunxi/usb_phy.c b/arch/arm/mach-sunxi/usb_phy.c index 9a0a1b9..32ee0d4 100644 --- a/arch/arm/mach-sunxi/usb_phy.c +++ b/arch/arm/mach-sunxi/usb_phy.c @@ -126,7 +126,8 @@ __maybe_unused static void usb_phy_write(struct sunxi_usb_phy *phy, int addr, int j = 0, usbc_bit = 0; void *dest = (void *)SUNXI_USB0_BASE + SUNXI_USB_CSR; -#ifdef CONFIG_MACH_SUN8I_A33 +#if defined(CONFIG_MACH_SUN8I_A33) || defined(CONFIG_MACH_SUNXI_H3_H5) || \ + defined(CONFIG_MACH_SUN50I) /* CSR needs to be explicitly initialized to 0 on A33 */ writel(0, dest); #endif