| Message ID | 1516848120-52550-1-git-send-email-yszhou4tech@gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [LEDE-DEV] build: disable BUILD_PATENTED by default | expand |
> On 25 Jan 2018, at 02:42, Yousong Zhou <yszhou4tech@gmail.com> wrote: > > Signed-off-by: Yousong Zhou <yszhou4tech@gmail.com> > --- > config/Config-build.in | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/config/Config-build.in b/config/Config-build.in > index f9987fc..7ec7653 100644 > --- a/config/Config-build.in > +++ b/config/Config-build.in > @@ -41,7 +41,7 @@ menu "Global build settings" > default n > > config BUILD_PATENTED > - default y > + default n > bool "Compile with support for patented functionality" > help > When this option is disabled, software which provides patented functionality > -- > 1.8.3.1 > > > _______________________________________________ > Lede-dev mailing list > Lede-dev@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/lede-dev The commit messages lacks a “Why we need this change”. Cheers, Kevin D-B 012C ACB2 28C6 C53E 9775 9123 B3A2 389B 9DE2 334A
On 25 January 2018 at 19:30, Kevin Darbyshire-Bryant <kevin@darbyshire-bryant.me.uk> wrote: > > >> On 25 Jan 2018, at 02:42, Yousong Zhou <yszhou4tech@gmail.com> wrote: >> >> Signed-off-by: Yousong Zhou <yszhou4tech@gmail.com> >> --- >> config/Config-build.in | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/config/Config-build.in b/config/Config-build.in >> index f9987fc..7ec7653 100644 >> --- a/config/Config-build.in >> +++ b/config/Config-build.in >> @@ -41,7 +41,7 @@ menu "Global build settings" >> default n >> >> config BUILD_PATENTED >> - default y >> + default n >> bool "Compile with support for patented functionality" >> help >> When this option is disabled, software which provides patented functionality >> -- >> 1.8.3.1 >> >> >> _______________________________________________ >> Lede-dev mailing list >> Lede-dev@lists.infradead.org >> http://lists.infradead.org/mailman/listinfo/lede-dev > > The commit messages lacks a “Why we need this change”. > > > Cheers, > > Kevin D-B Sorry, I thought the reason was very very apparent and the patch was posted here mainly to serve as a prior notification to mitigate possible surprise... That said, the reason behind the change is that I think we are not supposed to promote usage of and redistribute binaries of patented code/technologies, for legal considerations I only vaguely "groked". This seems to be the established practice with ffmpeg, flashplayer, video card drivers, etc. with other linux distributions Turning off BUILD_PATENTED by default is the first safe step. yousong
> On 25 Jan 2018, at 12:58, Yousong Zhou <yszhou4tech@gmail.com> wrote: > > On 25 January 2018 at 19:30, Kevin Darbyshire-Bryant > <kevin@darbyshire-bryant.me.uk> wrote: >> >> >>> On 25 Jan 2018, at 02:42, Yousong Zhou <yszhou4tech@gmail.com> wrote: >>> >>> Signed-off-by: Yousong Zhou <yszhou4tech@gmail.com> >>> --- >>> config/Config-build.in | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/config/Config-build.in b/config/Config-build.in >>> index f9987fc..7ec7653 100644 >>> --- a/config/Config-build.in >>> +++ b/config/Config-build.in >>> @@ -41,7 +41,7 @@ menu "Global build settings" >>> default n >>> >>> config BUILD_PATENTED >>> - default y >>> + default n >>> bool "Compile with support for patented functionality" >>> help >>> When this option is disabled, software which provides patented functionality >>> -- >>> 1.8.3.1 >>> >>> >>> _______________________________________________ >>> Lede-dev mailing list >>> Lede-dev@lists.infradead.org >>> http://lists.infradead.org/mailman/listinfo/lede-dev >> >> The commit messages lacks a “Why we need this change”. >> >> >> Cheers, >> >> Kevin D-B > > Sorry, I thought the reason was very very apparent and the patch was > posted here mainly to serve as a prior notification to mitigate > possible surprise... > > That said, the reason behind the change is that I think we are not > supposed to promote usage of and redistribute binaries of patented > code/technologies, for legal considerations I only vaguely "groked". > This seems to be the established practice with ffmpeg, flashplayer, > video card drivers, etc. with other linux distributions > > Turning off BUILD_PATENTED by default is the first safe step. And that ^^^^^^ is what should be in the commit message, ‘cos I didn’t know. We’ll be a to see what the commit did, and why we chose to do it. Wunderbar :-) Cheers, Kevin D-B 012C ACB2 28C6 C53E 9775 9123 B3A2 389B 9DE2 334A
On Thu, Jan 25, 2018 at 5:03 AM, Kevin Darbyshire-Bryant <kevin@darbyshire-bryant.me.uk> wrote: > > >> On 25 Jan 2018, at 12:58, Yousong Zhou <yszhou4tech@gmail.com> wrote: >> >> On 25 January 2018 at 19:30, Kevin Darbyshire-Bryant >> <kevin@darbyshire-bryant.me.uk> wrote: >>> >>> >>>> On 25 Jan 2018, at 02:42, Yousong Zhou <yszhou4tech@gmail.com> wrote: >>>> >>>> Signed-off-by: Yousong Zhou <yszhou4tech@gmail.com> >>>> --- >>>> config/Config-build.in | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/config/Config-build.in b/config/Config-build.in >>>> index f9987fc..7ec7653 100644 >>>> --- a/config/Config-build.in >>>> +++ b/config/Config-build.in >>>> @@ -41,7 +41,7 @@ menu "Global build settings" >>>> default n >>>> >>>> config BUILD_PATENTED >>>> - default y >>>> + default n >>>> bool "Compile with support for patented functionality" >>>> help >>>> When this option is disabled, software which provides patented functionality >>>> -- >>>> 1.8.3.1 >>>> >>>> >>>> _______________________________________________ >>>> Lede-dev mailing list >>>> Lede-dev@lists.infradead.org >>>> http://lists.infradead.org/mailman/listinfo/lede-dev >>> >>> The commit messages lacks a “Why we need this change”. >>> >>> >>> Cheers, >>> >>> Kevin D-B >> >> Sorry, I thought the reason was very very apparent and the patch was >> posted here mainly to serve as a prior notification to mitigate >> possible surprise... >> >> That said, the reason behind the change is that I think we are not >> supposed to promote usage of and redistribute binaries of patented >> code/technologies, for legal considerations I only vaguely "groked". >> This seems to be the established practice with ffmpeg, flashplayer, >> video card drivers, etc. with other linux distributions >> >> Turning off BUILD_PATENTED by default is the first safe step. > The second step of course would be to remove stuff like mp2 and mp3 from the purview of BUILD_PATENTED as mp[23] patents have both expired. > And that ^^^^^^ is what should be in the commit message, ‘cos I didn’t know. We’ll be a to see what the commit did, and why we chose to do it. Wunderbar :-) > > > > Cheers, > > Kevin D-B > > 012C ACB2 28C6 C53E 9775 9123 B3A2 389B 9DE2 334A > > > _______________________________________________ > Lede-dev mailing list > Lede-dev@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/lede-dev >
On 26 January 2018 at 10:23, Rosen Penev <rosenp@gmail.com> wrote: > On Thu, Jan 25, 2018 at 5:03 AM, Kevin Darbyshire-Bryant > <kevin@darbyshire-bryant.me.uk> wrote: >> >> >>> On 25 Jan 2018, at 12:58, Yousong Zhou <yszhou4tech@gmail.com> wrote: >>> >>> On 25 January 2018 at 19:30, Kevin Darbyshire-Bryant >>> <kevin@darbyshire-bryant.me.uk> wrote: >>>> >>>> >>>>> On 25 Jan 2018, at 02:42, Yousong Zhou <yszhou4tech@gmail.com> wrote: >>>>> >>>>> Signed-off-by: Yousong Zhou <yszhou4tech@gmail.com> >>>>> --- >>>>> config/Config-build.in | 2 +- >>>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>>> >>>>> diff --git a/config/Config-build.in b/config/Config-build.in >>>>> index f9987fc..7ec7653 100644 >>>>> --- a/config/Config-build.in >>>>> +++ b/config/Config-build.in >>>>> @@ -41,7 +41,7 @@ menu "Global build settings" >>>>> default n >>>>> >>>>> config BUILD_PATENTED >>>>> - default y >>>>> + default n >>>>> bool "Compile with support for patented functionality" >>>>> help >>>>> When this option is disabled, software which provides patented functionality >>>>> -- >>>>> 1.8.3.1 >>>>> >>>>> >>>>> _______________________________________________ >>>>> Lede-dev mailing list >>>>> Lede-dev@lists.infradead.org >>>>> http://lists.infradead.org/mailman/listinfo/lede-dev >>>> >>>> The commit messages lacks a “Why we need this change”. >>>> >>>> >>>> Cheers, >>>> >>>> Kevin D-B >>> >>> Sorry, I thought the reason was very very apparent and the patch was >>> posted here mainly to serve as a prior notification to mitigate >>> possible surprise... >>> >>> That said, the reason behind the change is that I think we are not >>> supposed to promote usage of and redistribute binaries of patented >>> code/technologies, for legal considerations I only vaguely "groked". >>> This seems to be the established practice with ffmpeg, flashplayer, >>> video card drivers, etc. with other linux distributions >>> >>> Turning off BUILD_PATENTED by default is the first safe step. >> > The second step of course would be to remove stuff like mp2 and mp3 > from the purview of BUILD_PATENTED as mp[23] patents have both > expired. Yesterday I checked, the mp3lame or names like that did not have the tag. Feel free to open a pull request if it's not the case. yousong
diff --git a/config/Config-build.in b/config/Config-build.in index f9987fc..7ec7653 100644 --- a/config/Config-build.in +++ b/config/Config-build.in @@ -41,7 +41,7 @@ menu "Global build settings" default n config BUILD_PATENTED - default y + default n bool "Compile with support for patented functionality" help When this option is disabled, software which provides patented functionality
Signed-off-by: Yousong Zhou <yszhou4tech@gmail.com> --- config/Config-build.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)