[PATCHv3,net-next,0/7] net: sched: cls: add extack support

Hi,

this patch adds extack support for TC classifier subsystem. The first
patch fixes some code style issues for this patch series pointed out
by checkpatch. The other patches until the last one prepares extack
handling for the TC classifier subsystem and handle generic extack
errors.

The last patch is an example for u32 classifier to add extack support
inside the callbacks delete and change. There exists a init callback as
well, but most classifier implementation run a kalloc() once to allocate
something. Not necessary _yet_ to add extack support now.

- Alex

Cc: David Ahern <dsahern@gmail.com>

changes since v3:
 - fix accidentally move of config option mismatch message in PATCH 2/8
   correct one is 4/8, detected by kbuildbot (Thank you)
 - Removed patch "net: sched: cls: add extack support for tc_setup_cb_call"
   PATCH 7/8 in version v2 as suggested by Jakub Kicinski (Thank you)
 - changed NL_SET_ERR_MSG to NL_SET_ERR_MSG_MOD as suggested by Jakub Kicinski
   in u32 cls (Thank You)
 - Removed text from cover letter that I was waiting for Jiri's Patches as
   detected by Jamal Hadi Salim (Thank you).

changes since v2:
 - rebased on Jiri's patches (Thank you)
 - several spelling fixes pointed out by Cong Wang (Thank you)
 - several spelling fixes pointed out by David Ahern (Thank you)
 - use David Ahern recommendation if config option is mismatch, but
   combine it with Cong Wang recommendation to put config name into it
   (Thank you)

Alexander Aring (7):
  net: sched: cls: fix code style issues
  net: sched: cls_api: handle generic cls errors
  net: sched: cls: add extack support for change callback
  net: sched: cls: add extack support for tcf_exts_validate
  net: sched: cls: add extack support for delete callback
  net: sched: cls: add extack support for tcf_change_indev
  net: sched: cls_u32: add extack support

 include/net/pkt_cls.h     | 10 +++++--
 include/net/sch_generic.h |  7 +++--
 net/sched/cls_api.c       | 64 +++++++++++++++++++++++++++++----------
 net/sched/cls_basic.c     | 14 +++++----
 net/sched/cls_bpf.c       | 13 ++++----
 net/sched/cls_cgroup.c    |  9 ++++--
 net/sched/cls_flow.c      |  8 +++--
 net/sched/cls_flower.c    | 20 ++++++++-----
 net/sched/cls_fw.c        | 17 ++++++-----
 net/sched/cls_matchall.c  | 15 ++++++----
 net/sched/cls_route.c     | 12 ++++----
 net/sched/cls_rsvp.h      |  7 +++--
 net/sched/cls_tcindex.c   | 14 +++++----
 net/sched/cls_u32.c       | 76 ++++++++++++++++++++++++++++++++++-------------
 14 files changed, 194 insertions(+), 92 deletions(-)

On Thu, 18 Jan 2018 11:20:48 -0500, Alexander Aring wrote:
> Hi,
> 
> this patch adds extack support for TC classifier subsystem. The first
> patch fixes some code style issues for this patch series pointed out
> by checkpatch. The other patches until the last one prepares extack
> handling for the TC classifier subsystem and handle generic extack
> errors.
> 
> The last patch is an example for u32 classifier to add extack support
> inside the callbacks delete and change. There exists a init callback as
> well, but most classifier implementation run a kalloc() once to allocate
> something. Not necessary _yet_ to add extack support now.
> 
> - Alex
> 
> Cc: David Ahern <dsahern@gmail.com>
> 
> changes since v3:
>  - fix accidentally move of config option mismatch message in PATCH 2/8
>    correct one is 4/8, detected by kbuildbot (Thank you)
>  - Removed patch "net: sched: cls: add extack support for tc_setup_cb_call"
>    PATCH 7/8 in version v2 as suggested by Jakub Kicinski (Thank you)
>  - changed NL_SET_ERR_MSG to NL_SET_ERR_MSG_MOD as suggested by Jakub Kicinski
>    in u32 cls (Thank You)
>  - Removed text from cover letter that I was waiting for Jiri's Patches as
>    detected by Jamal Hadi Salim (Thank you).

LGTM now, thank you!

From: Alexander Aring <aring@mojatatu.com>
Date: Thu, 18 Jan 2018 11:20:48 -0500

> this patch adds extack support for TC classifier subsystem. The first
> patch fixes some code style issues for this patch series pointed out
> by checkpatch. The other patches until the last one prepares extack
> handling for the TC classifier subsystem and handle generic extack
> errors.
> 
> The last patch is an example for u32 classifier to add extack support
> inside the callbacks delete and change. There exists a init callback as
> well, but most classifier implementation run a kalloc() once to allocate
> something. Not necessary _yet_ to add extack support now.

Series applied, tanks.