Message ID | alpine.DEB.2.20.1801111459140.3390@hadrien |
---|---|
State | Awaiting Upstream, archived |
Delegated to: | David Miller |
Headers | show |
Series | netfilter: nf_tables: fix odd_ptr_err.cocci warnings | expand |
On Thu, Jan 11, 2018 at 03:02:12PM +0100, Julia Lawall wrote: > tree: > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > head: b4464bcab38d3f7fe995a7cb960eeac6889bec08 > commit: 3b49e2e94e6ebb8b23d0955d9e898254455734f8 [8286/9035] netfilter: > nf_tables: add flow table netlink frontend > > The following is a 0-day report generated by Coccinelle. But from the > line before, it looks like the fix is backwards, and the test shoud be on > flowtable. There's a fix for this in nf-next.git https://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf-next.git/commit/?id=03a0120f75dfb1807c0441376e26b36160087de4 Will pass it up to David asap.
--- a/net/netfilter/nf_tables_api.c +++ b/net/netfilter/nf_tables_api.c @@ -5419,7 +5419,7 @@ static int nf_tables_getflowtable(struct flowtable = nf_tables_flowtable_lookup(table, nla[NFTA_FLOWTABLE_NAME], genmask); if (IS_ERR(table)) - return PTR_ERR(flowtable); + return PTR_ERR(table); skb2 = alloc_skb(NLMSG_GOODSIZE, GFP_KERNEL); if (!skb2)