| Message ID | 1514392046-30602-5-git-send-email-kramasub@codeaurora.org |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | Introduce GENI SE Controller Driver | expand |
On Wed, Dec 27, 2017 at 09:27:23AM -0700, Karthikeyan Ramasubramanian wrote: > Add device tree binding support for I2C Controller in GENI based > QUP Wrapper. > > Signed-off-by: Sagar Dharia <sdharia@codeaurora.org> > Signed-off-by: Karthikeyan Ramasubramanian <kramasub@codeaurora.org> > --- > .../devicetree/bindings/i2c/i2c-qcom-geni.txt | 39 ++++++++++++++++++++++ > 1 file changed, 39 insertions(+) > create mode 100644 Documentation/devicetree/bindings/i2c/i2c-qcom-geni.txt > > diff --git a/Documentation/devicetree/bindings/i2c/i2c-qcom-geni.txt b/Documentation/devicetree/bindings/i2c/i2c-qcom-geni.txt > new file mode 100644 > index 0000000..d2fa9ce > --- /dev/null > +++ b/Documentation/devicetree/bindings/i2c/i2c-qcom-geni.txt > @@ -0,0 +1,39 @@ > +Qualcomm Technologies Inc. GENI based I2C Controller driver > + > +Required properties: > + - compatible: Should be: > + * "qcom,i2c-geni. Only 1 version? > + - reg: Should contain QUP register address and length. > + - interrupts: Should contain I2C interrupt. > + - clocks: Serial engine core clock, and AHB clocks needed by the device. Are there really clocks for a firmware based device or these are just clocks in the parent serial engine? > + - pinctrl-names/pinctrl-0/1: The GPIOs assigned to this core. The names > + should be "active" and "sleep" for the pin confuguration when core is active > + or when entering sleep state. > + - #address-cells: Should be <1> Address cells for i2c device address > + - #size-cells: Should be <0> as i2c addresses have no size component > + - qcom,wrapper-core: Wrapper QUP core containing this I2C controller. Probably these devices should be child nodes of the QUP core node. > + > +Optional property: > + - qcom,clk-freq-out : Desired I2C bus clock frequency in Hz. > + When missing default to 400000Hz. There's a standard property for this. > + > +Child nodes should conform to i2c bus binding. > + > +Example: > + > +i2c@a94000 { > + compatible = "qcom,i2c-geni"; > + reg = <0xa94000 0x4000>; > + interrupts = <GIC_SPI 358 0>; > + clock-names = "se-clk", "m-ahb", "s-ahb"; > + clocks = <&clock_gcc GCC_QUPV3_WRAP0_S5_CLK>, > + <&clock_gcc GCC_QUPV3_WRAP_0_M_AHB_CLK>, > + <&clock_gcc GCC_QUPV3_WRAP_0_S_AHB_CLK>; > + pinctrl-names = "default", "sleep"; > + pinctrl-0 = <&qup_1_i2c_5_active>; > + pinctrl-1 = <&qup_1_i2c_5_sleep>; > + #address-cells = <1>; > + #size-cells = <0>; > + qcom,wrapper-core = <&qup_0>; > + qcom,clk-freq-out = <400000>; > +}; > -- > Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 1/2/2018 8:51 AM, Rob Herring wrote: > On Wed, Dec 27, 2017 at 09:27:23AM -0700, Karthikeyan Ramasubramanian wrote: >> Add device tree binding support for I2C Controller in GENI based >> QUP Wrapper. >> >> Signed-off-by: Sagar Dharia <sdharia@codeaurora.org> >> Signed-off-by: Karthikeyan Ramasubramanian <kramasub@codeaurora.org> >> --- >> .../devicetree/bindings/i2c/i2c-qcom-geni.txt | 39 ++++++++++++++++++++++ >> 1 file changed, 39 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/i2c/i2c-qcom-geni.txt >> >> diff --git a/Documentation/devicetree/bindings/i2c/i2c-qcom-geni.txt b/Documentation/devicetree/bindings/i2c/i2c-qcom-geni.txt >> new file mode 100644 >> index 0000000..d2fa9ce >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/i2c/i2c-qcom-geni.txt >> @@ -0,0 +1,39 @@ >> +Qualcomm Technologies Inc. GENI based I2C Controller driver >> + >> +Required properties: >> + - compatible: Should be: >> + * "qcom,i2c-geni. > > Only 1 version? The Serial Engine used by I2C protocol has the same version as the QUP h/w version. The QUP Wrapper driver exposes an interface function to get the h/w version so that I2C controller driver can support version-specific operations, if any. > >> + - reg: Should contain QUP register address and length. >> + - interrupts: Should contain I2C interrupt. >> + - clocks: Serial engine core clock, and AHB clocks needed by the device. > > Are there really clocks for a firmware based device or these are just > clocks in the parent serial engine? The clocks are required to derive the protocol clock. The clocks are also required by the Serial Engine to access the System Memory during DMA mode of operation. > >> + - pinctrl-names/pinctrl-0/1: The GPIOs assigned to this core. The names >> + should be "active" and "sleep" for the pin confuguration when core is active >> + or when entering sleep state. >> + - #address-cells: Should be <1> Address cells for i2c device address >> + - #size-cells: Should be <0> as i2c addresses have no size component >> + - qcom,wrapper-core: Wrapper QUP core containing this I2C controller. > > Probably these devices should be child nodes of the QUP core node. I will update it in the next patch. > >> + >> +Optional property: >> + - qcom,clk-freq-out : Desired I2C bus clock frequency in Hz. >> + When missing default to 400000Hz. > > There's a standard property for this. I will update to use the standard property. > >> + >> +Child nodes should conform to i2c bus binding. >> + >> +Example: >> + >> +i2c@a94000 { >> + compatible = "qcom,i2c-geni"; >> + reg = <0xa94000 0x4000>; >> + interrupts = <GIC_SPI 358 0>; >> + clock-names = "se-clk", "m-ahb", "s-ahb"; >> + clocks = <&clock_gcc GCC_QUPV3_WRAP0_S5_CLK>, >> + <&clock_gcc GCC_QUPV3_WRAP_0_M_AHB_CLK>, >> + <&clock_gcc GCC_QUPV3_WRAP_0_S_AHB_CLK>; >> + pinctrl-names = "default", "sleep"; >> + pinctrl-0 = <&qup_1_i2c_5_active>; >> + pinctrl-1 = <&qup_1_i2c_5_sleep>; >> + #address-cells = <1>; >> + #size-cells = <0>; >> + qcom,wrapper-core = <&qup_0>; >> + qcom,clk-freq-out = <400000>; >> +}; >> -- >> Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, >> a Linux Foundation Collaborative Project >> > -- > To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Regards, Karthik.
On Mon, Jan 8, 2018 at 6:33 PM, Karthik Ramasubramanian <kramasub@codeaurora.org> wrote: > > > On 1/2/2018 8:51 AM, Rob Herring wrote: >> >> On Wed, Dec 27, 2017 at 09:27:23AM -0700, Karthikeyan Ramasubramanian >> wrote: >>> >>> Add device tree binding support for I2C Controller in GENI based >>> QUP Wrapper. >>> >>> Signed-off-by: Sagar Dharia <sdharia@codeaurora.org> >>> Signed-off-by: Karthikeyan Ramasubramanian <kramasub@codeaurora.org> >>> --- >>> .../devicetree/bindings/i2c/i2c-qcom-geni.txt | 39 >>> ++++++++++++++++++++++ >>> 1 file changed, 39 insertions(+) >>> create mode 100644 >>> Documentation/devicetree/bindings/i2c/i2c-qcom-geni.txt >>> >>> diff --git a/Documentation/devicetree/bindings/i2c/i2c-qcom-geni.txt >>> b/Documentation/devicetree/bindings/i2c/i2c-qcom-geni.txt >>> new file mode 100644 >>> index 0000000..d2fa9ce >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/i2c/i2c-qcom-geni.txt >>> @@ -0,0 +1,39 @@ >>> +Qualcomm Technologies Inc. GENI based I2C Controller driver >>> + >>> +Required properties: >>> + - compatible: Should be: >>> + * "qcom,i2c-geni. >> >> >> Only 1 version? > > The Serial Engine used by I2C protocol has the same version as the QUP h/w > version. The QUP Wrapper driver exposes an interface function to get the h/w > version so that I2C controller driver can support version-specific > operations, if any. >> >> >>> + - reg: Should contain QUP register address and length. >>> + - interrupts: Should contain I2C interrupt. >>> + - clocks: Serial engine core clock, and AHB clocks needed by the >>> device. >> >> >> Are there really clocks for a firmware based device or these are just >> clocks in the parent serial engine? > > The clocks are required to derive the protocol clock. The clocks are also > required by the Serial Engine to access the System Memory during DMA mode of > operation. You can get the QUP core (or Serial engine?) node and then get its clocks if you need to know the frequency. Put the clocks in DT in the h/w block they belong to. If you don't really have an I2C clock in the h/w, don't put one in the DT. Rob -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 1/11/2018 8:19 AM, Rob Herring wrote: > On Mon, Jan 8, 2018 at 6:33 PM, Karthik Ramasubramanian > <kramasub@codeaurora.org> wrote: >> >> >> On 1/2/2018 8:51 AM, Rob Herring wrote: >>> >>> On Wed, Dec 27, 2017 at 09:27:23AM -0700, Karthikeyan Ramasubramanian >>> wrote: >>>> >>>> Add device tree binding support for I2C Controller in GENI based >>>> QUP Wrapper. >>>> >>>> Signed-off-by: Sagar Dharia <sdharia@codeaurora.org> >>>> Signed-off-by: Karthikeyan Ramasubramanian <kramasub@codeaurora.org> >>>> --- >>>> .../devicetree/bindings/i2c/i2c-qcom-geni.txt | 39 >>>> ++++++++++++++++++++++ >>>> 1 file changed, 39 insertions(+) >>>> create mode 100644 >>>> Documentation/devicetree/bindings/i2c/i2c-qcom-geni.txt >>>> >>>> diff --git a/Documentation/devicetree/bindings/i2c/i2c-qcom-geni.txt >>>> b/Documentation/devicetree/bindings/i2c/i2c-qcom-geni.txt >>>> new file mode 100644 >>>> index 0000000..d2fa9ce >>>> --- /dev/null >>>> +++ b/Documentation/devicetree/bindings/i2c/i2c-qcom-geni.txt >>>> @@ -0,0 +1,39 @@ >>>> +Qualcomm Technologies Inc. GENI based I2C Controller driver >>>> + >>>> +Required properties: >>>> + - compatible: Should be: >>>> + * "qcom,i2c-geni. >>> >>> >>> Only 1 version? >> >> The Serial Engine used by I2C protocol has the same version as the QUP h/w >> version. The QUP Wrapper driver exposes an interface function to get the h/w >> version so that I2C controller driver can support version-specific >> operations, if any. >>> >>> >>>> + - reg: Should contain QUP register address and length. >>>> + - interrupts: Should contain I2C interrupt. >>>> + - clocks: Serial engine core clock, and AHB clocks needed by the >>>> device. >>> >>> >>> Are there really clocks for a firmware based device or these are just >>> clocks in the parent serial engine? >> >> The clocks are required to derive the protocol clock. The clocks are also >> required by the Serial Engine to access the System Memory during DMA mode of >> operation. > > You can get the QUP core (or Serial engine?) node and then get its > clocks if you need to know the frequency. Put the clocks in DT in the > h/w block they belong to. If you don't really have an I2C clock in the > h/w, don't put one in the DT. > The clocks that are used to access the System Memory are common to all the Serial Engines in the QUP Wrapper. I will move those clock definitions to the QUP core node. The clock that is used to derive the protocol clock is Serial Engine specific. Since the serial engine DT node is synonymous with the protocol with which it is programmed, I am defining that clock in the child node i.e. protocol controller block. > Rob > Regards, Karthik.
diff --git a/Documentation/devicetree/bindings/i2c/i2c-qcom-geni.txt b/Documentation/devicetree/bindings/i2c/i2c-qcom-geni.txt new file mode 100644 index 0000000..d2fa9ce --- /dev/null +++ b/Documentation/devicetree/bindings/i2c/i2c-qcom-geni.txt @@ -0,0 +1,39 @@ +Qualcomm Technologies Inc. GENI based I2C Controller driver + +Required properties: + - compatible: Should be: + * "qcom,i2c-geni. + - reg: Should contain QUP register address and length. + - interrupts: Should contain I2C interrupt. + - clocks: Serial engine core clock, and AHB clocks needed by the device. + - pinctrl-names/pinctrl-0/1: The GPIOs assigned to this core. The names + should be "active" and "sleep" for the pin confuguration when core is active + or when entering sleep state. + - #address-cells: Should be <1> Address cells for i2c device address + - #size-cells: Should be <0> as i2c addresses have no size component + - qcom,wrapper-core: Wrapper QUP core containing this I2C controller. + +Optional property: + - qcom,clk-freq-out : Desired I2C bus clock frequency in Hz. + When missing default to 400000Hz. + +Child nodes should conform to i2c bus binding. + +Example: + +i2c@a94000 { + compatible = "qcom,i2c-geni"; + reg = <0xa94000 0x4000>; + interrupts = <GIC_SPI 358 0>; + clock-names = "se-clk", "m-ahb", "s-ahb"; + clocks = <&clock_gcc GCC_QUPV3_WRAP0_S5_CLK>, + <&clock_gcc GCC_QUPV3_WRAP_0_M_AHB_CLK>, + <&clock_gcc GCC_QUPV3_WRAP_0_S_AHB_CLK>; + pinctrl-names = "default", "sleep"; + pinctrl-0 = <&qup_1_i2c_5_active>; + pinctrl-1 = <&qup_1_i2c_5_sleep>; + #address-cells = <1>; + #size-cells = <0>; + qcom,wrapper-core = <&qup_0>; + qcom,clk-freq-out = <400000>; +};