| Message ID | 20171213084636.13184-1-a.heider@gmail.com |
|---|---|
| State | Superseded |
| Delegated to: | Jagannadha Sutradharudu Teki |
| Headers | show |
| Series | [U-Boot] sunxi: imply CONFIG_OF_LIBFDT_OVERLAY | expand |
On Wed, Dec 13, 2017 at 09:46:36AM +0100, Andre Heider wrote: > fdt overlay support is useful for all sunxi boards, enable per default > and remove it from sunxi defconfigs. > > Signed-off-by: Andre Heider <a.heider@gmail.com> Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com> Thanks! Maxime
On Wed, Dec 13, 2017 at 2:16 PM, Andre Heider <a.heider@gmail.com> wrote: > fdt overlay support is useful for all sunxi boards, enable per default > and remove it from sunxi defconfigs. > > Signed-off-by: Andre Heider <a.heider@gmail.com> > --- > > Hi, > > there're way too many sunxi boards so I'm not 100% sure this is the best > approach... > > Are there boards where enabling this is definitely not desired? > > Thanks, > Andre > > arch/arm/Kconfig | 1 + > configs/CHIP_defconfig | 1 - > configs/CHIP_pro_defconfig | 1 - > 3 files changed, 1 insertion(+), 2 deletions(-) > > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig > index 73909952d0..25847b3aa1 100644 > --- a/arch/arm/Kconfig > +++ b/arch/arm/Kconfig > @@ -715,6 +715,7 @@ config ARCH_SUNXI > select USE_TINY_PRINTF > imply CMD_GPT > imply FAT_WRITE > + imply OF_LIBFDT_OVERLAY It's increasing u-boot.itb size to 512KB (which is 508K earlier) and in either case the size moves on env side where env start 0x88000 (504KB)
On Tue, Dec 19, 2017 at 05:12:00PM +0530, Jagan Teki wrote: > On Wed, Dec 13, 2017 at 2:16 PM, Andre Heider <a.heider@gmail.com> wrote: > > fdt overlay support is useful for all sunxi boards, enable per default > > and remove it from sunxi defconfigs. > > > > Signed-off-by: Andre Heider <a.heider@gmail.com> > > --- > > > > Hi, > > > > there're way too many sunxi boards so I'm not 100% sure this is the best > > approach... > > > > Are there boards where enabling this is definitely not desired? > > > > Thanks, > > Andre > > > > arch/arm/Kconfig | 1 + > > configs/CHIP_defconfig | 1 - > > configs/CHIP_pro_defconfig | 1 - > > 3 files changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig > > index 73909952d0..25847b3aa1 100644 > > --- a/arch/arm/Kconfig > > +++ b/arch/arm/Kconfig > > @@ -715,6 +715,7 @@ config ARCH_SUNXI > > select USE_TINY_PRINTF > > imply CMD_GPT > > imply FAT_WRITE > > + imply OF_LIBFDT_OVERLAY > > It's increasing u-boot.itb size to 512KB (which is 508K earlier) and > in either case the size moves on env side where env start 0x88000 > (504KB) Right, so maybe we can make that conditional to ARM? Maxime
On 19/12/17 13:51, Maxime Ripard wrote: > On Tue, Dec 19, 2017 at 05:12:00PM +0530, Jagan Teki wrote: >> On Wed, Dec 13, 2017 at 2:16 PM, Andre Heider <a.heider@gmail.com> wrote: >>> fdt overlay support is useful for all sunxi boards, enable per default >>> and remove it from sunxi defconfigs. >>> >>> Signed-off-by: Andre Heider <a.heider@gmail.com> >>> --- >>> >>> Hi, >>> >>> there're way too many sunxi boards so I'm not 100% sure this is the best >>> approach... >>> >>> Are there boards where enabling this is definitely not desired? >>> >>> Thanks, >>> Andre >>> >>> arch/arm/Kconfig | 1 + >>> configs/CHIP_defconfig | 1 - >>> configs/CHIP_pro_defconfig | 1 - >>> 3 files changed, 1 insertion(+), 2 deletions(-) >>> >>> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig >>> index 73909952d0..25847b3aa1 100644 >>> --- a/arch/arm/Kconfig >>> +++ b/arch/arm/Kconfig >>> @@ -715,6 +715,7 @@ config ARCH_SUNXI >>> select USE_TINY_PRINTF >>> imply CMD_GPT >>> imply FAT_WRITE >>> + imply OF_LIBFDT_OVERLAY >> >> It's increasing u-boot.itb size to 512KB (which is 508K earlier) and >> in either case the size moves on env side where env start 0x88000 >> (504KB) > > Right, so maybe we can make that conditional to ARM? > > Maxime > From the 'we're out of space' thread: ... > So, with FIT_ENABLE_SHA256_SUPPORT, LZMADEC, ISO_PARTITION and the > overlay support, we're at 500kB. > > Again, tight, but under the limit. ... If I understood correctly the issue will be solved without any requiring changes to this patch. Let me know if that is not the case. Thanks, Andre
diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig index 73909952d0..25847b3aa1 100644 --- a/arch/arm/Kconfig +++ b/arch/arm/Kconfig @@ -715,6 +715,7 @@ config ARCH_SUNXI select USE_TINY_PRINTF imply CMD_GPT imply FAT_WRITE + imply OF_LIBFDT_OVERLAY imply PRE_CONSOLE_BUFFER imply SPL_GPIO_SUPPORT imply SPL_LIBCOMMON_SUPPORT diff --git a/configs/CHIP_defconfig b/configs/CHIP_defconfig index d057bee172..8b38ba450e 100644 --- a/configs/CHIP_defconfig +++ b/configs/CHIP_defconfig @@ -21,4 +21,3 @@ CONFIG_AXP_ALDO4_VOLT=3300 CONFIG_USB_EHCI_HCD=y CONFIG_USB_MUSB_GADGET=y CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y -CONFIG_OF_LIBFDT_OVERLAY=y diff --git a/configs/CHIP_pro_defconfig b/configs/CHIP_pro_defconfig index fa572eac57..089152e9ff 100644 --- a/configs/CHIP_pro_defconfig +++ b/configs/CHIP_pro_defconfig @@ -26,4 +26,3 @@ CONFIG_AXP_ALDO4_VOLT=3300 CONFIG_USB_EHCI_HCD=y CONFIG_USB_MUSB_GADGET=y CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y -CONFIG_OF_LIBFDT_OVERLAY=y
fdt overlay support is useful for all sunxi boards, enable per default and remove it from sunxi defconfigs. Signed-off-by: Andre Heider <a.heider@gmail.com> --- Hi, there're way too many sunxi boards so I'm not 100% sure this is the best approach... Are there boards where enabling this is definitely not desired? Thanks, Andre arch/arm/Kconfig | 1 + configs/CHIP_defconfig | 1 - configs/CHIP_pro_defconfig | 1 - 3 files changed, 1 insertion(+), 2 deletions(-)