diff mbox series

[U-Boot,1/4] i2c: meson: improve Kconfig description

Message ID 20171126164057.27728-2-b.galvani@gmail.com
State Accepted
Commit 4ecbb8b67855e50b326a1fcc4ddcd66d2e408084
Delegated to: Heiko Schocher
Headers show
Series meson i2c driver cleanups | expand

Commit Message

Beniamino Galvani Nov. 26, 2017, 4:40 p.m. UTC
Expand the Kconfig description with hardware features.

Signed-off-by: Beniamino Galvani <b.galvani@gmail.com>
---
 drivers/i2c/Kconfig | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

Comments

Simon Glass Nov. 27, 2017, 5:09 p.m. UTC | #1
On 26 November 2017 at 09:40, Beniamino Galvani <b.galvani@gmail.com> wrote:
> Expand the Kconfig description with hardware features.
>
> Signed-off-by: Beniamino Galvani <b.galvani@gmail.com>
> ---
>  drivers/i2c/Kconfig | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/Kconfig b/drivers/i2c/Kconfig
> index 1989f8eb57..a7931aa6d4 100644
> --- a/drivers/i2c/Kconfig
> +++ b/drivers/i2c/Kconfig
> @@ -141,7 +141,12 @@ config SYS_I2C_MESON
>         bool "Amlogic Meson I2C driver"
>         depends on DM_I2C && ARCH_MESON
>         help
> -         Add support for the Amlogic Meson I2C driver.
> +         Add support for the I2C controller available in Amlogic Meson
> +         SoCs. The controller supports programmable bus speed including
> +         standard (100kbits/s) and fast (400kbit/s) speed and allows the
> +         software to define a flexible format of the bit streams. It has an
> +         internal buffer holding up to 8 bytes for transfers and supports
> +         both 7-bit and 10-bit addresses.
>
>  config SYS_I2C_MXC
>         bool "NXP i.MX I2C driver"
> --
> 2.14.3
>

Great!

Reviewed-by: Simon Glass <sjg@chromium.org>
Heiko Schocher Dec. 7, 2017, 8:24 a.m. UTC | #2
Hello Baniamino,

Am 26.11.2017 um 17:40 schrieb Beniamino Galvani:
> Expand the Kconfig description with hardware features.
> 
> Signed-off-by: Beniamino Galvani <b.galvani@gmail.com>
> ---
>   drivers/i2c/Kconfig | 7 ++++++-
>   1 file changed, 6 insertions(+), 1 deletion(-)

Thanks!

Reviewed-by: Heiko Schocher <hs@denx.de>

bye,
Heiko
--
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52   Fax: +49-8142-66989-80   Email: hs@denx.de
Heiko Schocher Dec. 7, 2017, 12:19 p.m. UTC | #3
Hello Beniamino,

Am 26.11.2017 um 17:40 schrieb Beniamino Galvani:
> Expand the Kconfig description with hardware features.
> 
> Signed-off-by: Beniamino Galvani <b.galvani@gmail.com>
> ---
>   drivers/i2c/Kconfig | 7 ++++++-
>   1 file changed, 6 insertions(+), 1 deletion(-)

Applied to u-boot-i2c master

Thanks!

bye,
Heiko
diff mbox series

Patch

diff --git a/drivers/i2c/Kconfig b/drivers/i2c/Kconfig
index 1989f8eb57..a7931aa6d4 100644
--- a/drivers/i2c/Kconfig
+++ b/drivers/i2c/Kconfig
@@ -141,7 +141,12 @@  config SYS_I2C_MESON
 	bool "Amlogic Meson I2C driver"
 	depends on DM_I2C && ARCH_MESON
 	help
-	  Add support for the Amlogic Meson I2C driver.
+	  Add support for the I2C controller available in Amlogic Meson
+	  SoCs. The controller supports programmable bus speed including
+	  standard (100kbits/s) and fast (400kbit/s) speed and allows the
+	  software to define a flexible format of the bit streams. It has an
+	  internal buffer holding up to 8 bytes for transfers and supports
+	  both 7-bit and 10-bit addresses.
 
 config SYS_I2C_MXC
 	bool "NXP i.MX I2C driver"