| Message ID | 1512557817-431-1-git-send-email-angelo@amarulasolutions.com |
|---|---|
| Headers | show |
| Series | New infrastructure for golang packages | expand |
Hi Angelo, I unfortunately probably won't have time to look at your patches tonight, however: On 06-12-17 11:56, Angelo Compagnucci wrote: > This series add a new pkg-golang infrastructure and converts some of the > packages based on go. > I'll resend as an official patch series after receiving some comments in > RFC trying to reignite the discussion. Is there any difference with v5? There doesn't seem to be a patch revision log in any of the patches... Regards, Arnout > > Angelo Compagnucci (5): > package/pkg-golang: new package infrastructure > docs/manual: adding documentation for the golang infrastructure > package/flannel: converting to golang infrastructure > package/runc: converting to golang infrastructure > package/docker-containerd: converting to golang infrastructure > > docs/manual/adding-packages-golang.txt | 114 +++++++++++++++++++++++ > docs/manual/adding-packages.txt | 2 + > package/Makefile.in | 1 + > package/docker-containerd/docker-containerd.mk | 37 +++----- > package/flannel/flannel.mk | 32 +------ > package/pkg-golang.mk | 121 +++++++++++++++++++++++++ > package/runc/runc.mk | 37 +------- > 7 files changed, 262 insertions(+), 82 deletions(-) > create mode 100644 docs/manual/adding-packages-golang.txt > create mode 100644 package/pkg-golang.mk >
Dear Arnout, Il 06 dic 2017 10:39 PM, "Arnout Vandecappelle" <arnout@mind.be> ha scritto: Hi Angelo, I unfortunately probably won't have time to look at your patches tonight, however: On 06-12-17 11:56, Angelo Compagnucci wrote: > This series add a new pkg-golang infrastructure and converts some of the > packages based on go. > I'll resend as an official patch series after receiving some comments in > RFC trying to reignite the discussion. Is there any difference with v5? No differences, I just sent this patch series as anon RFC cause I think it's in shape to be accepted. There doesn't seem to be a patch revision log in any of the patches... Right, not good. I'll do in this series if needed. Thanks! Regards, Arnout > > Angelo Compagnucci (5): > package/pkg-golang: new package infrastructure > docs/manual: adding documentation for the golang infrastructure > package/flannel: converting to golang infrastructure > package/runc: converting to golang infrastructure > package/docker-containerd: converting to golang infrastructure > > docs/manual/adding-packages-golang.txt | 114 +++++++++++++++++++++++ > docs/manual/adding-packages.txt | 2 + > package/Makefile.in | 1 + > package/docker-containerd/docker-containerd.mk | 37 +++----- > package/flannel/flannel.mk | 32 +------ > package/pkg-golang.mk | 121 +++++++++++++++++++++++++ > package/runc/runc.mk | 37 +------- > 7 files changed, 262 insertions(+), 82 deletions(-) > create mode 100644 docs/manual/adding-packages-golang.txt > create mode 100644 package/pkg-golang.mk > -- Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF <div dir="auto"><div>Dear Arnout,<br><div class="gmail_extra"><br><div class="gmail_quote">Il 06 dic 2017 10:39 PM, "Arnout Vandecappelle" <<a href="mailto:arnout@mind.be">arnout@mind.be</a>> ha scritto:<br type="attribution"><blockquote class="quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> Hi Angelo,<br> <br> I unfortunately probably won't have time to look at your patches tonight, however:<br> <div class="quoted-text"><br> On 06-12-17 11:56, Angelo Compagnucci wrote:<br> > This series add a new pkg-golang infrastructure and converts some of the<br> > packages based on go.<br> > I'll resend as an official patch series after receiving some comments in<br> > RFC trying to reignite the discussion.<br> <br> </div> Is there any difference with v5?</blockquote></div></div></div><div dir="auto"><br></div><div dir="auto">No differences, I just sent this patch series as anon RFC cause I think it's in shape to be accepted.</div><div dir="auto"><br></div><div dir="auto"><div class="gmail_extra"><div class="gmail_quote"><blockquote class="quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> There doesn't seem to be a patch revision log<br> in any of the patches...<br></blockquote></div></div></div><div dir="auto"><br></div><div dir="auto">Right, not good. I'll do in this series if needed.</div><div dir="auto"><br></div><div dir="auto">Thanks!</div><div dir="auto"><br></div><div dir="auto"><div class="gmail_extra"><div class="gmail_quote"><blockquote class="quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> <br> Regards,<br> Arnout<br> <div class="quoted-text"><br> ><br> > Angelo Compagnucci (5):<br> > package/pkg-golang: new package infrastructure<br> > docs/manual: adding documentation for the golang infrastructure<br> > package/flannel: converting to golang infrastructure<br> > package/runc: converting to golang infrastructure<br> > package/docker-containerd: converting to golang infrastructure<br> ><br> > docs/manual/adding-packages-<wbr>golang.txt | 114 +++++++++++++++++++++++<br> > docs/manual/adding-packages.<wbr>txt | 2 +<br> > package/Makefile.in | 1 +<br> > package/docker-containerd/<a href="http://docker-containerd.mk" rel="noreferrer" target="_blank">dock<wbr>er-containerd.mk</a> | 37 +++-----<br> > package/flannel/<a href="http://flannel.mk" rel="noreferrer" target="_blank">flannel.mk</a> | 32 +------<br> > package/<a href="http://pkg-golang.mk" rel="noreferrer" target="_blank">pkg-golang.mk</a> | 121 +++++++++++++++++++++++++<br> > package/runc/<a href="http://runc.mk" rel="noreferrer" target="_blank">runc.mk</a> | 37 +-------<br> > 7 files changed, 262 insertions(+), 82 deletions(-)<br> > create mode 100644 docs/manual/adding-packages-<wbr>golang.txt<br> > create mode 100644 package/<a href="http://pkg-golang.mk" rel="noreferrer" target="_blank">pkg-golang.mk</a><br> ><br> <br> --<br> </div>Arnout Vandecappelle arnout at mind be<br> Senior Embedded Software Architect <a href="tel:%2B32-16-286500" value="+3216286500">+32-16-286500</a><br> Essensium/Mind <a href="http://www.mind.be" rel="noreferrer" target="_blank">http://www.mind.be</a><br> G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven<br> LinkedIn profile: <a href="http://www.linkedin.com/in/arnoutvandecappelle" rel="noreferrer" target="_blank">http://www.linkedin.com/in/<wbr>arnoutvandecappelle</a><br> GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF<br> </blockquote></div><br></div></div></div>
On 06-12-17 22:59, Angelo Compagnucci wrote: > There doesn't seem to be a patch revision log > in any of the patches... > > > Right, not good. I'll do in this series if needed. Don't bother - it's generally pretty difficult to reconstruct history after the fact. Just do it for your future submissions. Regards, Arnout