Message ID | 1511785716-23492-1-git-send-email-narmstrong@baylibre.com |
---|---|
Headers | show |
Series | ARM: Add Variscite DART-MX6 SoM and Carrier-board support | expand |
On Mon, Nov 27, 2017 at 10:28 AM, Neil Armstrong <narmstrong@baylibre.com> wrote: > +&pcie { > + fsl,tx-swing-full = <103>; > + fsl,tx-swing-low = <103>; > + reset-gpio = <&gpio4 11 GPIO_ACTIVE_HIGH>; This can only be active high if 'reset-gpio-active-high' property is present, so what you want here is: reset-gpio = <&gpio4 11 GPIO_ACTIVE_LOW>; With this fixed: Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>
On Mon, Nov 27, 2017 at 10:28 AM, Neil Armstrong <narmstrong@baylibre.com> wrote: > This patch adds support for the i.MX6 Quad variant of the Variscite DART-MX6 > SoM Carrier-Board. > > This Carrier-Board has the following : > - LVDS interface for the VLCD-CAP-GLD-LVDS 7" LCD 800 x 480 touch display > - HDMI Connector > - USB Host + USB OTG Connector > - 10/100/1000 Mbps Ethernet > - miniPCI-Express slot > - SD Card connector > - Audio Headphone/Line In jack connectors > - On-board DMIC > - CAN bus header > - SPI header > - Camera Interfaces header > - 4xButtons, 2xLeds > - OnBoard RTC with Coin Backup battery socket > - RS232 Header + USB-Serial debug port > > Product Page : http://www.variscite.com/products/evaluation-kits/dart-mx6-kits > > The board support is done with all on-board and header interfaces enabled. > 7" LVDS Touchscreen is enabled by default along HDMI output. > Audio interface is supported with the "simple-card" bindings. > > PCIe slot, On-Board DMIC and Camera Interfaces are not handled yet. > > Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>
On 27/11/2017 13:57, Fabio Estevam wrote: > On Mon, Nov 27, 2017 at 10:28 AM, Neil Armstrong > <narmstrong@baylibre.com> wrote: > >> +&pcie { >> + fsl,tx-swing-full = <103>; >> + fsl,tx-swing-low = <103>; >> + reset-gpio = <&gpio4 11 GPIO_ACTIVE_HIGH>; > > This can only be active high if 'reset-gpio-active-high' property is > present, so what you > want here is: > reset-gpio = <&gpio4 11 GPIO_ACTIVE_LOW>; > > With this fixed: > > Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com> > Ok, I will post a v4 lately with this fixed. Thanks, Neil