| Message ID | a059abdd-e727-adcb-7b43-976be1d0a08e@virtuozzo.com |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
| Series | exit_net checks for objects initialized in net_init hook | expand |
I'm assuming you want me to apply this (and the following lockd patch), but I'm not clear why this is part of a bigger series going to netdev. --b. On Mon, Nov 06, 2017 at 04:22:48PM +0300, Vasily Averin wrote: > Signed-off-by: Vasily Averin <vvs@virtuozzo.com> > --- > fs/nfs_common/grace.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/fs/nfs_common/grace.c b/fs/nfs_common/grace.c > index 420d3a0..1bd6599 100644 > --- a/fs/nfs_common/grace.c > +++ b/fs/nfs_common/grace.c > @@ -104,7 +104,9 @@ grace_exit_net(struct net *net) > { > struct list_head *grace_list = net_generic(net, grace_net_id); > > - BUG_ON(!list_empty(grace_list)); > + WARN_ONCE(!list_empty(grace_list), > + "net %x %s: grace_list is not empty\n", > + net->ns.inum, __func__); > } > > static struct pernet_operations grace_net_ops = { > -- > 2.7.4 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-nfs" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
Applied for 4.15, thanks.--b. On Mon, Nov 06, 2017 at 04:22:48PM +0300, Vasily Averin wrote: > Signed-off-by: Vasily Averin <vvs@virtuozzo.com> > --- > fs/nfs_common/grace.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/fs/nfs_common/grace.c b/fs/nfs_common/grace.c > index 420d3a0..1bd6599 100644 > --- a/fs/nfs_common/grace.c > +++ b/fs/nfs_common/grace.c > @@ -104,7 +104,9 @@ grace_exit_net(struct net *net) > { > struct list_head *grace_list = net_generic(net, grace_net_id); > > - BUG_ON(!list_empty(grace_list)); > + WARN_ONCE(!list_empty(grace_list), > + "net %x %s: grace_list is not empty\n", > + net->ns.inum, __func__); > } > > static struct pernet_operations grace_net_ops = { > -- > 2.7.4
diff --git a/fs/nfs_common/grace.c b/fs/nfs_common/grace.c index 420d3a0..1bd6599 100644 --- a/fs/nfs_common/grace.c +++ b/fs/nfs_common/grace.c @@ -104,7 +104,9 @@ grace_exit_net(struct net *net) { struct list_head *grace_list = net_generic(net, grace_net_id); - BUG_ON(!list_empty(grace_list)); + WARN_ONCE(!list_empty(grace_list), + "net %x %s: grace_list is not empty\n", + net->ns.inum, __func__); } static struct pernet_operations grace_net_ops = {
Signed-off-by: Vasily Averin <vvs@virtuozzo.com> --- fs/nfs_common/grace.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)