| Message ID | alpine.DEB.2.20.1711051812510.5655@stedding.saclay.inria.fr |
|---|---|
| State | New |
| Headers | show |
| Series | Update comment in tree-vrp.h | expand |
On Sun, Nov 5, 2017 at 7:15 PM, Marc Glisse <marc.glisse@inria.fr> wrote: > Hello, > > looking at the history, it seems that this comment should be updated as in > the following patch (the definition of struct value_range is right below and > explains VR_RANGE and VR_ANTI_RANGE). I am not committing this as obvious > because the text below does *not* actually describe VR_VARYING or > VR_UNDEFINED, and while I know what VR_VARYING means, I am still confused by > VR_UNDEFINED, so cannot write that comment myself. Patch is ok anyway. I think VR_UNDEFINED maps to "uninitialized" in C terms. The corresponding CCP lattice doesn't have a too precise definition either (and also includes UNINITIALIZED...) Richard. > --- tree-vrp.h (revision 254429) > +++ tree-vrp.h (working copy) > @@ -20,7 +20,7 @@ along with GCC; see the file COPYING3. > #ifndef GCC_TREE_VRP_H > #define GCC_TREE_VRP_H > > -/* Type of value ranges. See value_range_d In tree-vrp.c for a > +/* Type of value ranges. See value_range below for a > description of these types. */ > enum value_range_type { VR_UNDEFINED, VR_RANGE, > VR_ANTI_RANGE, VR_VARYING, VR_LAST }; > > > 2017-11-06 Marc Glisse <marc.glisse@inria.fr> > > * tree-vrp.h (enum value_range_type): Update stale comment. > > -- > Marc Glisse
--- tree-vrp.h (revision 254429) +++ tree-vrp.h (working copy) @@ -20,7 +20,7 @@ along with GCC; see the file COPYING3. #ifndef GCC_TREE_VRP_H #define GCC_TREE_VRP_H -/* Type of value ranges. See value_range_d In tree-vrp.c for a +/* Type of value ranges. See value_range below for a description of these types. */ enum value_range_type { VR_UNDEFINED, VR_RANGE, VR_ANTI_RANGE, VR_VARYING, VR_LAST };
Hello, looking at the history, it seems that this comment should be updated as in the following patch (the definition of struct value_range is right below and explains VR_RANGE and VR_ANTI_RANGE). I am not committing this as obvious because the text below does *not* actually describe VR_VARYING or VR_UNDEFINED, and while I know what VR_VARYING means, I am still confused by VR_UNDEFINED, so cannot write that comment myself. 2017-11-06 Marc Glisse <marc.glisse@inria.fr> * tree-vrp.h (enum value_range_type): Update stale comment.