diff mbox series

[kteam-tools] verify-release-ready: add azure-edge kernel support

Message ID 1508267033-5576-1-git-send-email-marcelo.cerri@canonical.com
State New
Headers show
Series [kteam-tools] verify-release-ready: add azure-edge kernel support | expand

Commit Message

Marcelo Henrique Cerri Oct. 17, 2017, 7:03 p.m. UTC
Signed-off-by: Marcelo Henrique Cerri <marcelo.cerri@canonical.com>
---
 ktl/kernel-series-info.yaml       | 6 ++++++
 ktl/kernel-source-repos.yaml      | 2 ++
 maintscripts/verify-release-ready | 2 ++
 3 files changed, 10 insertions(+)

Comments

Po-Hsu Lin Oct. 18, 2017, 3:28 a.m. UTC | #1
On Wed, Oct 18, 2017 at 3:03 AM, Marcelo Henrique Cerri
<marcelo.cerri@canonical.com> wrote:
> Signed-off-by: Marcelo Henrique Cerri <marcelo.cerri@canonical.com>
> ---
>  ktl/kernel-series-info.yaml       | 6 ++++++
>  ktl/kernel-source-repos.yaml      | 2 ++
>  maintscripts/verify-release-ready | 2 ++
>  3 files changed, 10 insertions(+)
>
> diff --git a/ktl/kernel-series-info.yaml b/ktl/kernel-series-info.yaml
> index 58be3026590c..1a28456a6f96 100644
> --- a/ktl/kernel-series-info.yaml
> +++ b/ktl/kernel-series-info.yaml
> @@ -203,6 +203,9 @@
>              linux-azure:
>              - linux
>              - '17.10'
> +            linux-azure-edge:
> +            - linux
> +            - '17.10'
>              linux-gcp:
>              - linux
>              - '17.04'
> @@ -221,6 +224,8 @@
>                  meta: linux-meta-gke
>              linux-azure:
>                  meta: linux-meta-azure
> +            linux-azure-edge:
> +                meta: linux-meta-azure-edge
>              linux-joule:
>                  meta: linux-meta-joule
>              linux-hwe:
> @@ -277,6 +282,7 @@
>          - linux-meta-snapdragon
>          - linux-aws
>          - linux-azure
> +        - linux-azure-edge
>          - linux-gke
>          - linux-meta-aws
>          - linux-meta-azure
> diff --git a/ktl/kernel-source-repos.yaml b/ktl/kernel-source-repos.yaml
> index ea86133f8d84..7c7acd15cf14 100644
> --- a/ktl/kernel-source-repos.yaml
> +++ b/ktl/kernel-source-repos.yaml
> @@ -3,6 +3,8 @@
>      linux-meta-aws:        https://code.launchpad.net/~canonical-kernel/ubuntu/+source/linux-meta-aws/+git/linux-aws
>      linux-azure:           https://code.launchpad.net/~canonical-kernel/ubuntu/+source/linux-aws/+git/linux-azure
>      linux-meta-azure:      https://code.launchpad.net/~canonical-kernel/ubuntu/+source/linux-meta-aws/+git/linux-azure
> +    linux-azure-edge:      https://code.launchpad.net/~canonical-kernel/ubuntu/+source/linux-aws/+git/linux-azure
> +    linux-meta-azure-edge: https://code.launchpad.net/~canonical-kernel/ubuntu/+source/linux-meta-aws/+git/linux-azure
I'm curious about these links, some of them are not reachable.
And for the linux-azure, why it's under the linux-aws tree but not the
linux-azure?
https://code.launchpad.net/~canonical-kernel/ubuntu/+source/linux-azure/+git/linux-azure

>      linux:                 https://code.launchpad.net/~ubuntu-kernel/ubuntu/+source/linux/+git/xenial
>      linux:                 https://code.launchpad.net/~ubuntu-kernel/ubuntu/+source/linux/+git/xenial
>      linux-meta:            https://code.launchpad.net/~ubuntu-kernel/ubuntu/+source/linux-meta/+git/xenial
> diff --git a/maintscripts/verify-release-ready b/maintscripts/verify-release-ready
> index 2f19aa2db82d..8530b44c0623 100755
> --- a/maintscripts/verify-release-ready
> +++ b/maintscripts/verify-release-ready
> @@ -515,6 +515,7 @@ class VerifyReleaseReady():
>              'linux-hwe-edge',
>              'linux-joule',
>              'linux-azure',
> +            'linux-azure-edge',
>              'linux-gcp',
>              'linux-gke',
>              'linux-kvm'
> @@ -540,6 +541,7 @@ class VerifyReleaseReady():
>              'linux-meta-hwe-edge',
>              'linux-meta-joule',
>              'linux-meta-azure',
> +            'linux-meta-azure-edge',
>              'linux-meta-gcp',
>              'linux-meta-gke',
>              'linux-meta-kvm',
> --
> 2.7.4
>
>
> --
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team
Kleber Sacilotto de Souza Oct. 18, 2017, 7:32 a.m. UTC | #2
On 10/17/17 21:03, Marcelo Henrique Cerri wrote:
> Signed-off-by: Marcelo Henrique Cerri <marcelo.cerri@canonical.com>
> ---
>  ktl/kernel-series-info.yaml       | 6 ++++++
>  ktl/kernel-source-repos.yaml      | 2 ++
>  maintscripts/verify-release-ready | 2 ++
>  3 files changed, 10 insertions(+)

I would split this patch in at least 2. The subject says
'verify-release-ready', but changing the kernel-series-info.yaml file
can affect other parts of our tooling as well, so I would have a
separate patch for it.


Kleber

> 
> diff --git a/ktl/kernel-series-info.yaml b/ktl/kernel-series-info.yaml
> index 58be3026590c..1a28456a6f96 100644
> --- a/ktl/kernel-series-info.yaml
> +++ b/ktl/kernel-series-info.yaml
> @@ -203,6 +203,9 @@
>              linux-azure:
>              - linux
>              - '17.10'
> +            linux-azure-edge:
> +            - linux
> +            - '17.10'
>              linux-gcp:
>              - linux
>              - '17.04'
> @@ -221,6 +224,8 @@
>                  meta: linux-meta-gke
>              linux-azure:
>                  meta: linux-meta-azure
> +            linux-azure-edge:
> +                meta: linux-meta-azure-edge
>              linux-joule:
>                  meta: linux-meta-joule
>              linux-hwe:
> @@ -277,6 +282,7 @@
>          - linux-meta-snapdragon
>          - linux-aws
>          - linux-azure
> +        - linux-azure-edge
>          - linux-gke
>          - linux-meta-aws
>          - linux-meta-azure
> diff --git a/ktl/kernel-source-repos.yaml b/ktl/kernel-source-repos.yaml
> index ea86133f8d84..7c7acd15cf14 100644
> --- a/ktl/kernel-source-repos.yaml
> +++ b/ktl/kernel-source-repos.yaml
> @@ -3,6 +3,8 @@
>      linux-meta-aws:        https://code.launchpad.net/~canonical-kernel/ubuntu/+source/linux-meta-aws/+git/linux-aws
>      linux-azure:           https://code.launchpad.net/~canonical-kernel/ubuntu/+source/linux-aws/+git/linux-azure
>      linux-meta-azure:      https://code.launchpad.net/~canonical-kernel/ubuntu/+source/linux-meta-aws/+git/linux-azure
> +    linux-azure-edge:      https://code.launchpad.net/~canonical-kernel/ubuntu/+source/linux-aws/+git/linux-azure
> +    linux-meta-azure-edge: https://code.launchpad.net/~canonical-kernel/ubuntu/+source/linux-meta-aws/+git/linux-azure
>      linux:                 https://code.launchpad.net/~ubuntu-kernel/ubuntu/+source/linux/+git/xenial
>      linux:                 https://code.launchpad.net/~ubuntu-kernel/ubuntu/+source/linux/+git/xenial
>      linux-meta:            https://code.launchpad.net/~ubuntu-kernel/ubuntu/+source/linux-meta/+git/xenial
> diff --git a/maintscripts/verify-release-ready b/maintscripts/verify-release-ready
> index 2f19aa2db82d..8530b44c0623 100755
> --- a/maintscripts/verify-release-ready
> +++ b/maintscripts/verify-release-ready
> @@ -515,6 +515,7 @@ class VerifyReleaseReady():
>              'linux-hwe-edge',
>              'linux-joule',
>              'linux-azure',
> +            'linux-azure-edge',
>              'linux-gcp',
>              'linux-gke',
>              'linux-kvm'
> @@ -540,6 +541,7 @@ class VerifyReleaseReady():
>              'linux-meta-hwe-edge',
>              'linux-meta-joule',
>              'linux-meta-azure',
> +            'linux-meta-azure-edge',
>              'linux-meta-gcp',
>              'linux-meta-gke',
>              'linux-meta-kvm',
>
Marcelo Henrique Cerri Oct. 18, 2017, 11:28 a.m. UTC | #3
On Wed, Oct 18, 2017 at 11:28:41AM +0800, Po-Hsu Lin (Sam) wrote:
> On Wed, Oct 18, 2017 at 3:03 AM, Marcelo Henrique Cerri
> <marcelo.cerri@canonical.com> wrote:
> > Signed-off-by: Marcelo Henrique Cerri <marcelo.cerri@canonical.com>
> > ---
> >  ktl/kernel-series-info.yaml       | 6 ++++++
> >  ktl/kernel-source-repos.yaml      | 2 ++
> >  maintscripts/verify-release-ready | 2 ++
> >  3 files changed, 10 insertions(+)
> >
> > diff --git a/ktl/kernel-series-info.yaml b/ktl/kernel-series-info.yaml
> > index 58be3026590c..1a28456a6f96 100644
> > --- a/ktl/kernel-series-info.yaml
> > +++ b/ktl/kernel-series-info.yaml
> > @@ -203,6 +203,9 @@
> >              linux-azure:
> >              - linux
> >              - '17.10'
> > +            linux-azure-edge:
> > +            - linux
> > +            - '17.10'
> >              linux-gcp:
> >              - linux
> >              - '17.04'
> > @@ -221,6 +224,8 @@
> >                  meta: linux-meta-gke
> >              linux-azure:
> >                  meta: linux-meta-azure
> > +            linux-azure-edge:
> > +                meta: linux-meta-azure-edge
> >              linux-joule:
> >                  meta: linux-meta-joule
> >              linux-hwe:
> > @@ -277,6 +282,7 @@
> >          - linux-meta-snapdragon
> >          - linux-aws
> >          - linux-azure
> > +        - linux-azure-edge
> >          - linux-gke
> >          - linux-meta-aws
> >          - linux-meta-azure
> > diff --git a/ktl/kernel-source-repos.yaml b/ktl/kernel-source-repos.yaml
> > index ea86133f8d84..7c7acd15cf14 100644
> > --- a/ktl/kernel-source-repos.yaml
> > +++ b/ktl/kernel-source-repos.yaml
> > @@ -3,6 +3,8 @@
> >      linux-meta-aws:        https://code.launchpad.net/~canonical-kernel/ubuntu/+source/linux-meta-aws/+git/linux-aws
> >      linux-azure:           https://code.launchpad.net/~canonical-kernel/ubuntu/+source/linux-aws/+git/linux-azure
> >      linux-meta-azure:      https://code.launchpad.net/~canonical-kernel/ubuntu/+source/linux-meta-aws/+git/linux-azure
> > +    linux-azure-edge:      https://code.launchpad.net/~canonical-kernel/ubuntu/+source/linux-aws/+git/linux-azure
> > +    linux-meta-azure-edge: https://code.launchpad.net/~canonical-kernel/ubuntu/+source/linux-meta-aws/+git/linux-azure
> I'm curious about these links, some of them are not reachable.
> And for the linux-azure, why it's under the linux-aws tree but not the
> linux-azure?
> https://code.launchpad.net/~canonical-kernel/ubuntu/+source/linux-azure/+git/linux-azure

Now I'm curious too. I simply replicated all the linux-azure occurrences
for linux-azure-edge. But the link for linux-azure is clearly wrong and
that file doesn't seem to used anywhere.

I will ask Brad and Kleber about that file.

> 
> >      linux:                 https://code.launchpad.net/~ubuntu-kernel/ubuntu/+source/linux/+git/xenial
> >      linux:                 https://code.launchpad.net/~ubuntu-kernel/ubuntu/+source/linux/+git/xenial
> >      linux-meta:            https://code.launchpad.net/~ubuntu-kernel/ubuntu/+source/linux-meta/+git/xenial
> > diff --git a/maintscripts/verify-release-ready b/maintscripts/verify-release-ready
> > index 2f19aa2db82d..8530b44c0623 100755
> > --- a/maintscripts/verify-release-ready
> > +++ b/maintscripts/verify-release-ready
> > @@ -515,6 +515,7 @@ class VerifyReleaseReady():
> >              'linux-hwe-edge',
> >              'linux-joule',
> >              'linux-azure',
> > +            'linux-azure-edge',
> >              'linux-gcp',
> >              'linux-gke',
> >              'linux-kvm'
> > @@ -540,6 +541,7 @@ class VerifyReleaseReady():
> >              'linux-meta-hwe-edge',
> >              'linux-meta-joule',
> >              'linux-meta-azure',
> > +            'linux-meta-azure-edge',
> >              'linux-meta-gcp',
> >              'linux-meta-gke',
> >              'linux-meta-kvm',
> > --
> > 2.7.4
> >
> >
> > --
> > kernel-team mailing list
> > kernel-team@lists.ubuntu.com
> > https://lists.ubuntu.com/mailman/listinfo/kernel-team
Marcelo Henrique Cerri Oct. 18, 2017, 11:30 a.m. UTC | #4
On Wed, Oct 18, 2017 at 09:32:11AM +0200, Kleber Souza wrote:
> On 10/17/17 21:03, Marcelo Henrique Cerri wrote:
> > Signed-off-by: Marcelo Henrique Cerri <marcelo.cerri@canonical.com>
> > ---
> >  ktl/kernel-series-info.yaml       | 6 ++++++
> >  ktl/kernel-source-repos.yaml      | 2 ++
> >  maintscripts/verify-release-ready | 2 ++
> >  3 files changed, 10 insertions(+)
> 
> I would split this patch in at least 2. The subject says
> 'verify-release-ready', but changing the kernel-series-info.yaml file
> can affect other parts of our tooling as well, so I would have a
> separate patch for it.

No problem. I can split it.

> 
> 
> Kleber
> 
> > 
> > diff --git a/ktl/kernel-series-info.yaml b/ktl/kernel-series-info.yaml
> > index 58be3026590c..1a28456a6f96 100644
> > --- a/ktl/kernel-series-info.yaml
> > +++ b/ktl/kernel-series-info.yaml
> > @@ -203,6 +203,9 @@
> >              linux-azure:
> >              - linux
> >              - '17.10'
> > +            linux-azure-edge:
> > +            - linux
> > +            - '17.10'
> >              linux-gcp:
> >              - linux
> >              - '17.04'
> > @@ -221,6 +224,8 @@
> >                  meta: linux-meta-gke
> >              linux-azure:
> >                  meta: linux-meta-azure
> > +            linux-azure-edge:
> > +                meta: linux-meta-azure-edge
> >              linux-joule:
> >                  meta: linux-meta-joule
> >              linux-hwe:
> > @@ -277,6 +282,7 @@
> >          - linux-meta-snapdragon
> >          - linux-aws
> >          - linux-azure
> > +        - linux-azure-edge
> >          - linux-gke
> >          - linux-meta-aws
> >          - linux-meta-azure
> > diff --git a/ktl/kernel-source-repos.yaml b/ktl/kernel-source-repos.yaml
> > index ea86133f8d84..7c7acd15cf14 100644
> > --- a/ktl/kernel-source-repos.yaml
> > +++ b/ktl/kernel-source-repos.yaml
> > @@ -3,6 +3,8 @@
> >      linux-meta-aws:        https://code.launchpad.net/~canonical-kernel/ubuntu/+source/linux-meta-aws/+git/linux-aws
> >      linux-azure:           https://code.launchpad.net/~canonical-kernel/ubuntu/+source/linux-aws/+git/linux-azure
> >      linux-meta-azure:      https://code.launchpad.net/~canonical-kernel/ubuntu/+source/linux-meta-aws/+git/linux-azure
> > +    linux-azure-edge:      https://code.launchpad.net/~canonical-kernel/ubuntu/+source/linux-aws/+git/linux-azure
> > +    linux-meta-azure-edge: https://code.launchpad.net/~canonical-kernel/ubuntu/+source/linux-meta-aws/+git/linux-azure
> >      linux:                 https://code.launchpad.net/~ubuntu-kernel/ubuntu/+source/linux/+git/xenial
> >      linux:                 https://code.launchpad.net/~ubuntu-kernel/ubuntu/+source/linux/+git/xenial
> >      linux-meta:            https://code.launchpad.net/~ubuntu-kernel/ubuntu/+source/linux-meta/+git/xenial
> > diff --git a/maintscripts/verify-release-ready b/maintscripts/verify-release-ready
> > index 2f19aa2db82d..8530b44c0623 100755
> > --- a/maintscripts/verify-release-ready
> > +++ b/maintscripts/verify-release-ready
> > @@ -515,6 +515,7 @@ class VerifyReleaseReady():
> >              'linux-hwe-edge',
> >              'linux-joule',
> >              'linux-azure',
> > +            'linux-azure-edge',
> >              'linux-gcp',
> >              'linux-gke',
> >              'linux-kvm'
> > @@ -540,6 +541,7 @@ class VerifyReleaseReady():
> >              'linux-meta-hwe-edge',
> >              'linux-meta-joule',
> >              'linux-meta-azure',
> > +            'linux-meta-azure-edge',
> >              'linux-meta-gcp',
> >              'linux-meta-gke',
> >              'linux-meta-kvm',
> >
Marcelo Henrique Cerri Oct. 18, 2017, 12:18 p.m. UTC | #5
I will submit a v2 with fixes and split.
diff mbox series

Patch

diff --git a/ktl/kernel-series-info.yaml b/ktl/kernel-series-info.yaml
index 58be3026590c..1a28456a6f96 100644
--- a/ktl/kernel-series-info.yaml
+++ b/ktl/kernel-series-info.yaml
@@ -203,6 +203,9 @@ 
             linux-azure:
             - linux
             - '17.10'
+            linux-azure-edge:
+            - linux
+            - '17.10'
             linux-gcp:
             - linux
             - '17.04'
@@ -221,6 +224,8 @@ 
                 meta: linux-meta-gke
             linux-azure:
                 meta: linux-meta-azure
+            linux-azure-edge:
+                meta: linux-meta-azure-edge
             linux-joule:
                 meta: linux-meta-joule
             linux-hwe:
@@ -277,6 +282,7 @@ 
         - linux-meta-snapdragon
         - linux-aws
         - linux-azure
+        - linux-azure-edge
         - linux-gke
         - linux-meta-aws
         - linux-meta-azure
diff --git a/ktl/kernel-source-repos.yaml b/ktl/kernel-source-repos.yaml
index ea86133f8d84..7c7acd15cf14 100644
--- a/ktl/kernel-source-repos.yaml
+++ b/ktl/kernel-source-repos.yaml
@@ -3,6 +3,8 @@ 
     linux-meta-aws:        https://code.launchpad.net/~canonical-kernel/ubuntu/+source/linux-meta-aws/+git/linux-aws
     linux-azure:           https://code.launchpad.net/~canonical-kernel/ubuntu/+source/linux-aws/+git/linux-azure
     linux-meta-azure:      https://code.launchpad.net/~canonical-kernel/ubuntu/+source/linux-meta-aws/+git/linux-azure
+    linux-azure-edge:      https://code.launchpad.net/~canonical-kernel/ubuntu/+source/linux-aws/+git/linux-azure
+    linux-meta-azure-edge: https://code.launchpad.net/~canonical-kernel/ubuntu/+source/linux-meta-aws/+git/linux-azure
     linux:                 https://code.launchpad.net/~ubuntu-kernel/ubuntu/+source/linux/+git/xenial
     linux:                 https://code.launchpad.net/~ubuntu-kernel/ubuntu/+source/linux/+git/xenial
     linux-meta:            https://code.launchpad.net/~ubuntu-kernel/ubuntu/+source/linux-meta/+git/xenial
diff --git a/maintscripts/verify-release-ready b/maintscripts/verify-release-ready
index 2f19aa2db82d..8530b44c0623 100755
--- a/maintscripts/verify-release-ready
+++ b/maintscripts/verify-release-ready
@@ -515,6 +515,7 @@  class VerifyReleaseReady():
             'linux-hwe-edge',
             'linux-joule',
             'linux-azure',
+            'linux-azure-edge',
             'linux-gcp',
             'linux-gke',
             'linux-kvm'
@@ -540,6 +541,7 @@  class VerifyReleaseReady():
             'linux-meta-hwe-edge',
             'linux-meta-joule',
             'linux-meta-azure',
+            'linux-meta-azure-edge',
             'linux-meta-gcp',
             'linux-meta-gke',
             'linux-meta-kvm',