| Message ID | 20170827080051.816-1-judge.packham@gmail.com |
|---|---|
| State | Deferred |
| Delegated to: | Masahiro Yamada |
| Headers | show |
| Series | [U-Boot] moveconfig: fix error message in do_autoconf() | expand |
+Tom On 27 August 2017 at 02:00, Chris Packham <judge.packham@gmail.com> wrote: > Move the % arch outside the double quote so that the missing toolchain > message is displayed correctly. > > Signed-off-by: Chris Packham <judge.packham@gmail.com> > --- > > tools/moveconfig.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Simon Glass <sjg@chromium.org>
2017-08-28 5:10 GMT+09:00 Simon Glass <sjg@chromium.org>: > +Tom > > On 27 August 2017 at 02:00, Chris Packham <judge.packham@gmail.com> wrote: >> Move the % arch outside the double quote so that the missing toolchain >> message is displayed correctly. >> >> Signed-off-by: Chris Packham <judge.packham@gmail.com> >> --- >> >> tools/moveconfig.py | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > > Reviewed-by: Simon Glass <sjg@chromium.org> > _______________________________________________ I have just noticed this patch had been delegated to me. Applied to u-boot-uniphier.
diff --git a/tools/moveconfig.py b/tools/moveconfig.py index 8a038501929c..45742dc2e6b9 100755 --- a/tools/moveconfig.py +++ b/tools/moveconfig.py @@ -1170,7 +1170,7 @@ class Slot: toolchain = self.toolchains.Select(arch) except ValueError: self.log += color_text(self.options.color, COLOR_YELLOW, - "Tool chain for '%s' is missing. Do nothing.\n % arch") + "Tool chain for '%s' is missing. Do nothing.\n" % arch) self.finish(False) return env = toolchain.MakeEnvironment(False)
Move the % arch outside the double quote so that the missing toolchain message is displayed correctly. Signed-off-by: Chris Packham <judge.packham@gmail.com> --- tools/moveconfig.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)