| Message ID | 20171004061323.18741-1-vaibhav@linux.vnet.ibm.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [v2] capp: Add lid definitions for P9 DD-2.0 & DD-2.1 | expand |
Le 04/10/2017 à 08:13, Vaibhav Jain a écrit : > Update fsp_lid_map to include CAPP ucode lids for phb4-chipid == > 0x200d1 and phb4-chipid == 0x201d1 that corresponds to P9 DD-2.0 & > DD-2.1 chips respectively. > > Signed-off-by: Vaibhav Jain <vaibhav@linux.vnet.ibm.com> > --- > Changelog: > > [v2] -> Updated the lid map to use same lid for DD-2.0 & DD-2.1 > chips > > --- Acked-by: Christophe Lombard<clombard@linux.vnet.ibm.com> Thanks
Le 04/10/2017 à 08:13, Vaibhav Jain a écrit : > Update fsp_lid_map to include CAPP ucode lids for phb4-chipid == > 0x200d1 and phb4-chipid == 0x201d1 that corresponds to P9 DD-2.0 & > DD-2.1 chips respectively. > > Signed-off-by: Vaibhav Jain <vaibhav@linux.vnet.ibm.com> > --- Looks ok to me. Reviewed-by: Frederic Barrat <fbarrat@linux.vnet.ibm.com> > Changelog: > > [v2] -> Updated the lid map to use same lid for DD-2.0 & DD-2.1 > chips > > --- > > hw/fsp/fsp.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/hw/fsp/fsp.c b/hw/fsp/fsp.c > index 4d173978..724c7f73 100644 > --- a/hw/fsp/fsp.c > +++ b/hw/fsp/fsp.c > @@ -2357,6 +2357,8 @@ int fsp_fetch_data_queue(uint8_t flags, uint16_t id, uint32_t sub_id, > #define CAPP_IDX_MURANO_DD21 0x201ef > #define CAPP_IDX_NAPLES_DD10 0x100d3 > #define CAPP_IDX_NIMBUS_DD10 0x100d1 > +#define CAPP_IDX_NIMBUS_DD20 0x200d1 > +#define CAPP_IDX_NIMBUS_DD21 0x201d1 > > static struct { > enum resource_id id; > @@ -2371,6 +2373,8 @@ static struct { > { RESOURCE_ID_CAPP, CAPP_IDX_VENICE_DD20, 0x80a02004 }, > { RESOURCE_ID_CAPP, CAPP_IDX_NAPLES_DD10, 0x80a02005 }, > { RESOURCE_ID_CAPP, CAPP_IDX_NIMBUS_DD10, 0x80a02006 }, > + { RESOURCE_ID_CAPP, CAPP_IDX_NIMBUS_DD20, 0x80a02007 }, > + { RESOURCE_ID_CAPP, CAPP_IDX_NIMBUS_DD21, 0x80a02007 }, > }; > > static void fsp_start_fetching_next_lid(void); >
Vaibhav Jain <vaibhav@linux.vnet.ibm.com> writes: > Update fsp_lid_map to include CAPP ucode lids for phb4-chipid == > 0x200d1 and phb4-chipid == 0x201d1 that corresponds to P9 DD-2.0 & > DD-2.1 chips respectively. > > Signed-off-by: Vaibhav Jain <vaibhav@linux.vnet.ibm.com> > --- > Changelog: > > [v2] -> Updated the lid map to use same lid for DD-2.0 & DD-2.1 > chips > > --- > > hw/fsp/fsp.c | 4 ++++ > 1 file changed, 4 insertions(+) Thanks. Merged as of 25e041a577616f80b7bf0553a50043e422f0296c
christophe lombard <clombard@linux.vnet.ibm.com> writes: > Le 04/10/2017 à 08:13, Vaibhav Jain a écrit : >> Update fsp_lid_map to include CAPP ucode lids for phb4-chipid == >> 0x200d1 and phb4-chipid == 0x201d1 that corresponds to P9 DD-2.0 & >> DD-2.1 chips respectively. >> >> Signed-off-by: Vaibhav Jain <vaibhav@linux.vnet.ibm.com> >> --- >> Changelog: >> >> [v2] -> Updated the lid map to use same lid for DD-2.0 & DD-2.1 >> chips >> >> --- > > Acked-by: Christophe Lombard<clombard@linux.vnet.ibm.com> Hrm.. you seem to have some weird formatting here that broke patchwork picking up the acked-by.
diff --git a/hw/fsp/fsp.c b/hw/fsp/fsp.c index 4d173978..724c7f73 100644 --- a/hw/fsp/fsp.c +++ b/hw/fsp/fsp.c @@ -2357,6 +2357,8 @@ int fsp_fetch_data_queue(uint8_t flags, uint16_t id, uint32_t sub_id, #define CAPP_IDX_MURANO_DD21 0x201ef #define CAPP_IDX_NAPLES_DD10 0x100d3 #define CAPP_IDX_NIMBUS_DD10 0x100d1 +#define CAPP_IDX_NIMBUS_DD20 0x200d1 +#define CAPP_IDX_NIMBUS_DD21 0x201d1 static struct { enum resource_id id; @@ -2371,6 +2373,8 @@ static struct { { RESOURCE_ID_CAPP, CAPP_IDX_VENICE_DD20, 0x80a02004 }, { RESOURCE_ID_CAPP, CAPP_IDX_NAPLES_DD10, 0x80a02005 }, { RESOURCE_ID_CAPP, CAPP_IDX_NIMBUS_DD10, 0x80a02006 }, + { RESOURCE_ID_CAPP, CAPP_IDX_NIMBUS_DD20, 0x80a02007 }, + { RESOURCE_ID_CAPP, CAPP_IDX_NIMBUS_DD21, 0x80a02007 }, }; static void fsp_start_fetching_next_lid(void);
Update fsp_lid_map to include CAPP ucode lids for phb4-chipid == 0x200d1 and phb4-chipid == 0x201d1 that corresponds to P9 DD-2.0 & DD-2.1 chips respectively. Signed-off-by: Vaibhav Jain <vaibhav@linux.vnet.ibm.com> --- Changelog: [v2] -> Updated the lid map to use same lid for DD-2.0 & DD-2.1 chips --- hw/fsp/fsp.c | 4 ++++ 1 file changed, 4 insertions(+)