Message ID | cover.1506678250.git.horms+renesas@verge.net.au |
---|---|
State | New |
Headers | show |
Series | [GIT,PULL] Renesas ARM64 Based SoC DT Updates for v4.15 | expand |
Hello! On 9/29/2017 2:52 PM, Simon Horman wrote: > From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > > This patch enables EthernetAVB for R-Car D3 draak board. > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > Signed-off-by: Simon Horman <horms+renesas@verge.net.au> > --- > arch/arm64/boot/dts/renesas/r8a77995-draak.dts | 25 +++++++++++++++++++++++++ > 1 file changed, 25 insertions(+) > > diff --git a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts > index 7b776cb7e928..96b7ff5cc321 100644 > --- a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts > +++ b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts [...] > @@ -37,6 +39,14 @@ > }; > > &pfc { > + avb0_pins: avb { > + mux { > + groups = "avb0_link", "avb0_phy_int", "avb0_mdc", ^^^^^^^^^^^^^^ Hum, I don't think it's compatible with routing the PHY interrupt via GPIO5_19 below. The driver doesn't support signalling via AVB_PHY_INT anyway. > + "avb0_mii"; > + function = "avb0"; > + }; > + }; > + > scif2_pins: scif2 { > groups = "scif2_data"; > function = "scif2"; > @@ -56,6 +66,21 @@ > status = "okay"; > }; > > +&avb { > + pinctrl-0 = <&avb0_pins>; > + pinctrl-names = "default"; > + renesas,no-ether-link; > + phy-handle = <&phy0>; > + status = "okay"; > + > + phy0: ethernet-phy@0 { > + rxc-skew-ps = <1500>; > + reg = <0>; > + interrupt-parent = <&gpio5>; > + interrupts = <19 IRQ_TYPE_LEVEL_LOW>; > + }; > +}; > + > &scif2 { > pinctrl-0 = <&scif2_pins>; > pinctrl-names = "default"; MBR, Sergei
Hello, > -----Original Message----- > From: Sergei Shtylyov > Sent: Saturday, September 30, 2017 7:24 PM > > Hello! > > On 9/29/2017 2:52 PM, Simon Horman wrote: > > > From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > > > > This patch enables EthernetAVB for R-Car D3 draak board. > > > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > > Signed-off-by: Simon Horman <horms+renesas@verge.net.au> > > --- > > arch/arm64/boot/dts/renesas/r8a77995-draak.dts | 25 +++++++++++++++++++++++++ > > 1 file changed, 25 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts > > index 7b776cb7e928..96b7ff5cc321 100644 > > --- a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts > > +++ b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts > [...] > > @@ -37,6 +39,14 @@ > > }; > > > > &pfc { > > + avb0_pins: avb { > > + mux { > > + groups = "avb0_link", "avb0_phy_int", "avb0_mdc", > ^^^^^^^^^^^^^^ > Hum, I don't think it's compatible with routing the PHY interrupt via > GPIO5_19 below. The driver doesn't support signalling via AVB_PHY_INT anyway. Oops! You're correct. I should drop "avb0_phy_int". Simon-san, may I send a follow-up patch to fix this? Best regards, Yoshihiro Shimoda > > + "avb0_mii"; > > + function = "avb0"; > > + }; > > + }; > > + > > scif2_pins: scif2 { > > groups = "scif2_data"; > > function = "scif2"; > > @@ -56,6 +66,21 @@ > > status = "okay"; > > }; > > > > +&avb { > > + pinctrl-0 = <&avb0_pins>; > > + pinctrl-names = "default"; > > + renesas,no-ether-link; > > + phy-handle = <&phy0>; > > + status = "okay"; > > + > > + phy0: ethernet-phy@0 { > > + rxc-skew-ps = <1500>; > > + reg = <0>; > > + interrupt-parent = <&gpio5>; > > + interrupts = <19 IRQ_TYPE_LEVEL_LOW>; > > + }; > > +}; > > + > > &scif2 { > > pinctrl-0 = <&scif2_pins>; > > pinctrl-names = "default"; > > MBR, Sergei
On Mon, Oct 02, 2017 at 01:18:49AM +0000, Yoshihiro Shimoda wrote: > Hello, > > > -----Original Message----- > > From: Sergei Shtylyov > > Sent: Saturday, September 30, 2017 7:24 PM > > > > Hello! > > > > On 9/29/2017 2:52 PM, Simon Horman wrote: > > > > > From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > > > > > > This patch enables EthernetAVB for R-Car D3 draak board. > > > > > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > > > Signed-off-by: Simon Horman <horms+renesas@verge.net.au> > > > --- > > > arch/arm64/boot/dts/renesas/r8a77995-draak.dts | 25 +++++++++++++++++++++++++ > > > 1 file changed, 25 insertions(+) > > > > > > diff --git a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts > > > index 7b776cb7e928..96b7ff5cc321 100644 > > > --- a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts > > > +++ b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts > > [...] > > > @@ -37,6 +39,14 @@ > > > }; > > > > > > &pfc { > > > + avb0_pins: avb { > > > + mux { > > > + groups = "avb0_link", "avb0_phy_int", "avb0_mdc", > > ^^^^^^^^^^^^^^ > > Hum, I don't think it's compatible with routing the PHY interrupt via > > GPIO5_19 below. The driver doesn't support signalling via AVB_PHY_INT anyway. > > Oops! You're correct. I should drop "avb0_phy_int". > > Simon-san, may I send a follow-up patch to fix this? Thanks Sergei, thanks Shimoda-san, yes, please provide a follow-up patch. At this stage I don't think we need to re-spin this pull-request to fix this, rather a follow-up patch can be included in a follow-up pull request. > > Best regards, > Yoshihiro Shimoda > > > > + "avb0_mii"; > > > + function = "avb0"; > > > + }; > > > + }; > > > + > > > scif2_pins: scif2 { > > > groups = "scif2_data"; > > > function = "scif2"; > > > @@ -56,6 +66,21 @@ > > > status = "okay"; > > > }; > > > > > > +&avb { > > > + pinctrl-0 = <&avb0_pins>; > > > + pinctrl-names = "default"; > > > + renesas,no-ether-link; > > > + phy-handle = <&phy0>; > > > + status = "okay"; > > > + > > > + phy0: ethernet-phy@0 { > > > + rxc-skew-ps = <1500>; > > > + reg = <0>; > > > + interrupt-parent = <&gpio5>; > > > + interrupts = <19 IRQ_TYPE_LEVEL_LOW>; > > > + }; > > > +}; > > > + > > > &scif2 { > > > pinctrl-0 = <&scif2_pins>; > > > pinctrl-names = "default"; > > > > MBR, Sergei
Hi Sergei, On Sat, Sep 30, 2017 at 12:24 PM, Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> wrote: > On 9/29/2017 2:52 PM, Simon Horman wrote: >> From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> >> >> This patch enables EthernetAVB for R-Car D3 draak board. >> >> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> >> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> >> Signed-off-by: Simon Horman <horms+renesas@verge.net.au> >> --- a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts >> +++ b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts > > [...] >> >> @@ -37,6 +39,14 @@ >> }; >> &pfc { >> + avb0_pins: avb { >> + mux { >> + groups = "avb0_link", "avb0_phy_int", "avb0_mdc", > > ^^^^^^^^^^^^^^ > Hum, I don't think it's compatible with routing the PHY interrupt via > GPIO5_19 below. The driver doesn't support signalling via AVB_PHY_INT > anyway. Seems we have the same issue in arch/arm64/boot/dts/renesas/ulcb.dtsi and arch/arm64/boot/dts/renesas/salvator-common.dtsi? >> +&avb { >> + phy0: ethernet-phy@0 { >> + rxc-skew-ps = <1500>; >> + reg = <0>; >> + interrupt-parent = <&gpio5>; >> + interrupts = <19 IRQ_TYPE_LEVEL_LOW>; >> + }; >> +}; Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Hi Simon-san, > -----Original Message----- > From: Simon Horman > Sent: Monday, October 2, 2017 4:15 PM > > On Mon, Oct 02, 2017 at 01:18:49AM +0000, Yoshihiro Shimoda wrote: > > Hello, > > > > > -----Original Message----- > > > From: Sergei Shtylyov > > > Sent: Saturday, September 30, 2017 7:24 PM > > > > > > Hello! > > > > > > On 9/29/2017 2:52 PM, Simon Horman wrote: > > > > > > > From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > > > > > > > > This patch enables EthernetAVB for R-Car D3 draak board. > > > > > > > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > > > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > > > > Signed-off-by: Simon Horman <horms+renesas@verge.net.au> > > > > --- > > > > arch/arm64/boot/dts/renesas/r8a77995-draak.dts | 25 +++++++++++++++++++++++++ > > > > 1 file changed, 25 insertions(+) > > > > > > > > diff --git a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts > > > > index 7b776cb7e928..96b7ff5cc321 100644 > > > > --- a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts > > > > +++ b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts > > > [...] > > > > @@ -37,6 +39,14 @@ > > > > }; > > > > > > > > &pfc { > > > > + avb0_pins: avb { > > > > + mux { > > > > + groups = "avb0_link", "avb0_phy_int", "avb0_mdc", > > > ^^^^^^^^^^^^^^ > > > Hum, I don't think it's compatible with routing the PHY interrupt via > > > GPIO5_19 below. The driver doesn't support signalling via AVB_PHY_INT anyway. > > > > Oops! You're correct. I should drop "avb0_phy_int". > > > > Simon-san, may I send a follow-up patch to fix this? > > Thanks Sergei, thanks Shimoda-san, > > yes, please provide a follow-up patch. > > At this stage I don't think we need to re-spin this pull-request > to fix this, rather a follow-up patch can be included > in a follow-up pull request. I got it. I will send it. Also, should I send salvator-common and ulcb patches about Geert-san's comment (These dtsi files also enable "avb_phy_int" for now)? Best regards, Yoshihiro Shimoda > > > > Best regards, > > Yoshihiro Shimoda > > > > > > + "avb0_mii"; > > > > + function = "avb0"; > > > > + }; > > > > + }; > > > > + > > > > scif2_pins: scif2 { > > > > groups = "scif2_data"; > > > > function = "scif2"; > > > > @@ -56,6 +66,21 @@ > > > > status = "okay"; > > > > }; > > > > > > > > +&avb { > > > > + pinctrl-0 = <&avb0_pins>; > > > > + pinctrl-names = "default"; > > > > + renesas,no-ether-link; > > > > + phy-handle = <&phy0>; > > > > + status = "okay"; > > > > + > > > > + phy0: ethernet-phy@0 { > > > > + rxc-skew-ps = <1500>; > > > > + reg = <0>; > > > > + interrupt-parent = <&gpio5>; > > > > + interrupts = <19 IRQ_TYPE_LEVEL_LOW>; > > > > + }; > > > > +}; > > > > + > > > > &scif2 { > > > > pinctrl-0 = <&scif2_pins>; > > > > pinctrl-names = "default"; > > > > > > MBR, Sergei
On Mon, Oct 02, 2017 at 09:16:56AM +0000, Yoshihiro Shimoda wrote: > Hi Simon-san, > > > -----Original Message----- > > From: Simon Horman > > Sent: Monday, October 2, 2017 4:15 PM > > > > On Mon, Oct 02, 2017 at 01:18:49AM +0000, Yoshihiro Shimoda wrote: > > > Hello, > > > > > > > -----Original Message----- > > > > From: Sergei Shtylyov > > > > Sent: Saturday, September 30, 2017 7:24 PM > > > > > > > > Hello! > > > > > > > > On 9/29/2017 2:52 PM, Simon Horman wrote: > > > > > > > > > From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > > > > > > > > > > This patch enables EthernetAVB for R-Car D3 draak board. > > > > > > > > > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > > > > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > > > > > Signed-off-by: Simon Horman <horms+renesas@verge.net.au> > > > > > --- > > > > > arch/arm64/boot/dts/renesas/r8a77995-draak.dts | 25 +++++++++++++++++++++++++ > > > > > 1 file changed, 25 insertions(+) > > > > > > > > > > diff --git a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts > > > > > index 7b776cb7e928..96b7ff5cc321 100644 > > > > > --- a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts > > > > > +++ b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts > > > > [...] > > > > > @@ -37,6 +39,14 @@ > > > > > }; > > > > > > > > > > &pfc { > > > > > + avb0_pins: avb { > > > > > + mux { > > > > > + groups = "avb0_link", "avb0_phy_int", "avb0_mdc", > > > > ^^^^^^^^^^^^^^ > > > > Hum, I don't think it's compatible with routing the PHY interrupt via > > > > GPIO5_19 below. The driver doesn't support signalling via AVB_PHY_INT anyway. > > > > > > Oops! You're correct. I should drop "avb0_phy_int". > > > > > > Simon-san, may I send a follow-up patch to fix this? > > > > Thanks Sergei, thanks Shimoda-san, > > > > yes, please provide a follow-up patch. > > > > At this stage I don't think we need to re-spin this pull-request > > to fix this, rather a follow-up patch can be included > > in a follow-up pull request. > > I got it. I will send it. Also, should I send salvator-common and ulcb patches > about Geert-san's comment (These dtsi files also enable "avb_phy_int" for now)? Hi Shimoda-san, yes, I think that would be best. Please include Fixes tags.
On Fri, Sep 29, 2017 at 1:52 PM, Simon Horman <horms+renesas@verge.net.au> wrote: > ---------------------------------------------------------------- > Renesas ARM64 Based SoC DT Updates for v4.15 > > * r8a7795 (H3) > - Use r8a7795-cpg-mssr and r8a7795-sysc bindings > Hardcoded indicies are replaced with symbols now that they are available > > - Drop bogus HDMI node name suffixes > Laurent Pinchart says: Node names should not use numerical suffixes if > the nodes can be distinguished by unit-address > > - Update PFC node name to pin-controller > Shimoda-san says the PFC node name is changed "from e6060000.pfc and > pfc@e6060000 to e6060000.pin-controller and pin-controller@e6060000 > like other Renesas SoCs." > > * r8a7795 (H3) ES1.0 > - Drop extra zero from XHCI unit address > This corrects a typo were ee0400000 rather than ee040000 was used > as the unit address. > > * r8a7796 (M3-W) > - Add FDP1 instance > Laurent Pinchart says: The r8a7796 has a single FDP1 instance. > > * r8a7795 (H3) and r8a7796 (M3-W) SoCs > - Add USB3.0 peripheral device nodes > Shimoda-san says that this is not enabled on the Salvator-X/XS boards > for now as: > + we need a special cable (USB type-A to A cross cable). > + we can swap the role by renesas_usb3 driver even if we use a normal > cable and after usb3.0 host is running, but I think it's a special > use case. > > * r8a7795 (H3) and r8a7796 (M3-W) ULCB boards > - Enable display output > Laurent Pinchart says: The DU is already wired up to the HDMI encoder, > all we need to do is enable it. > > * r8a77995 (D3) Draak board > - Enable EthernetAVB and , USB2.0 Host and PHY > > - Add serial console pins. > This is safe to do now that r8a77995 PFC driver support is present > > * r8a77970 (V3M) > - Add basic support for SoC and EtherAVB, [H]SCIF and SYS-DMAC nodes > This is a step towards enabling EtherAVB and [H]SCIF with SYS-DMAC > in the Eagle board support for which is under review Thanks for the detailed changelog! > ---------------------------------------------------------------- > Geert Uytterhoeven (6): > arm64: dts: renesas: r8a7795-es1: Drop extra zero from usb unit address > arm64: dts: renesas: r8a7795: Drop bogus HDMI node names suffixes > arm64: renesas: Add Renesas R8A77970 Kconfig support That one last commit doesn't seem to belong in here, but I've pulled it anyway, thanks! Arnd
On Thu, Oct 19, 2017 at 11:39:45PM +0200, Arnd Bergmann wrote: > On Fri, Sep 29, 2017 at 1:52 PM, Simon Horman > <horms+renesas@verge.net.au> wrote: > > ---------------------------------------------------------------- > > Renesas ARM64 Based SoC DT Updates for v4.15 > > > > * r8a7795 (H3) > > - Use r8a7795-cpg-mssr and r8a7795-sysc bindings > > Hardcoded indicies are replaced with symbols now that they are available > > > > - Drop bogus HDMI node name suffixes > > Laurent Pinchart says: Node names should not use numerical suffixes if > > the nodes can be distinguished by unit-address > > > > - Update PFC node name to pin-controller > > Shimoda-san says the PFC node name is changed "from e6060000.pfc and > > pfc@e6060000 to e6060000.pin-controller and pin-controller@e6060000 > > like other Renesas SoCs." > > > > * r8a7795 (H3) ES1.0 > > - Drop extra zero from XHCI unit address > > This corrects a typo were ee0400000 rather than ee040000 was used > > as the unit address. > > > > * r8a7796 (M3-W) > > - Add FDP1 instance > > Laurent Pinchart says: The r8a7796 has a single FDP1 instance. > > > > * r8a7795 (H3) and r8a7796 (M3-W) SoCs > > - Add USB3.0 peripheral device nodes > > Shimoda-san says that this is not enabled on the Salvator-X/XS boards > > for now as: > > + we need a special cable (USB type-A to A cross cable). > > + we can swap the role by renesas_usb3 driver even if we use a normal > > cable and after usb3.0 host is running, but I think it's a special > > use case. > > > > * r8a7795 (H3) and r8a7796 (M3-W) ULCB boards > > - Enable display output > > Laurent Pinchart says: The DU is already wired up to the HDMI encoder, > > all we need to do is enable it. > > > > * r8a77995 (D3) Draak board > > - Enable EthernetAVB and , USB2.0 Host and PHY > > > > - Add serial console pins. > > This is safe to do now that r8a77995 PFC driver support is present > > > > * r8a77970 (V3M) > > - Add basic support for SoC and EtherAVB, [H]SCIF and SYS-DMAC nodes > > This is a step towards enabling EtherAVB and [H]SCIF with SYS-DMAC > > in the Eagle board support for which is under review > > Thanks for the detailed changelog! > > > ---------------------------------------------------------------- > > Geert Uytterhoeven (6): > > arm64: dts: renesas: r8a7795-es1: Drop extra zero from usb unit address > > arm64: dts: renesas: r8a7795: Drop bogus HDMI node names suffixes > > arm64: renesas: Add Renesas R8A77970 Kconfig support > > That one last commit doesn't seem to belong in here, but I've pulled > it anyway, thanks! Thanks! I take it you would have prefered this in an soc branch?
On Fri, Oct 20, 2017 at 11:03 AM, Simon Horman <horms@verge.net.au> wrote: > On Thu, Oct 19, 2017 at 11:39:45PM +0200, Arnd Bergmann wrote: >> On Fri, Sep 29, 2017 at 1:52 PM, Simon Horman >> That one last commit doesn't seem to belong in here, but I've pulled >> it anyway, thanks! > > Thanks! I take it you would have prefered this in an soc branch? Yes, correct. Arnd
On Fri, Oct 20, 2017 at 11:06:56AM +0200, Arnd Bergmann wrote: > On Fri, Oct 20, 2017 at 11:03 AM, Simon Horman <horms@verge.net.au> wrote: > > On Thu, Oct 19, 2017 at 11:39:45PM +0200, Arnd Bergmann wrote: > >> On Fri, Sep 29, 2017 at 1:52 PM, Simon Horman > > >> That one last commit doesn't seem to belong in here, but I've pulled > >> it anyway, thanks! > > > > Thanks! I take it you would have prefered this in an soc branch? > > Yes, correct. Understood and noted for next time.