| Message ID | 1504000237-13872-1-git-send-email-priyanka.jain@nxp.com |
|---|---|
| State | Accepted |
| Commit | 8472d8765b39351680ea9189ecddf99864b13056 |
| Delegated to: | York Sun |
| Headers | show |
| Series | [U-Boot] board/ls2080ardb: Add mcmemsize variable in default env | expand |
On 08/29/2017 02:50 AM, Priyanka Jain wrote: > For most of ls2080ardb use-cases, mc private DRAM block is required > to be of 1.75GB. > Henc set mcmemsize=0x70000000 in default env > > Signed-off-by: Priyanka Jain <priyanka.jain@nxp.com> > --- > include/configs/ls2080ardb.h | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/include/configs/ls2080ardb.h b/include/configs/ls2080ardb.h > index b309d79..46f0f8f 100644 > --- a/include/configs/ls2080ardb.h > +++ b/include/configs/ls2080ardb.h > @@ -392,6 +392,7 @@ unsigned long get_board_sys_clk(void); > "load_addr=0xa0000000\0" \ > "kernel_size=0x2800000\0" \ > "console=ttyAMA0,38400n8\0" \ > + "mcmemsize=0x70000000\0" \ > MC_INIT_CMD \ > BOOTENV \ > "boot_scripts=ls2088ardb_boot.scr\0" \ > This is very large private RAM block. This board uses DIMM slot. How can you be sure you have enough memory for this? York
> -----Original Message----- > From: York Sun > Sent: Friday, September 15, 2017 2:10 AM > To: Priyanka Jain <priyanka.jain@nxp.com>; u-boot@lists.denx.de > Subject: Re: [PATCH] board/ls2080ardb: Add mcmemsize variable in default env > > On 08/29/2017 02:50 AM, Priyanka Jain wrote: > > For most of ls2080ardb use-cases, mc private DRAM block is required to > > be of 1.75GB. > > Henc set mcmemsize=0x70000000 in default env > > > > Signed-off-by: Priyanka Jain <priyanka.jain@nxp.com> > > --- > > include/configs/ls2080ardb.h | 1 + > > 1 files changed, 1 insertions(+), 0 deletions(-) > > > > diff --git a/include/configs/ls2080ardb.h > > b/include/configs/ls2080ardb.h index b309d79..46f0f8f 100644 > > --- a/include/configs/ls2080ardb.h > > +++ b/include/configs/ls2080ardb.h > > @@ -392,6 +392,7 @@ unsigned long get_board_sys_clk(void); > > "load_addr=0xa0000000\0" \ > > "kernel_size=0x2800000\0" \ > > "console=ttyAMA0,38400n8\0" \ > > + "mcmemsize=0x70000000\0" \ > > MC_INIT_CMD \ > > BOOTENV \ > > "boot_scripts=ls2088ardb_boot.scr\0" \ > > > > This is very large private RAM block. This board uses DIMM slot. How can you be > sure you have enough memory for this? > > York This value was based on requirements of majority of use cases that we are delivering on this product. And is supported by DIMM that is shipped with RDB boards. But yes, there can be a case, where a user can make some customization like use small memory. In that case mcmemsize env variable needs to be adjusted or this will return a failure error. Priyanka
On 08/29/2017 02:50 AM, Priyanka Jain wrote: > For most of ls2080ardb use-cases, mc private DRAM block is required > to be of 1.75GB. > Henc set mcmemsize=0x70000000 in default env > > Signed-off-by: Priyanka Jain <priyanka.jain@nxp.com> > --- Applied to fsl-qoriq mater. Thanks. York
diff --git a/include/configs/ls2080ardb.h b/include/configs/ls2080ardb.h index b309d79..46f0f8f 100644 --- a/include/configs/ls2080ardb.h +++ b/include/configs/ls2080ardb.h @@ -392,6 +392,7 @@ unsigned long get_board_sys_clk(void); "load_addr=0xa0000000\0" \ "kernel_size=0x2800000\0" \ "console=ttyAMA0,38400n8\0" \ + "mcmemsize=0x70000000\0" \ MC_INIT_CMD \ BOOTENV \ "boot_scripts=ls2088ardb_boot.scr\0" \
For most of ls2080ardb use-cases, mc private DRAM block is required to be of 1.75GB. Henc set mcmemsize=0x70000000 in default env Signed-off-by: Priyanka Jain <priyanka.jain@nxp.com> --- include/configs/ls2080ardb.h | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)