diff mbox

[47/62] vmxnet3: Use static const

Message ID 89E2752CFA8EC044846EB8499819134102BD7E186D@EXCH-MBX-4.vmware.com
State Not Applicable, archived
Delegated to: David Miller
Headers show

Commit Message

Shreyas Bhatewara Nov. 30, 2010, 6:15 p.m. UTC
Thanks Joe.

Acked-by: Shreyas N Bhatewara <sbhatewara@vmware.com>
Acked-by: Scott J. Goldman <scottjg@vmware.com>

Comments

David Miller Nov. 30, 2010, 6:24 p.m. UTC | #1
From: Shreyas Bhatewara <sbhatewara@vmware.com>
Date: Tue, 30 Nov 2010 10:15:58 -0800

> Thanks Joe.
> 
> Acked-by: Shreyas N Bhatewara <sbhatewara@vmware.com>
> Acked-by: Scott J. Goldman <scottjg@vmware.com>

Please do not quote patches in this way when you ACK patches.

Since your email client doesn't use any delimiters to prefix the
quoted patch, it looks to patchwork and the rest of the world as a
fresh new patch posting.

Also, you are top-posting which is also a big no-no on these lists.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Joe Perches Nov. 30, 2010, 6:36 p.m. UTC | #2
On Tue, 2010-11-30 at 10:24 -0800, David Miller wrote:
> From: Shreyas Bhatewara <sbhatewara@vmware.com>
> Date: Tue, 30 Nov 2010 10:15:58 -0800
> > Acked-by: Shreyas N Bhatewara <sbhatewara@vmware.com>
> > Acked-by: Scott J. Goldman <scottjg@vmware.com>
> Please do not quote patches in this way when you ACK patches.
> Since your email client doesn't use any delimiters to prefix the
> quoted patch, it looks to patchwork and the rest of the world as a
> fresh new patch posting.

Shreyas is YA exchange/lookout victim.

I personally liked Outlook when I used it.
Exchange? grumble.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/net/vmxnet3/vmxnet3_drv.c b/drivers/net/vmxnet3/vmxnet3_drv.c
index 21314e0..31dc45a 100644
--- a/drivers/net/vmxnet3/vmxnet3_drv.c
+++ b/drivers/net/vmxnet3/vmxnet3_drv.c
@@ -1082,7 +1082,9 @@  static int
 vmxnet3_rq_rx_complete(struct vmxnet3_rx_queue *rq,
                       struct vmxnet3_adapter *adapter, int quota)
 {
-       static u32 rxprod_reg[2] = {VMXNET3_REG_RXPROD, VMXNET3_REG_RXPROD2};
+       static const u32 rxprod_reg[2] = {
+               VMXNET3_REG_RXPROD, VMXNET3_REG_RXPROD2
+       };
        u32 num_rxd = 0;
        struct Vmxnet3_RxCompDesc *rcd;
        struct vmxnet3_rx_ctx *ctx = &rq->rx_ctx;