diff mbox

[ovs-dev,PATCHv2,2/2] tests: Comment which netcat version the opts are for.

Message ID 20170815231555.25525-2-joe@ovn.org
State Accepted
Headers show

Commit Message

Joe Stringer Aug. 15, 2017, 11:15 p.m. UTC 
Signed-off-by: Joe Stringer <joe@ovn.org>
---
 tests/atlocal.in | 2 ++
 1 file changed, 2 insertions(+)

Comments

Flavio Leitner Aug. 15, 2017, 11:45 p.m. UTC | #1 
On Tue, 15 Aug 2017 16:15:55 -0700
Joe Stringer <joe@ovn.org> wrote:

> Signed-off-by: Joe Stringer <joe@ovn.org>
> ---
>  tests/atlocal.in | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/tests/atlocal.in b/tests/atlocal.in
> index ba143d30f1d7..7c5e9e3357e5 100644
> --- a/tests/atlocal.in
> +++ b/tests/atlocal.in
> @@ -152,8 +152,10 @@ find_command nc
>  
>  # Determine correct netcat option to quit on stdin EOF
>  if nc --version 2>&1 | grep -q nmap.org; then
> +    # Nmap netcat
>      NC_EOF_OPT="--send-only -w 5"
>  else
> +    # BSD netcat
>      NC_EOF_OPT="-q 1 -w 5"
>  fi
>  

Acked-by: Flavio Leitner <fbl@sysclose.org>
Joe Stringer Aug. 15, 2017, 11:48 p.m. UTC | #2 
On 15 August 2017 at 16:45, Flavio Leitner <fbl@sysclose.org> wrote:
> On Tue, 15 Aug 2017 16:15:55 -0700
> Joe Stringer <joe@ovn.org> wrote:
>
>> Signed-off-by: Joe Stringer <joe@ovn.org>
>> ---
>>  tests/atlocal.in | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/tests/atlocal.in b/tests/atlocal.in
>> index ba143d30f1d7..7c5e9e3357e5 100644
>> --- a/tests/atlocal.in
>> +++ b/tests/atlocal.in
>> @@ -152,8 +152,10 @@ find_command nc
>>
>>  # Determine correct netcat option to quit on stdin EOF
>>  if nc --version 2>&1 | grep -q nmap.org; then
>> +    # Nmap netcat
>>      NC_EOF_OPT="--send-only -w 5"
>>  else
>> +    # BSD netcat
>>      NC_EOF_OPT="-q 1 -w 5"
>>  fi
>>
>
> Acked-by: Flavio Leitner <fbl@sysclose.org>

Thanks, applied to master.
diff mbox

Patch

diff --git a/tests/atlocal.in b/tests/atlocal.in
index ba143d30f1d7..7c5e9e3357e5 100644
--- a/tests/atlocal.in
+++ b/tests/atlocal.in
@@ -152,8 +152,10 @@  find_command nc
 
 # Determine correct netcat option to quit on stdin EOF
 if nc --version 2>&1 | grep -q nmap.org; then
+    # Nmap netcat
     NC_EOF_OPT="--send-only -w 5"
 else
+    # BSD netcat
     NC_EOF_OPT="-q 1 -w 5"
 fi