| Message ID | 20170809185500.13669-1-xypron.glpk@gmx.de |
|---|---|
| State | Accepted |
| Commit | ebf199b92f81d4c1228200bfc138aa32928bf373 |
| Delegated to: | Alexander Graf |
| Headers | show |
On Wed, Aug 9, 2017 at 2:55 PM, Heinrich Schuchardt <xypron.glpk@gmx.de> wrote: > efi_locate_handle is called internally so it should not be > marked as EFIAPI. > > The external function is efi_locate_handle_ext. > > Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> Reviewed-by: Rob Clark <robdclark@gmail.com> > --- > @Alex > Please, pull this patch after > [PATCH v2] efi_loader: LocateHandle should return EFI_NOT_FOUND if none found > https://patchwork.ozlabs.org/patch/798433/ > --- > lib/efi_loader/efi_boottime.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/efi_loader/efi_boottime.c b/lib/efi_loader/efi_boottime.c > index b8461582e4..5d4dab3396 100644 > --- a/lib/efi_loader/efi_boottime.c > +++ b/lib/efi_loader/efi_boottime.c > @@ -624,7 +624,7 @@ static int efi_search(enum efi_locate_search_type search_type, > return -1; > } > > -static efi_status_t EFIAPI efi_locate_handle( > +static efi_status_t efi_locate_handle( > enum efi_locate_search_type search_type, > efi_guid_t *protocol, void *search_key, > unsigned long *buffer_size, efi_handle_t *buffer) > -- > 2.11.0 >
diff --git a/lib/efi_loader/efi_boottime.c b/lib/efi_loader/efi_boottime.c index b8461582e4..5d4dab3396 100644 --- a/lib/efi_loader/efi_boottime.c +++ b/lib/efi_loader/efi_boottime.c @@ -624,7 +624,7 @@ static int efi_search(enum efi_locate_search_type search_type, return -1; } -static efi_status_t EFIAPI efi_locate_handle( +static efi_status_t efi_locate_handle( enum efi_locate_search_type search_type, efi_guid_t *protocol, void *search_key, unsigned long *buffer_size, efi_handle_t *buffer)
efi_locate_handle is called internally so it should not be marked as EFIAPI. The external function is efi_locate_handle_ext. Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> --- @Alex Please, pull this patch after [PATCH v2] efi_loader: LocateHandle should return EFI_NOT_FOUND if none found https://patchwork.ozlabs.org/patch/798433/ --- lib/efi_loader/efi_boottime.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)