Message ID | 20101123123656.GB3915@gerrit.erg.abdn.ac.uk |
---|---|
State | Accepted, archived |
Delegated to: | David Miller |
Headers | show |
From: Gerrit Renker <gerrit@erg.abdn.ac.uk> Date: Tue, 23 Nov 2010 13:36:56 +0100 > dccp: fix error in updating the GAR > > This fixes a bug in updating the Greatest Acknowledgment number Received (GAR): > the current implementation does not track the greatest received value - > lower values in the range AWL..AWH (RFC 4340, 7.5.1) erase higher ones. > > Signed-off-by: Gerrit Renker <gerrit@erg.abdn.ac.uk> Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
--- a/net/dccp/input.c +++ b/net/dccp/input.c @@ -241,7 +241,8 @@ static int dccp_check_seqno(struct sock dccp_update_gsr(sk, seqno); if (dh->dccph_type != DCCP_PKT_SYNC && - (ackno != DCCP_PKT_WITHOUT_ACK_SEQ)) + ackno != DCCP_PKT_WITHOUT_ACK_SEQ && + after48(ackno, dp->dccps_gar)) dp->dccps_gar = ackno; } else { unsigned long now = jiffies;