| Message ID | 20170807200521.18128-1-joe@ovn.org |
|---|---|
| State | Accepted |
| Headers | show |
On Mon, Aug 7, 2017 at 1:05 PM, Joe Stringer <joe@ovn.org> wrote: > This test checked whether FTP support was available rather than TFTP. > It should check for TFTP, fix it. > > Fixes: 200a9af97d1c ("System tests: Add 4 new ftp and tftp tests.") > Signed-off-by: Joe Stringer <joe@ovn.org> Acked-by: Andy Zhou <azhou@ovn.org>
On 7 August 2017 at 13:35, Andy Zhou <azhou@ovn.org> wrote: > On Mon, Aug 7, 2017 at 1:05 PM, Joe Stringer <joe@ovn.org> wrote: >> This test checked whether FTP support was available rather than TFTP. >> It should check for TFTP, fix it. >> >> Fixes: 200a9af97d1c ("System tests: Add 4 new ftp and tftp tests.") >> Signed-off-by: Joe Stringer <joe@ovn.org> > Acked-by: Andy Zhou <azhou@ovn.org> Thanks, applied to master and branch-2.8.
Thanks for fixing this Joe -----Original Message----- From: <ovs-dev-bounces@openvswitch.org> on behalf of Joe Stringer <joe@ovn.org> Date: Monday, August 7, 2017 at 5:35 PM To: Andy Zhou <azhou@ovn.org> Cc: "<dev@openvswitch.org>" <dev@openvswitch.org> Subject: Re: [ovs-dev] [PATCH] system-traffic: Fix TFTP NAT skip check. On 7 August 2017 at 13:35, Andy Zhou <azhou@ovn.org> wrote: > On Mon, Aug 7, 2017 at 1:05 PM, Joe Stringer <joe@ovn.org> wrote: >> This test checked whether FTP support was available rather than TFTP. >> It should check for TFTP, fix it. >> >> Fixes: 200a9af97d1c ("System tests: Add 4 new ftp and tftp tests.") >> Signed-off-by: Joe Stringer <joe@ovn.org> > Acked-by: Andy Zhou <azhou@ovn.org> Thanks, applied to master and branch-2.8. _______________________________________________ dev mailing list dev@openvswitch.org https://urldefense.proofpoint.com/v2/url?u=https-3A__mail.openvswitch.org_mailman_listinfo_ovs-2Ddev&d=DwICAg&c=uilaK90D4TOVoH58JNXRgQ&r=BVhFA09CGX7JQ5Ih-uZnsw&m=8r-q5mXX8vAn4sfoNBbU5NqEuWJnlheI5tqQ1Y8fBhs&s=hvc-KGt4XUdBjjPoEe8GYns4I7IK2I0EEwJdchGvu9c&e=
diff --git a/tests/system-traffic.at b/tests/system-traffic.at index 1522173f83a5..798dd2cbd2c2 100644 --- a/tests/system-traffic.at +++ b/tests/system-traffic.at @@ -3758,7 +3758,7 @@ OVS_TRAFFIC_VSWITCHD_STOP AT_CLEANUP AT_SETUP([conntrack - IPv4 TFTP with NAT]) -AT_SKIP_IF([test $HAVE_FTP = no]) +AT_SKIP_IF([test $HAVE_TFTP = no]) CHECK_CONNTRACK() CHECK_CONNTRACK_NAT() CHECK_CONNTRACK_ALG()
This test checked whether FTP support was available rather than TFTP. It should check for TFTP, fix it. Fixes: 200a9af97d1c ("System tests: Add 4 new ftp and tftp tests.") Signed-off-by: Joe Stringer <joe@ovn.org> --- tests/system-traffic.at | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)