| Message ID | 1488836249-1193-1-git-send-email-harald@ccbib.org |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
On Mon, Mar 06, 2017 at 09:37:29PM +0000, Harald Geyer wrote: > These two drivers fail to probe if no name is provided. For details see: > https://www.spinics.net/lists/kernel/msg2457515.html > > Signed-off-by: Harald Geyer <harald@ccbib.org> > --- > Documentation/devicetree/bindings/regulator/fixed-regulator.txt | 1 + > Documentation/devicetree/bindings/regulator/gpio-regulator.txt | 2 ++ > 2 files changed, 3 insertions(+) Acked-by: Rob Herring <robh@kernel.org> -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Mark, what happened to this patch? Since it was written to your specification and got an ack from a devicetree maintainer more then 3 months ago, I don't see what is holding it back. I can't find it in any tree. TIA, Harald Rob Herring writes: > On Mon, Mar 06, 2017 at 09:37:29PM +0000, Harald Geyer wrote: > > These two drivers fail to probe if no name is provided. For details see: > > https://www.spinics.net/lists/kernel/msg2457515.html > > > > Signed-off-by: Harald Geyer <harald@ccbib.org> > > --- > > Documentation/devicetree/bindings/regulator/fixed-regulator.txt | 1 + > > Documentation/devicetree/bindings/regulator/gpio-regulator.txt | 2 ++ > > 2 files changed, 3 insertions(+) > > Acked-by: Rob Herring <robh@kernel.org> -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Jun 23, 2017 at 03:55:09PM +0200, Harald Geyer wrote: > what happened to this patch? Since it was written to your specification > and got an ack from a devicetree maintainer more then 3 months ago, > I don't see what is holding it back. I can't find it in any tree. Please don't send content free pings and please allow a reasonable time for review. People get busy, go on holiday, attend conferences and so on so unless there is some reason for urgency (like critical bug fixes) please allow at least a couple of weeks for review. If there have been review comments then people may be waiting for those to be addressed. Sending content free pings adds to the mail volume (if they are seen at all) which is often the problem and since they can't be reviewed directly if something has gone wrong you'll have to resend the patches anyway, though there are some other maintainers who like them - if in doubt look at how patches for the subsystem are normally handled. Please don't top post, reply in line with needed context. This allows readers to readily follow the flow of conversation and understand what you are talking about and also helps ensure that everything in the discussion is being addressed.
diff --git a/Documentation/devicetree/bindings/regulator/fixed-regulator.txt b/Documentation/devicetree/bindings/regulator/fixed-regulator.txt index 4fae41d..0c2a6c8 100644 --- a/Documentation/devicetree/bindings/regulator/fixed-regulator.txt +++ b/Documentation/devicetree/bindings/regulator/fixed-regulator.txt @@ -2,6 +2,7 @@ Fixed Voltage regulators Required properties: - compatible: Must be "regulator-fixed"; +- regulator-name: Defined in regulator.txt as optional, but required here. Optional properties: - gpio: gpio to use for enable control diff --git a/Documentation/devicetree/bindings/regulator/gpio-regulator.txt b/Documentation/devicetree/bindings/regulator/gpio-regulator.txt index dd1ed78..1f49615 100644 --- a/Documentation/devicetree/bindings/regulator/gpio-regulator.txt +++ b/Documentation/devicetree/bindings/regulator/gpio-regulator.txt @@ -2,6 +2,8 @@ GPIO controlled regulators Required properties: - compatible : Must be "regulator-gpio". +- regulator-name : Defined in regulator.txt as optional, but required + here. - states : Selection of available voltages and GPIO configs. if there are no states, then use a fixed regulator
These two drivers fail to probe if no name is provided. For details see: https://www.spinics.net/lists/kernel/msg2457515.html Signed-off-by: Harald Geyer <harald@ccbib.org> --- Documentation/devicetree/bindings/regulator/fixed-regulator.txt | 1 + Documentation/devicetree/bindings/regulator/gpio-regulator.txt | 2 ++ 2 files changed, 3 insertions(+)