Message ID | 1289765315-6028-1-git-send-email-segoon@openwall.com |
---|---|
State | Accepted, archived |
Delegated to: | David Miller |
Headers | show |
On Sun, 2010-11-14 at 12:08 -0800, Vasiliy Kulikov wrote: > bnx2x_init_one() should return negative value on error. > By mistake it returns ENODEV instead of -ENODEV. > > Signed-off-by: Vasiliy Kulikov <segoon@openwall.com> Thanks Vasiliy! Acked-by: Eilon Greenstein <eilong@broadcom.com> > --- > Compile tested. > > drivers/net/bnx2x/bnx2x_main.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/net/bnx2x/bnx2x_main.c b/drivers/net/bnx2x/bnx2x_main.c > index 4a6f0ea..be52edc 100644 > --- a/drivers/net/bnx2x/bnx2x_main.c > +++ b/drivers/net/bnx2x/bnx2x_main.c > @@ -9064,7 +9064,7 @@ static int __devinit bnx2x_init_one(struct pci_dev *pdev, > default: > pr_err("Unknown board_type (%ld), aborting\n", > ent->driver_data); > - return ENODEV; > + return -ENODEV; > } > > cid_count += CNIC_CONTEXT_USE; -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Le dimanche 14 novembre 2010 à 23:08 +0300, Vasiliy Kulikov a écrit : > bnx2x_init_one() should return negative value on error. > By mistake it returns ENODEV instead of -ENODEV. > > Signed-off-by: Vasiliy Kulikov <segoon@openwall.com> > --- > Compile tested. > > drivers/net/bnx2x/bnx2x_main.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/net/bnx2x/bnx2x_main.c b/drivers/net/bnx2x/bnx2x_main.c > index 4a6f0ea..be52edc 100644 > --- a/drivers/net/bnx2x/bnx2x_main.c > +++ b/drivers/net/bnx2x/bnx2x_main.c > @@ -9064,7 +9064,7 @@ static int __devinit bnx2x_init_one(struct pci_dev *pdev, > default: > pr_err("Unknown board_type (%ld), aborting\n", > ent->driver_data); > - return ENODEV; > + return -ENODEV; > } > > cid_count += CNIC_CONTEXT_USE; I remember sending same patch in the past... it was lost somehow... -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Le dimanche 14 novembre 2010 à 21:29 +0100, Eric Dumazet a écrit :
> I remember sending same patch in the past... it was lost somehow...
Ah, it was another issue, patch was not lost ;)
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Eric Dumazet <eric.dumazet@gmail.com> Date: Sun, 14 Nov 2010 21:32:08 +0100 > Le dimanche 14 novembre 2010 à 21:29 +0100, Eric Dumazet a écrit : > >> I remember sending same patch in the past... it was lost somehow... > > Ah, it was another issue, patch was not lost ;) :-) Applied, thanks everyone. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/bnx2x/bnx2x_main.c b/drivers/net/bnx2x/bnx2x_main.c index 4a6f0ea..be52edc 100644 --- a/drivers/net/bnx2x/bnx2x_main.c +++ b/drivers/net/bnx2x/bnx2x_main.c @@ -9064,7 +9064,7 @@ static int __devinit bnx2x_init_one(struct pci_dev *pdev, default: pr_err("Unknown board_type (%ld), aborting\n", ent->driver_data); - return ENODEV; + return -ENODEV; } cid_count += CNIC_CONTEXT_USE;
bnx2x_init_one() should return negative value on error. By mistake it returns ENODEV instead of -ENODEV. Signed-off-by: Vasiliy Kulikov <segoon@openwall.com> --- Compile tested. drivers/net/bnx2x/bnx2x_main.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)