| Message ID | 1497157289-7652-2-git-send-email-j-keerthy@ti.com |
|---|---|
| State | Superseded |
| Delegated to: | Jaehoon Chung |
| Headers | show |
On 10 June 2017 at 23:01, Keerthy <j-keerthy@ti.com> wrote: > The function wrongly returned an integer while it is supposed to > return boolean. Fix that. > > Fixes: 99785de83 ("power: regulator: lp873x: Add regulator support") > Signed-off-by: Keerthy <j-keerthy@ti.com> > --- > drivers/power/regulator/lp873x_regulator.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Simon Glass <sjg@chromium.org> I think in fact we should return int from this method in struct dm_regulator_ops. I don't really like not being able to return an error. So bonus points if you can change that :-)
On Tuesday 13 June 2017 05:21 AM, Simon Glass wrote: > On 10 June 2017 at 23:01, Keerthy <j-keerthy@ti.com> wrote: >> The function wrongly returned an integer while it is supposed to >> return boolean. Fix that. >> >> Fixes: 99785de83 ("power: regulator: lp873x: Add regulator support") >> Signed-off-by: Keerthy <j-keerthy@ti.com> >> --- >> drivers/power/regulator/lp873x_regulator.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> > > Reviewed-by: Simon Glass <sjg@chromium.org> > > I think in fact we should return int from this method in struct > dm_regulator_ops. I don't really like not being able to return an > error. > > So bonus points if you can change that :-) I did not touch it as it was being used at many places. Seems like that is the right thing to do. I believe this series can be discarded. I will post a series where in all are changed to return int. >
On Tuesday 13 June 2017 09:04 AM, Keerthy wrote: > > > On Tuesday 13 June 2017 05:21 AM, Simon Glass wrote: >> On 10 June 2017 at 23:01, Keerthy <j-keerthy@ti.com> wrote: >>> The function wrongly returned an integer while it is supposed to >>> return boolean. Fix that. >>> >>> Fixes: 99785de83 ("power: regulator: lp873x: Add regulator support") >>> Signed-off-by: Keerthy <j-keerthy@ti.com> >>> --- >>> drivers/power/regulator/lp873x_regulator.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >> >> Reviewed-by: Simon Glass <sjg@chromium.org> >> >> I think in fact we should return int from this method in struct >> dm_regulator_ops. I don't really like not being able to return an >> error. >> >> So bonus points if you can change that :-) Simon, https://lists.denx.de/pipermail/u-boot/2017-June/295326.html For changing the return type. Regards, Keerthy > > I did not touch it as it was being used at many places. Seems like that > is the right thing to do. I believe this series can be discarded. I will > post a series where in all are changed to return int. > > >> > _______________________________________________ > U-Boot mailing list > U-Boot@lists.denx.de > https://lists.denx.de/listinfo/u-boot >
diff --git a/drivers/power/regulator/lp873x_regulator.c b/drivers/power/regulator/lp873x_regulator.c index dcb19ff..149a36d 100644 --- a/drivers/power/regulator/lp873x_regulator.c +++ b/drivers/power/regulator/lp873x_regulator.c @@ -263,7 +263,7 @@ static bool ldo_get_enable(struct udevice *dev) ret = lp873x_ldo_enable(dev, PMIC_OP_GET, &enable); if (ret) - return ret; + return false; return enable; }
The function wrongly returned an integer while it is supposed to return boolean. Fix that. Fixes: 99785de83 ("power: regulator: lp873x: Add regulator support") Signed-off-by: Keerthy <j-keerthy@ti.com> --- drivers/power/regulator/lp873x_regulator.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)