[v3] azure-iot-sdk-c: New package

I use 2017-05-05 now, because newer versions will need some fixes (maybe as patches), so let's start with a cleaner version that just works.
Still, the projects install target installs the wrong files, that's why commands are needed for staging_install and target_install.

v2: Rework the package with help from Arnouts comments
v3: Explain some things in the commit message
Signed-off-by: André Hentschel <nerv@dawncrow.de>
---
 DEVELOPERS                                 |  1 +
 package/Config.in                          |  1 +
 package/azure-iot-sdk-c/Config.in          | 16 ++++++++++
 package/azure-iot-sdk-c/azure-iot-sdk-c.mk | 51 ++++++++++++++++++++++++++++++
 4 files changed, 69 insertions(+)
 create mode 100644 package/azure-iot-sdk-c/Config.in
 create mode 100644 package/azure-iot-sdk-c/azure-iot-sdk-c.mk

Hello,

On Mon, 12 Jun 2017 21:51:31 +0200, André Hentschel wrote:
> I use 2017-05-05 now, because newer versions will need some fixes (maybe as patches), so let's start with a cleaner version that just works.

Don't use "personal" sentences in commit logs, and rewrap commit logs
at 72 characters. So something like:

"""

Despite newer versions being available, this patch creates a package
for version 2017-05-05, because newer version have issues that need to
be addressed.

"""

> Still, the projects install target installs the wrong files, that's
> why commands are needed for staging_install and target_install.

Isn't it better to patch the package build system to fix those issues?

> 
> v2: Rework the package with help from Arnouts comments
> v3: Explain some things in the commit message

The commit log should go...

> Signed-off-by: André Hentschel <nerv@dawncrow.de>
> ---

... here.

I typically do that by putting "---" below my SoB line, and writing the
commit log (git commit --amend).

Thanks,

Thomas

Hi Andre,

On 12-06-17 21:51, André Hentschel wrote:
[snip]
> +# The project only supports building one kind of library.
> +# Further the install target installs the wrong files, so we do it here:
> +ifeq ($(BR2_STATIC_LIBS),y)

 I was going to say: these also have to be installed in the SHARED_STATIC case.
But apparently CMake doesn't build a static library in the SHARED_STATIC case.
Bummer...

> +AZURE_IOT_SDK_C_LIBS += uamqp/libuamqp.a c-utility/libaziotsharedutil.a \
> +	iothub_client/libiothub_client.a iothub_client/libiothub_client_mqtt_ws_transport.a \
> +	iothub_client/libiothub_client_amqp_ws_transport.a \
> +	iothub_client/libiothub_client_http_transport.a \
> +	iothub_client/libiothub_client_amqp_transport.a \
> +	iothub_client/libiothub_client_mqtt_transport.a \
> +	iothub_service_client/libiothub_service_client.a serializer/libserializer.a umqtt/libumqtt.a
> +else
> +AZURE_IOT_SDK_C_LIBS += uamqp/libuamqp.so c-utility/libaziotsharedutil.so \
> +	iothub_client/libiothub_client.so iothub_client/libiothub_client_mqtt_ws_transport.so \
> +	iothub_client/libiothub_client_amqp_ws_transport.so \
> +	iothub_client/libiothub_client_http_transport.so \
> +	iothub_client/libiothub_client_amqp_transport.so \
> +	iothub_client/libiothub_client_mqtt_transport.so \
> +	iothub_service_client/libiothub_service_client.so serializer/libserializer.so umqtt/libumqtt.so
> +endif
> +
> +define AZURE_IOT_SDK_C_INSTALL_STAGING_CMDS
> +	$(foreach l,$(AZURE_IOT_SDK_C_LIBS), \
> +		$(INSTALL) -D -m 0755 $(@D)/$(l) $(STAGING_DIR)/usr/lib/
> +	)
> +	cp -a $(@D)/c-utility/inc/* $(STAGING_DIR)/usr/include/
> +	cp -a $(@D)/iothub_client/inc/* $(STAGING_DIR)/usr/include/

 This is not the location where the CMakeLists.txt installs the headers. Isn't
that going to give problems when there are packages that use this library?

 Regards,
 Arnout

> +endef
> +
> +define AZURE_IOT_SDK_C_INSTALL_TARGET_CMDS
> +	$(foreach l,$(AZURE_IOT_SDK_C_LIBS), \
> +		$(INSTALL) -D -m 0755 $(@D)/$(l) $(TARGET_DIR)/usr/lib/
> +	)
> +endef
> +
> +$(eval $(cmake-package))
>

Am 13.06.2017 um 00:19 schrieb Arnout Vandecappelle:
>  Hi Andre,
> 
> On 12-06-17 21:51, André Hentschel wrote:
> [snip]
>> +# The project only supports building one kind of library.
>> +# Further the install target installs the wrong files, so we do it here:
>> +ifeq ($(BR2_STATIC_LIBS),y)
> 
>  I was going to say: these also have to be installed in the SHARED_STATIC case.
> But apparently CMake doesn't build a static library in the SHARED_STATIC case.
> Bummer...
> 
>> +AZURE_IOT_SDK_C_LIBS += uamqp/libuamqp.a c-utility/libaziotsharedutil.a \
>> +	iothub_client/libiothub_client.a iothub_client/libiothub_client_mqtt_ws_transport.a \
>> +	iothub_client/libiothub_client_amqp_ws_transport.a \
>> +	iothub_client/libiothub_client_http_transport.a \
>> +	iothub_client/libiothub_client_amqp_transport.a \
>> +	iothub_client/libiothub_client_mqtt_transport.a \
>> +	iothub_service_client/libiothub_service_client.a serializer/libserializer.a umqtt/libumqtt.a
>> +else
>> +AZURE_IOT_SDK_C_LIBS += uamqp/libuamqp.so c-utility/libaziotsharedutil.so \
>> +	iothub_client/libiothub_client.so iothub_client/libiothub_client_mqtt_ws_transport.so \
>> +	iothub_client/libiothub_client_amqp_ws_transport.so \
>> +	iothub_client/libiothub_client_http_transport.so \
>> +	iothub_client/libiothub_client_amqp_transport.so \
>> +	iothub_client/libiothub_client_mqtt_transport.so \
>> +	iothub_service_client/libiothub_service_client.so serializer/libserializer.so umqtt/libumqtt.so
>> +endif
>> +
>> +define AZURE_IOT_SDK_C_INSTALL_STAGING_CMDS
>> +	$(foreach l,$(AZURE_IOT_SDK_C_LIBS), \
>> +		$(INSTALL) -D -m 0755 $(@D)/$(l) $(STAGING_DIR)/usr/lib/
>> +	)
>> +	cp -a $(@D)/c-utility/inc/* $(STAGING_DIR)/usr/include/
>> +	cp -a $(@D)/iothub_client/inc/* $(STAGING_DIR)/usr/include/
> 
>  This is not the location where the CMakeLists.txt installs the headers. Isn't
> that going to give problems when there are packages that use this library?
> 

AFAICT the CMakeLists.txt installs the totally wrong headers, what exactly do you mean here?

Am 12.06.2017 um 22:45 schrieb Thomas Petazzoni:
> Hello,

Hi, thanks for the review

> On Mon, 12 Jun 2017 21:51:31 +0200, André Hentschel wrote:
>> I use 2017-05-05 now, because newer versions will need some fixes (maybe as patches), so let's start with a cleaner version that just works.
> 
> Don't use "personal" sentences in commit logs, and rewrap commit logs
> at 72 characters. So something like:
> 
> """
> 
> Despite newer versions being available, this patch creates a package
> for version 2017-05-05, because newer version have issues that need to
> be addressed.
> 
> """

thx, done

>> Still, the projects install target installs the wrong files, that's
>> why commands are needed for staging_install and target_install.
> 
> Isn't it better to patch the package build system to fix those issues?

That would be quite a lot for the first introduction of the package.
I'll get in contact with the project to improve the situation in future versions

>>
>> v2: Rework the package with help from Arnouts comments
>> v3: Explain some things in the commit message
> 
> The commit log should go...
> 
>> Signed-off-by: André Hentschel <nerv@dawncrow.de>
>> ---
> 
> ... here.
> 
> I typically do that by putting "---" below my SoB line, and writing the
> commit log (git commit --amend).

thx, done