Message ID | 09003684-3035-6eae-8b92-815afe4229b8@mentor.com |
---|---|
State | New |
Headers | show |
On Jun 8, 2017, at 3:20 AM, Tom de Vries <Tom_deVries@mentor.com> wrote: > [ To complicate matters objc_target_compile tests for 'objc,no_trampolines' to set -DNO_TRAMPOLINES, but AFAICT that macro is not used anywhere in the objc test suites, so I think that's dead code. ] Yes, Ok to remove the dead code as well. > - it's better to have to define one variable than two > - it looks like an accident that the 'gcc,' was dropped > - the one with the 'gcc,' prefix has been around longer, and is > mentioned in dejagnu docs > I propose to test for 'gcc,no_trampolines' instead of 'no_trampolines' in check_effective_target_trampolines. > OK for trunk? Ok. I had hit this bug years ago, and was puzzled why people seemed to get it so wrong. I took the easy way out and just defined the three of them. :-(
Fix no_trampolines test in check_effective_target_trampolines 2017-06-08 Tom de Vries <tom@codesourcery.com> * lib/target-supports.exp (check_effective_target_trampolines): Test for 'gcc,no_trampolines' instead of 'no_trampolines'. --- gcc/testsuite/lib/target-supports.exp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/testsuite/lib/target-supports.exp b/gcc/testsuite/lib/target-supports.exp index 8b99f35..d0b35be 100644 --- a/gcc/testsuite/lib/target-supports.exp +++ b/gcc/testsuite/lib/target-supports.exp @@ -491,7 +491,7 @@ proc check_gc_sections_available { } { # target is supposed to support trampolines. proc check_effective_target_trampolines { } { - if [target_info exists no_trampolines] { + if [target_info exists gcc,no_trampolines] { return 0 } if { [istarget avr-*-*]