| Message ID | 1495435428-14854-5-git-send-email-eddie.cai.linux@gmail.com |
|---|---|
| State | Superseded |
| Delegated to: | Łukasz Majewski |
| Headers | show |
Hi Eddie, On 22 May 2017 at 00:43, Eddie Cai <eddie.cai.linux@gmail.com> wrote: > this patch enable rockusb support on rk3288 based device. > > Signed-off-by: Eddie Cai <eddie.cai.linux@gmail.com> > > Changes in v6: > -enable rockusb in defconfig > > Changes in v5: > -none > > Changes in v4: > -move to rk3288_common.h > > Changes in v3: > -move to defconfig > > --- > configs/evb-rk3288_defconfig | 11 +++++++++++ > configs/fennec-rk3288_defconfig | 8 ++++++++ > configs/firefly-rk3288_defconfig | 8 ++++++++ > configs/miqi-rk3288_defconfig | 8 ++++++++ > configs/popmetal-rk3288_defconfig | 8 ++++++++ > configs/tinker-rk3288_defconfig | 8 ++++++++ > include/configs/rk3288_common.h | 7 ------- > 7 files changed, 51 insertions(+), 7 deletions(-) Reviewed-by: Simon Glass <sjg@chromium.org> But can you use imply in the Kconfig to enable this for all rk2388 boards?
2017-05-24 8:44 GMT+08:00 Simon Glass <sjg@chromium.org>: > Hi Eddie, > > On 22 May 2017 at 00:43, Eddie Cai <eddie.cai.linux@gmail.com> wrote: >> this patch enable rockusb support on rk3288 based device. >> >> Signed-off-by: Eddie Cai <eddie.cai.linux@gmail.com> >> >> Changes in v6: >> -enable rockusb in defconfig >> >> Changes in v5: >> -none >> >> Changes in v4: >> -move to rk3288_common.h >> >> Changes in v3: >> -move to defconfig >> >> --- >> configs/evb-rk3288_defconfig | 11 +++++++++++ >> configs/fennec-rk3288_defconfig | 8 ++++++++ >> configs/firefly-rk3288_defconfig | 8 ++++++++ >> configs/miqi-rk3288_defconfig | 8 ++++++++ >> configs/popmetal-rk3288_defconfig | 8 ++++++++ >> configs/tinker-rk3288_defconfig | 8 ++++++++ >> include/configs/rk3288_common.h | 7 ------- >> 7 files changed, 51 insertions(+), 7 deletions(-) > > Reviewed-by: Simon Glass <sjg@chromium.org> > > But can you use imply in the Kconfig to enable this for all rk2388 boards? I found only SPL things use imply in the Kconfig. Will it be compiled to SPL if i do so?
Hi Eddie, On 23 May 2017 at 19:43, Eddie Cai <eddie.cai.linux@gmail.com> wrote: > 2017-05-24 8:44 GMT+08:00 Simon Glass <sjg@chromium.org>: >> Hi Eddie, >> >> On 22 May 2017 at 00:43, Eddie Cai <eddie.cai.linux@gmail.com> wrote: >>> this patch enable rockusb support on rk3288 based device. >>> >>> Signed-off-by: Eddie Cai <eddie.cai.linux@gmail.com> >>> >>> Changes in v6: >>> -enable rockusb in defconfig >>> >>> Changes in v5: >>> -none >>> >>> Changes in v4: >>> -move to rk3288_common.h >>> >>> Changes in v3: >>> -move to defconfig >>> >>> --- >>> configs/evb-rk3288_defconfig | 11 +++++++++++ >>> configs/fennec-rk3288_defconfig | 8 ++++++++ >>> configs/firefly-rk3288_defconfig | 8 ++++++++ >>> configs/miqi-rk3288_defconfig | 8 ++++++++ >>> configs/popmetal-rk3288_defconfig | 8 ++++++++ >>> configs/tinker-rk3288_defconfig | 8 ++++++++ >>> include/configs/rk3288_common.h | 7 ------- >>> 7 files changed, 51 insertions(+), 7 deletions(-) >> >> Reviewed-by: Simon Glass <sjg@chromium.org> >> >> But can you use imply in the Kconfig to enable this for all rk2388 boards? > I found only SPL things use imply in the Kconfig. Will it be compiled > to SPL if i do so? The 'imply' keyword only affects the config, it is separate from SPL / non-SPL. If you add imply statements to rk3288 Kconfig, then use 'make savedefconfig' should drop them from defconfig. Regards, Simon
2017-05-25 8:05 GMT+08:00 Simon Glass <sjg@chromium.org>: > Hi Eddie, > > On 23 May 2017 at 19:43, Eddie Cai <eddie.cai.linux@gmail.com> wrote: >> 2017-05-24 8:44 GMT+08:00 Simon Glass <sjg@chromium.org>: >>> Hi Eddie, >>> >>> On 22 May 2017 at 00:43, Eddie Cai <eddie.cai.linux@gmail.com> wrote: >>>> this patch enable rockusb support on rk3288 based device. >>>> >>>> Signed-off-by: Eddie Cai <eddie.cai.linux@gmail.com> >>>> >>>> Changes in v6: >>>> -enable rockusb in defconfig >>>> >>>> Changes in v5: >>>> -none >>>> >>>> Changes in v4: >>>> -move to rk3288_common.h >>>> >>>> Changes in v3: >>>> -move to defconfig >>>> >>>> --- >>>> configs/evb-rk3288_defconfig | 11 +++++++++++ >>>> configs/fennec-rk3288_defconfig | 8 ++++++++ >>>> configs/firefly-rk3288_defconfig | 8 ++++++++ >>>> configs/miqi-rk3288_defconfig | 8 ++++++++ >>>> configs/popmetal-rk3288_defconfig | 8 ++++++++ >>>> configs/tinker-rk3288_defconfig | 8 ++++++++ >>>> include/configs/rk3288_common.h | 7 ------- >>>> 7 files changed, 51 insertions(+), 7 deletions(-) >>> >>> Reviewed-by: Simon Glass <sjg@chromium.org> >>> >>> But can you use imply in the Kconfig to enable this for all rk2388 boards? >> I found only SPL things use imply in the Kconfig. Will it be compiled >> to SPL if i do so? > > The 'imply' keyword only affects the config, it is separate from SPL / non-SPL. > > If you add imply statements to rk3288 Kconfig, then use 'make > savedefconfig' should drop them from defconfig. OK, I will do it in next version > > Regards, > Simon
diff --git a/configs/evb-rk3288_defconfig b/configs/evb-rk3288_defconfig index 227150d..3954139 100644 --- a/configs/evb-rk3288_defconfig +++ b/configs/evb-rk3288_defconfig @@ -17,6 +17,7 @@ CONFIG_CMD_MMC=y CONFIG_CMD_SF=y CONFIG_CMD_SPI=y CONFIG_CMD_I2C=y +CONFIG_CMD_USB=y CONFIG_CMD_GPIO=y # CONFIG_CMD_SETEXPR is not set CONFIG_CMD_CACHE=y @@ -61,6 +62,16 @@ CONFIG_DEBUG_UART_CLOCK=24000000 CONFIG_DEBUG_UART_SHIFT=2 CONFIG_SYS_NS16550=y CONFIG_SYSRESET=y +CONFIG_USB=y +CONFIG_USB_STORAGE=y CONFIG_USE_TINY_PRINTF=y CONFIG_CMD_DHRYSTONE=y CONFIG_ERRNO_STR=y +CONFIG_USB_GADGET=y +CONFIG_USB_GADGET_DOWNLOAD=y +CONFIG_USB_GADGET_VBUS_DRAW=0 +CONFIG_G_DNL_MANUFACTURER="Rockchip" +CONFIG_G_DNL_VENDOR_NUM=0x2207 +CONFIG_G_DNL_PRODUCT_NUM=0x320a +CONFIG_USB_FUNCTION_ROCKUSB=y +CONFIG_CMD_ROCKUSB=y diff --git a/configs/fennec-rk3288_defconfig b/configs/fennec-rk3288_defconfig index befba18..a2e9602 100644 --- a/configs/fennec-rk3288_defconfig +++ b/configs/fennec-rk3288_defconfig @@ -66,3 +66,11 @@ CONFIG_USB_STORAGE=y CONFIG_USE_TINY_PRINTF=y CONFIG_CMD_DHRYSTONE=y CONFIG_ERRNO_STR=y +CONFIG_USB_GADGET=y +CONFIG_USB_GADGET_DOWNLOAD=y +CONFIG_USB_GADGET_VBUS_DRAW=0 +CONFIG_G_DNL_MANUFACTURER="Rockchip" +CONFIG_G_DNL_VENDOR_NUM=0x2207 +CONFIG_G_DNL_PRODUCT_NUM=0x320a +CONFIG_USB_FUNCTION_ROCKUSB=y +CONFIG_CMD_ROCKUSB=y diff --git a/configs/firefly-rk3288_defconfig b/configs/firefly-rk3288_defconfig index f2872a6..3e4b101 100644 --- a/configs/firefly-rk3288_defconfig +++ b/configs/firefly-rk3288_defconfig @@ -73,3 +73,11 @@ CONFIG_CONSOLE_SCROLL_LINES=10 CONFIG_USE_TINY_PRINTF=y CONFIG_CMD_DHRYSTONE=y CONFIG_ERRNO_STR=y +CONFIG_USB_GADGET=y +CONFIG_USB_GADGET_DOWNLOAD=y +CONFIG_USB_GADGET_VBUS_DRAW=0 +CONFIG_G_DNL_MANUFACTURER="Rockchip" +CONFIG_G_DNL_VENDOR_NUM=0x2207 +CONFIG_G_DNL_PRODUCT_NUM=0x320a +CONFIG_USB_FUNCTION_ROCKUSB=y +CONFIG_CMD_ROCKUSB=y diff --git a/configs/miqi-rk3288_defconfig b/configs/miqi-rk3288_defconfig index d93bd97..22505a6 100644 --- a/configs/miqi-rk3288_defconfig +++ b/configs/miqi-rk3288_defconfig @@ -70,3 +70,11 @@ CONFIG_CONSOLE_SCROLL_LINES=10 CONFIG_USE_TINY_PRINTF=y CONFIG_CMD_DHRYSTONE=y CONFIG_ERRNO_STR=y +CONFIG_USB_GADGET=y +CONFIG_USB_GADGET_DOWNLOAD=y +CONFIG_USB_GADGET_VBUS_DRAW=0 +CONFIG_G_DNL_MANUFACTURER="Rockchip" +CONFIG_G_DNL_VENDOR_NUM=0x2207 +CONFIG_G_DNL_PRODUCT_NUM=0x320a +CONFIG_USB_FUNCTION_ROCKUSB=y +CONFIG_CMD_ROCKUSB=y diff --git a/configs/popmetal-rk3288_defconfig b/configs/popmetal-rk3288_defconfig index 748cda4..5fac2ea 100644 --- a/configs/popmetal-rk3288_defconfig +++ b/configs/popmetal-rk3288_defconfig @@ -66,3 +66,11 @@ CONFIG_USB_STORAGE=y CONFIG_USE_TINY_PRINTF=y CONFIG_CMD_DHRYSTONE=y CONFIG_ERRNO_STR=y +CONFIG_USB_GADGET=y +CONFIG_USB_GADGET_DOWNLOAD=y +CONFIG_USB_GADGET_VBUS_DRAW=0 +CONFIG_G_DNL_MANUFACTURER="Rockchip" +CONFIG_G_DNL_VENDOR_NUM=0x2207 +CONFIG_G_DNL_PRODUCT_NUM=0x320a +CONFIG_USB_FUNCTION_ROCKUSB=y +CONFIG_CMD_ROCKUSB=y diff --git a/configs/tinker-rk3288_defconfig b/configs/tinker-rk3288_defconfig index ada5950..85ef248 100644 --- a/configs/tinker-rk3288_defconfig +++ b/configs/tinker-rk3288_defconfig @@ -66,3 +66,11 @@ CONFIG_USB_STORAGE=y CONFIG_USE_TINY_PRINTF=y CONFIG_CMD_DHRYSTONE=y CONFIG_ERRNO_STR=y +CONFIG_USB_GADGET=y +CONFIG_USB_GADGET_DOWNLOAD=y +CONFIG_USB_GADGET_VBUS_DRAW=0 +CONFIG_G_DNL_MANUFACTURER="Rockchip" +CONFIG_G_DNL_VENDOR_NUM=0x2207 +CONFIG_G_DNL_PRODUCT_NUM=0x320a +CONFIG_USB_FUNCTION_ROCKUSB=y +CONFIG_CMD_ROCKUSB=y diff --git a/include/configs/rk3288_common.h b/include/configs/rk3288_common.h index e7a8f72..421ba60 100644 --- a/include/configs/rk3288_common.h +++ b/include/configs/rk3288_common.h @@ -58,11 +58,9 @@ #ifndef CONFIG_SPL_BUILD /* usb otg */ -#define CONFIG_USB_GADGET #define CONFIG_USB_GADGET_DUALSPEED #define CONFIG_USB_GADGET_DWC2_OTG #define CONFIG_ROCKCHIP_USB2_PHY -#define CONFIG_USB_GADGET_VBUS_DRAW 0 /* fastboot */ #define CONFIG_CMD_FASTBOOT @@ -76,11 +74,6 @@ #define CONFIG_USB_FUNCTION_MASS_STORAGE #define CONFIG_CMD_USB_MASS_STORAGE -#define CONFIG_USB_GADGET_DOWNLOAD -#define CONFIG_G_DNL_MANUFACTURER "Rockchip" -#define CONFIG_G_DNL_VENDOR_NUM 0x2207 -#define CONFIG_G_DNL_PRODUCT_NUM 0x320a - /* usb host support */ #ifdef CONFIG_CMD_USB #define CONFIG_USB_DWC2
this patch enable rockusb support on rk3288 based device. Signed-off-by: Eddie Cai <eddie.cai.linux@gmail.com> Changes in v6: -enable rockusb in defconfig Changes in v5: -none Changes in v4: -move to rk3288_common.h Changes in v3: -move to defconfig --- configs/evb-rk3288_defconfig | 11 +++++++++++ configs/fennec-rk3288_defconfig | 8 ++++++++ configs/firefly-rk3288_defconfig | 8 ++++++++ configs/miqi-rk3288_defconfig | 8 ++++++++ configs/popmetal-rk3288_defconfig | 8 ++++++++ configs/tinker-rk3288_defconfig | 8 ++++++++ include/configs/rk3288_common.h | 7 ------- 7 files changed, 51 insertions(+), 7 deletions(-)